Re: [Freeipa-devel] [PATCH] 271 Modified dialog to use sections.

2011-09-23 Thread Endi Sukma Dewata 

On 9/23/2011 4:31 AM, Petr Vobornik wrote:

On 09/22/2011 09:15 PM, Endi Sukma Dewata wrote:


I've split the patch into two: 4a is the revised original patch,

ACK



4b is the additional cleanup for the undo.

you missed: dns.js:562 and host.js:406 . Beside this it's OK.


Fixed. We actually don't need the custom widget for force anymore, but 
this can be cleaned up again later.


Pushed to master and ipa-2-1.

--
Endi S. Dewata
From 3812066719901993737b5b7ae000414f1dc8300e Mon Sep 17 00:00:00 2001
From: Endi S. Dewata edew...@redhat.com
Date: Thu, 22 Sep 2011 11:44:41 -0500
Subject: [PATCH] Removed undo flags from dialog field specs.

Since the undo flag is now automatically set to false in dialogs,
it's no longer necessary to specify it in the field specs.

Ticket #1394
---
 install/ui/aci.js   |   40 ++--
 install/ui/automount.js |   19 +--
 install/ui/dns.js   |   29 -
 install/ui/entitle.js   |   16 +---
 install/ui/group.js |1 -
 install/ui/host.js  |   16 +---
 install/ui/policy.js|3 +--
 install/ui/service.js   |9 +++--
 install/ui/sudo.js  |3 +--
 install/ui/user.js  |   11 +--
 10 files changed, 51 insertions(+), 96 deletions(-)

diff --git a/install/ui/aci.js b/install/ui/aci.js
index 13fbc7d139e5ef69f6974b9b4d32b160a2eeebc5..929e13d4b3af3303c32d2122d8f2147afb99b185 100644
--- a/install/ui/aci.js
+++ b/install/ui/aci.js
@@ -69,22 +69,18 @@ IPA.entity_factories.permission = function() {
 {
 name: 'general',
 fields: [
-{
-name: 'cn',
-undo: false
-},
+'cn',
 {
 factory: IPA.rights_widget,
 name: 'permissions',
-join: true, undo: false
+join: true
 }
 ]
 },
 {
 factory: IPA.target_section,
 name: 'target',
-label: IPA.messages.objects.permission.target,
-undo: false
+label: IPA.messages.objects.permission.target
 }
 ]
 }).
@@ -173,8 +169,7 @@ IPA.entity_factories.selfservice = function() {
 'aciname',
 {factory:IPA.attributes_widget,
  object_type:'user',
- name:'attrs',
- undo: false
+ name:'attrs'
 }]
 }).
 build();
@@ -218,21 +213,20 @@ IPA.entity_factories.delegation = function() {
 factory: IPA.entity_select_widget,
 name: 'group',
 other_entity: 'group',
-other_field: 'cn',
-undo: false
+other_field: 'cn'
 },
 {
 factory: IPA.entity_select_widget,
 name: 'memberof',
 other_entity: 'group',
 other_field: 'cn',
-join: true,
-undo: false
+join: true
 },
 {
-factory:IPA.attributes_widget,
-name: 'attrs', object_type: 'user',
-join: true, undo: false
+factory: IPA.attributes_widget,
+name: 'attrs',
+object_type: 'user',
+join: true
 }]
 }).
 build();
@@ -400,7 +394,6 @@ IPA.target_section = function(spec) {
 spec = spec || {};
 
 var that = IPA.details_section(spec);
-that.undo = typeof spec.undo == 'undefined' ? true : spec.undo;
 
 var target_types = [
 {
@@ -504,31 +497,26 @@ IPA.target_section = function(spec) {
 var init = function() {
 that.filter_text = IPA.text_widget({
 name: 'filter',
-undo: that.undo,
 entity: spec.entity
 });
 that.subtree_textarea = IPA.textarea_widget({
 entity: spec.entity,
 name: 'subtree',
-cols: 30, rows: 1,
-undo: that.undo
+cols: 30, rows: 1
 });
 that.group_select = IPA.entity_select_widget({
 entity: spec.entity,
 name: 'targetgroup',
 other_entity: 'group',
-other_field: 'cn',
-undo: that.undo
+other_field: 'cn'
 });
 that.type_select = IPA.select_widget({
 entity: spec.entity,
-name: 'type',
-undo: that.undo
+name: 'type'
 });
 that.attribute_table =

Re: [Freeipa-devel] [PATCH] 271 Modified dialog to use sections.

2011-09-22 Thread Petr Vobornik 

On 09/21/2011 10:10 PM, Endi Sukma Dewata wrote:
 On 9/21/2011 6:50 AM, Petr Vobornik wrote:

 Fixed. The dialog fields don't need undo, so the text() needs to be
 overridden to disable undo. This can be improved again later.
The override isn't necessary because it wasn't there before and all (at 
least I hope) fields in add dialogs specify undo: false. This feature 
can save some time though. Problem of current implementation is that it 
overrides only the default created section, not the sections specified 
in spec object. But as you wrote - this can be improved later.



 4) host.js:208,217: we should avoid using purely visual inline css
 styles. They should be replaced by class (if cannot be achieved by other
 selector) and styled in css file. This doesn't concern functional styles
 (animations, resizing, hiding, showing).

 Fixed. Yes, we should have a ticket to remove all inline CSS styles.

Are you sure the 'name' attribute is the right way to go? Wouldn't be 
'class' or 'id' (in this case) better? For table data 'name' attribute 
isn't even in HTML spec 
http://dev.w3.org/html5/spec/Overview.html#the-td-element.



--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel