Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-14 Thread Martin Kosek
On 01/13/2015 06:02 PM, Jan Cholasta wrote: Dne 13.1.2015 v 17:45 Jan Cholasta napsal(a): Dne 13.1.2015 v 16:37 Petr Vobornik napsal(a): On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-14 Thread Petr Viktorin
On 01/14/2015 09:14 AM, Martin Kosek wrote: On 01/13/2015 06:02 PM, Jan Cholasta wrote: Rebased again, patch attached. Given that Petr is not there today, I finished the review for him. I did not find any other issues, all issues except (2) are fixed. ACK. Pushed to master (rebased) and

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-14 Thread Martin Kosek
On 01/14/2015 12:35 PM, Petr Viktorin wrote: On 01/14/2015 09:14 AM, Martin Kosek wrote: On 01/13/2015 06:02 PM, Jan Cholasta wrote: Rebased again, patch attached. Given that Petr is not there today, I finished the review for him. I did not find any other issues, all issues except (2) are

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 17:45 Jan Cholasta napsal(a): Dne 13.1.2015 v 16:37 Petr Vobornik napsal(a): On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-13 Thread Petr Vobornik
On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4797. Note that --data with data-only backup and --logs-only with data-only restore are deliberately ignored and considered no-op. Honza 1. I'm not sure how relative path to

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4797. Note that --data with data-only backup and --logs-only with data-only restore are deliberately ignored and considered no-op.

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-13 Thread Petr Vobornik
On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4797. Note that --data with data-only backup and --logs-only with data-only restore are

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-13 Thread Jan Cholasta
Dne 13.1.2015 v 16:37 Petr Vobornik napsal(a): On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4797. Note that --data with data-only

[Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

2015-01-12 Thread Jan Cholasta
Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4797. Note that --data with data-only backup and --logs-only with data-only restore are deliberately ignored and considered no-op. Honza -- Jan Cholasta From 6b14a609d726f5b6dc8e94b1d3d21123637599c1 Mon Sep 17 00:00:00