Re: [Freeipa-devel] [PATCH] 802 add message summary to sudorule
On Wed, 2011-06-15 at 17:29 +, JR Aquino wrote: On Jun 14, 2011, at 6:36 PM, Rob Crittenden wrote: Some of the sudorule commands were missing a message summary. ticket https://fedorahosted.org/freeipa/ticket/1255 rob freeipa-rcrit-802-sudo.patch___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel NACK error: patch failed: ipalib/plugins/sudorule.py:189 error: ipalib/plugins/sudorule.py: patch does not apply Appears to perhaps be off by 1 line number. You might have to rebase. I already ack-ed and pushed this patch to master, ipa-2-0. It applied to the branches without any problem. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 802 add message summary to sudorule
On Tue, 2011-06-14 at 21:36 -0400, Rob Crittenden wrote: Some of the sudorule commands were missing a message summary. ticket https://fedorahosted.org/freeipa/ticket/1255 rob ACK. I checked if any unit test is broken because of newly returned summary field, but its OK. Pushed to master, ipa-2-0. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 802 add message summary to sudorule
On Jun 14, 2011, at 6:36 PM, Rob Crittenden wrote: Some of the sudorule commands were missing a message summary. ticket https://fedorahosted.org/freeipa/ticket/1255 rob freeipa-rcrit-802-sudo.patch___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel NACK error: patch failed: ipalib/plugins/sudorule.py:189 error: ipalib/plugins/sudorule.py: patch does not apply Appears to perhaps be off by 1 line number. You might have to rebase. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 802 add message summary to sudorule
Some of the sudorule commands were missing a message summary.
ticket https://fedorahosted.org/freeipa/ticket/1255
rob
From 3fa78f5ec880974aae2caf35d7850e5a0d910375 Mon Sep 17 00:00:00 2001
From: Rob Crittenden rcrit...@redhat.com
Date: Tue, 14 Jun 2011 21:35:02 -0400
Subject: [PATCH] Add message output summary to sudorule del, mod and find.
https://fedorahosted.org/freeipa/ticket/1255
---
ipalib/plugins/sudorule.py |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/ipalib/plugins/sudorule.py b/ipalib/plugins/sudorule.py
index 01d8714..d38db3a 100644
--- a/ipalib/plugins/sudorule.py
+++ b/ipalib/plugins/sudorule.py
@@ -189,6 +189,7 @@ class sudorule_del(LDAPDelete):
Delete Sudo Rule.
+msg_summary = _('Deleted sudo rule %(value)s')
api.register(sudorule_del)
@@ -197,6 +198,7 @@ class sudorule_mod(LDAPUpdate):
Modify Sudo Rule.
+msg_summary = _('Modified sudo rule %(value)s')
api.register(sudorule_mod)
@@ -205,6 +207,9 @@ class sudorule_find(LDAPSearch):
Search for Sudo Rule.
+msg_summary = ngettext(
+'%(count)d sudo rule matched', '%(count)d sudo rules matched', 0
+)
api.register(sudorule_find)
--
1.7.4
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
