Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-03-29 Thread Petr Viktorin
On 03/29/2012 12:20 AM, Rob Crittenden wrote: I'm using a much narrower scope. I'm not trying to make it easy to manage non-printable characters, just not blow things up if they exist. Limiting to the XML-RPC supported set is for convenience, these are unprintable characters in any context.

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-03-29 Thread Jan Cholasta
On 29.3.2012 00:20, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:45, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:58, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-03-29 Thread Petr Vobornik
On 03/29/2012 12:20 AM, Rob Crittenden wrote: Jan Cholasta wrote: On 29.2.2012 15:45, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:58, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-03-28 Thread Rob Crittenden
Jan Cholasta wrote: On 29.2.2012 15:45, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:58, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-03-01 Thread Jan Cholasta
On 29.2.2012 15:45, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:58, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-29 Thread Petr Viktorin
On 02/28/2012 09:50 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote:

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-29 Thread Jan Cholasta
On 28.2.2012 18:58, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-29 Thread Rob Crittenden
Jan Cholasta wrote: On 28.2.2012 18:58, Rob Crittenden wrote: Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-28 Thread Petr Viktorin
On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-28 Thread Rob Crittenden
Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-28 Thread Petr Viktorin
On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-28 Thread Jan Cholasta
On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-28 Thread Rob Crittenden
Jan Cholasta wrote: On 28.2.2012 18:02, Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon,

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-28 Thread Rob Crittenden
Petr Viktorin wrote: On 02/28/2012 04:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/28/2012 04:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob

[Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type (treated as binary internally). This will result in a base64 encoded blob be

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Petr Viktorin
On 02/27/2012 03:44 PM, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type (treated as binary internally).

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
Petr Viktorin wrote: On 02/27/2012 03:44 PM, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type (treated as

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Simo Sorce
On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type (treated as

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Petr Viktorin
On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes.

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters