Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-12-13 Thread Martin Basti
On 09.12.2015 11:14, Oleg Fayans wrote: Hi Martin On 12/09/2015 10:30 AM, Martin Basti wrote: On 08.12.2015 23:48, Oleg Fayans wrote: Substituted a hardcoded suffix name with a constant DOMAIN_SUFFIX_NAME On 12/08/2015 02:33 PM, Oleg Fayans wrote: Hi all, The patches are rebased

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-12-09 Thread Martin Basti
On 08.12.2015 23:48, Oleg Fayans wrote: Substituted a hardcoded suffix name with a constant DOMAIN_SUFFIX_NAME On 12/08/2015 02:33 PM, Oleg Fayans wrote: Hi all, The patches are rebased against the current master. On 12/02/2015 05:10 PM, Martin Basti wrote: On 02.12.2015 16:18, Oleg

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-12-09 Thread Oleg Fayans
Hi Martin On 12/09/2015 10:30 AM, Martin Basti wrote: > > > On 08.12.2015 23:48, Oleg Fayans wrote: >> Substituted a hardcoded suffix name with a constant DOMAIN_SUFFIX_NAME >> >> On 12/08/2015 02:33 PM, Oleg Fayans wrote: >>> Hi all, >>> >>> >>> The patches are rebased against the current

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-12-08 Thread Oleg Fayans
Hi all, The patches are rebased against the current master. On 12/02/2015 05:10 PM, Martin Basti wrote: > > > On 02.12.2015 16:18, Oleg Fayans wrote: >> Hi Martin, >> >> On 12/01/2015 04:08 PM, Martin Basti wrote: >>> >>> >>> On 27.11.2015 16:26, Oleg Fayans wrote: And patch N 16 passes

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-12-08 Thread Oleg Fayans
Substituted a hardcoded suffix name with a constant DOMAIN_SUFFIX_NAME On 12/08/2015 02:33 PM, Oleg Fayans wrote: > Hi all, > > > The patches are rebased against the current master. > > On 12/02/2015 05:10 PM, Martin Basti wrote: >> >> >> On 02.12.2015 16:18, Oleg Fayans wrote: >>> Hi Martin,

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-12-02 Thread Martin Basti
On 02.12.2015 16:18, Oleg Fayans wrote: Hi Martin, On 12/01/2015 04:08 PM, Martin Basti wrote: On 27.11.2015 16:26, Oleg Fayans wrote: And patch N 16 passes lint too: On 11/27/2015 04:03 PM, Oleg Fayans wrote: Hi, On 11/27/2015 03:26 PM, Martin Basti wrote: On 27.11.2015 15:04, Oleg

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-12-02 Thread Oleg Fayans
Hi Martin, On 12/01/2015 04:08 PM, Martin Basti wrote: On 27.11.2015 16:26, Oleg Fayans wrote: And patch N 16 passes lint too: On 11/27/2015 04:03 PM, Oleg Fayans wrote: Hi, On 11/27/2015 03:26 PM, Martin Basti wrote: On 27.11.2015 15:04, Oleg Fayans wrote: Hi Martin, All your

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-12-01 Thread Martin Basti
On 27.11.2015 16:26, Oleg Fayans wrote: And patch N 16 passes lint too: On 11/27/2015 04:03 PM, Oleg Fayans wrote: Hi, On 11/27/2015 03:26 PM, Martin Basti wrote: On 27.11.2015 15:04, Oleg Fayans wrote: Hi Martin, All your suggestions were taken into account. Both patches are updated.

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-27 Thread Martin Basti
On 27.11.2015 15:04, Oleg Fayans wrote: Hi Martin, All your suggestions were taken into account. Both patches are updated. Thank you for your help! On 11/26/2015 10:50 AM, Martin Basti wrote: On 26.11.2015 10:04, Oleg Fayans wrote: Hi Martin, I agree to all your points but one.

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-27 Thread Oleg Fayans
Hi, On 11/27/2015 03:26 PM, Martin Basti wrote: On 27.11.2015 15:04, Oleg Fayans wrote: Hi Martin, All your suggestions were taken into account. Both patches are updated. Thank you for your help! On 11/26/2015 10:50 AM, Martin Basti wrote: On 26.11.2015 10:04, Oleg Fayans wrote: Hi

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-27 Thread Oleg Fayans
And patch N 16 passes lint too: On 11/27/2015 04:03 PM, Oleg Fayans wrote: Hi, On 11/27/2015 03:26 PM, Martin Basti wrote: On 27.11.2015 15:04, Oleg Fayans wrote: Hi Martin, All your suggestions were taken into account. Both patches are updated. Thank you for your help! On 11/26/2015

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-26 Thread Oleg Fayans
Hi Martin, I agree to all your points but one. please, see my comment below On 11/25/2015 07:42 PM, Martin Basti wrote: Hi, 0) Note Please be aware of https://fedorahosted.org/freeipa/ticket/5469 during KRA testing 1) Please do not use MIN and MAX_DOMAIN_LEVEL constants, this may change over

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-25 Thread Oleg Fayans
Hi, Here is the updated version of the patch (more tests + fixed the issues of the first one) + patch 0017, that implements the necessary changes in the background code, i. e. patch 16 does not work without patch 17 On 11/18/2015 05:20 PM, Martin Basti wrote: On 09.11.2015 15:09, Oleg

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-25 Thread Martin Basti
Hi, 0) Note Please be aware of https://fedorahosted.org/freeipa/ticket/5469 during KRA testing 1) Please do not use MIN and MAX_DOMAIN_LEVEL constants, this may change over time, use DOMAIN_LEVEL_0 and DOMAIN_LEVEL_1 for domain level 0 and 1 2) Why uninstall KRA then server, is not enough

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-23 Thread Martin Basti
On 09.11.2015 17:21, Martin Basti wrote: On 09.11.2015 15:09, Oleg Fayans wrote: Hi guys, Here are first two automated testcases from this (so far incomplete) testplan: http://www.freeipa.org/page/V4/Replica_Promotion/Test_plan Testplan review is highly appreciated Hello, I did

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-18 Thread Martin Basti
On 09.11.2015 15:09, Oleg Fayans wrote: Hi guys, Here are first two automated testcases from this (so far incomplete) testplan: http://www.freeipa.org/page/V4/Replica_Promotion/Test_plan Testplan review is highly appreciated PATCH 16: NACK 1) What is the reason to add an unused

[Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-09 Thread Oleg Fayans
Hi guys, Here are first two automated testcases from this (so far incomplete) testplan: http://www.freeipa.org/page/V4/Replica_Promotion/Test_plan Testplan review is highly appreciated -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 4f82f36f28bdb700331bb353b0d3862ec4d14a8e Mon Sep

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

2015-11-09 Thread Martin Basti
On 09.11.2015 15:09, Oleg Fayans wrote: Hi guys, Here are first two automated testcases from this (so far incomplete) testplan: http://www.freeipa.org/page/V4/Replica_Promotion/Test_plan Testplan review is highly appreciated Hello, I did not test patch, I just read the testplan, I