Re: [Freeipa-devel] [PATCH] Fix Update function on details page.
On 08/17/2010 09:09 AM, Pavel Zuna wrote: On 08/17/2010 03:08 PM, Pavel Zuna wrote: This is a fix to the setattr/addattr problem discussed in the thread: [Freeipa-devel] [PATCH] Change the behaviour of addattr/setattr parameters The problem was that parameters with no values are automatically set to None by the framework and it wasn't handled properly in baseldap.py:get_attributes function. Also, there were two logical bugs in details.js: 1) atttribute callbacks to update values were called for input elements instead of dt elements 2) it was always trying to update the primary key I've seen Adam's fix. It's another way to do it, but I think it's better not to rely on things like element focus to make assumptions about data. There were also some logical bugs in the update code as mentioned above, so this patch is a little bit more complete. By the way; please use Reply All when replying to freeipa-devel threads. Pavel Oups. Forgot to attach the patch. :) Pavel ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Fix Update function on details page.
On 08/17/2010 09:09 AM, Pavel Zuna wrote: On 08/17/2010 03:08 PM, Pavel Zuna wrote: This is a fix to the setattr/addattr problem discussed in the thread: [Freeipa-devel] [PATCH] Change the behaviour of addattr/setattr parameters The problem was that parameters with no values are automatically set to None by the framework and it wasn't handled properly in baseldap.py:get_attributes function. Also, there were two logical bugs in details.js: 1) atttribute callbacks to update values were called for input elements instead of dt elements 2) it was always trying to update the primary key I've seen Adam's fix. It's another way to do it, but I think it's better not to rely on things like element focus to make assumptions about data. There were also some logical bugs in the update code as mentioned above, so this patch is a little bit more complete. By the way; please use Reply All when replying to freeipa-devel threads. Pavel Oups. Forgot to attach the patch. :) Pavel ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Fix Update function on details page.
On 08/17/2010 09:09 AM, Pavel Zuna wrote: On 08/17/2010 03:08 PM, Pavel Zuna wrote: This is a fix to the setattr/addattr problem discussed in the thread: [Freeipa-devel] [PATCH] Change the behaviour of addattr/setattr parameters The problem was that parameters with no values are automatically set to None by the framework and it wasn't handled properly in baseldap.py:get_attributes function. Also, there were two logical bugs in details.js: 1) atttribute callbacks to update values were called for input elements instead of dt elements 2) it was always trying to update the primary key I've seen Adam's fix. It's another way to do it, but I think it's better not to rely on things like element focus to make assumptions about data. There were also some logical bugs in the update code as mentioned above, so this patch is a little bit more complete. By the way; please use Reply All when replying to freeipa-devel threads. Pavel Oups. Forgot to attach the patch. :) Pavel Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
