Re: [Freeipa-devel] [PATCH] Improve serialization to JSON.

2010-08-12 Thread Pavel Zůna
On 2010-08-11 22:55, Rob Crittenden wrote: Pavel Zůna wrote: On 2010-08-10 21:45, Rob Crittenden wrote: Pavel Zuna wrote: - Make it recursive. - Make Param classes serializable. - Take python native data types into account. Pavel Oops, sorry, commented on wrong patch. This looks ok but

Re: [Freeipa-devel] [PATCH] Improve serialization to JSON.

2010-08-12 Thread Rob Crittenden
Pavel Zůna wrote: On 2010-08-11 22:55, Rob Crittenden wrote: Pavel Zůna wrote: On 2010-08-10 21:45, Rob Crittenden wrote: Pavel Zuna wrote: - Make it recursive. - Make Param classes serializable. - Take python native data types into account. Pavel Oops, sorry, commented on wrong patch.

Re: [Freeipa-devel] [PATCH] Improve serialization to JSON.

2010-08-11 Thread Pavel Zůna
On 2010-08-10 21:45, Rob Crittenden wrote: Pavel Zuna wrote: - Make it recursive. - Make Param classes serializable. - Take python native data types into account. Pavel Oops, sorry, commented on wrong patch. This looks ok but you have a serious whitespace issue in the def __json__ method.

[Freeipa-devel] [PATCH] Improve serialization to JSON.

2010-08-10 Thread Pavel Zuna
- Make it recursive. - Make Param classes serializable. - Take python native data types into account. Pavel pzuna-freeipa-0010-json.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] Improve serialization to JSON.

2010-08-10 Thread Rob Crittenden
Pavel Zuna wrote: - Make it recursive. - Make Param classes serializable. - Take python native data types into account. Pavel The code looks ok but export.py doesn't seem like it matches the functions the plugin provides (and is rather generic in nature). Can we rename this json.py or