Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-08-04 Thread Jan Cholasta
Dne 4.8.2015 v 17:02 Robbie Harwood napsal(a): Michael Šimáček writes: Attaching new revision of the patch that performs the full negotiation cycle. Looks good to me, thanks! IPA compiles and installs fine with the patch applied, so ACK. Pushed to master: f0b4c4487ed77a3037cbbc46206d598c5

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-08-04 Thread Robbie Harwood
Michael Šimáček writes: > Attaching new revision of the patch that performs the full negotiation > cycle. Looks good to me, thanks! signature.asc Description: PGP signature -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Co

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-08-03 Thread Simo Sorce
On Mon, 2015-08-03 at 23:56 +0200, Michael Šimáček wrote: > On 2015-07-27 11:38, Simo Sorce wrote: > > On Sun, 2015-07-26 at 21:51 +0200, Michael Šimáček wrote: > >> It would probably be nicer to do the full cycle, but I'd like to > >> avoid > >> changes in behavior when porting from one library to

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-08-03 Thread Michael Šimáček
On 2015-07-27 11:38, Simo Sorce wrote: On Sun, 2015-07-26 at 21:51 +0200, Michael Šimáček wrote: It would probably be nicer to do the full cycle, but I'd like to avoid changes in behavior when porting from one library to another. And the code above doesn't actually hold any connection, so it wou

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-27 Thread Simo Sorce
On Sun, 2015-07-26 at 21:51 +0200, Michael Šimáček wrote: > It would probably be nicer to do the full cycle, but I'd like to > avoid > changes in behavior when porting from one library to another. And the > code above doesn't actually hold any connection, so it would require > more refactoring t

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-26 Thread Michael Šimáček
y, July 21, 2015 8:02:26 AM Subject: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi diff --git a/ipalib/util.py b/ipalib/util.py index 649a487..aea3ba9 100644 --- a/ipalib/util.py +++ b/ipalib/util.py @@ -63,15 +63,15 @@ def json_serialize(obj): def get_current

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-23 Thread Robbie Harwood
sday, July 21, 2015 8:02:26 AM >>> Subject: [Freeipa-devel] [PATCH] Port from python-kerberos library to >>> python-gssapi >>> >>> diff --git a/ipalib/util.py b/ipalib/util.py >>> index 649a487..aea3ba9 100644 >>> --- a/ipalib/util.

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-23 Thread Michael Šimáček
On 2015-07-22 15:47, Simo Sorce wrote: Comments inline. - Original Message - From: "Michael Simacek" To: freeipa-devel@redhat.com Sent: Tuesday, July 21, 2015 8:02:26 AM Subject: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi Hi, This is a

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-22 Thread Simo Sorce
Comments inline. - Original Message - > From: "Michael Simacek" > To: freeipa-devel@redhat.com > Sent: Tuesday, July 21, 2015 8:02:26 AM > Subject: [Freeipa-devel] [PATCH] Port from python-kerberos library to > python-gssapi > > Hi, > > This

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-21 Thread Robbie Harwood
Michael Simacek writes: > This is a first part of my effort to port FreeIPA from Python3-incompatible > Kerberos libraries to python-gssapi. This patch should replace python-kerberos > with python-gssapi (both use C GSSAPI behind the scenes). Okay, Solly and I went through this again, and there

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-21 Thread Gabe Alford
Simacek wrote: > - Original Message - > > From: "Christian Heimes" > > To: freeipa-devel@redhat.com, msima...@redhat.com > > Sent: Tuesday, July 21, 2015 2:23:06 PM > > Subject: Re: [Freeipa-devel] [PATCH] Port from python-kerberos library > to p

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-21 Thread Robbie Harwood
Michael Simacek writes: > - Original Message - >> From: "Christian Heimes" >> To: freeipa-devel@redhat.com, msima...@redhat.com >> Sent: Tuesday, July 21, 2015 2:23:06 PM >> Subject: Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-21 Thread Michael Simacek
- Original Message - > From: "Christian Heimes" > To: freeipa-devel@redhat.com, msima...@redhat.com > Sent: Tuesday, July 21, 2015 2:23:06 PM > Subject: Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to > python-gssapi > > On 2015-07-

Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-21 Thread Christian Heimes
On 2015-07-21 14:02, Michael Simacek wrote: > Hi, > > This is a first part of my effort to port FreeIPA from Python3-incompatible > Kerberos libraries to python-gssapi. This patch should replace python-kerberos > with python-gssapi (both use C GSSAPI behind the scenes). > def _handle_excepti

[Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-21 Thread Michael Simacek
Hi, This is a first part of my effort to port FreeIPA from Python3-incompatible Kerberos libraries to python-gssapi. This patch should replace python-kerberos with python-gssapi (both use C GSSAPI behind the scenes). -- Michael Simacek >From bca55a6bd9cdb9cdea9d81b55cfdbc2c1279f031 Mon Sep 17 0