Re: [Freeipa-devel] [PATCH] bind-dyndb-ldap: Don't leave empty nodes in LDAP after DDNS update

2011-01-14 Thread Simo Sorce
On Wed, 12 Jan 2011 13:27:24 -0500 Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/12/2011 01:25 PM, Adam Tkac wrote: > > On Wed, Jan 12, 2011 at 01:15:36PM -0500, Stephen Gallagher wrote: > >> Nack. > >> > >> Your prototype for ldap_modify_do() includes 'isc

Re: [Freeipa-devel] [PATCH] bind-dyndb-ldap: Don't leave empty nodes in LDAP after DDNS update

2011-01-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/12/2011 01:25 PM, Adam Tkac wrote: > On Wed, Jan 12, 2011 at 01:15:36PM -0500, Stephen Gallagher wrote: >> Nack. >> >> Your prototype for ldap_modify_do() includes 'isc_result_t delete_node', >> but the actual implementation expects 'isc_boolean_

Re: [Freeipa-devel] [PATCH] bind-dyndb-ldap: Don't leave empty nodes in LDAP after DDNS update

2011-01-12 Thread Adam Tkac
On Wed, Jan 12, 2011 at 01:15:36PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/12/2011 07:37 AM, Adam Tkac wrote: > > Hello, > > > > bind-dyndb-ldap currently leaves empty nodes in LDAP when the last > > DNS resource record associated with the node

Re: [Freeipa-devel] [PATCH] bind-dyndb-ldap: Don't leave empty nodes in LDAP after DDNS update

2011-01-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/12/2011 07:37 AM, Adam Tkac wrote: > Hello, > > bind-dyndb-ldap currently leaves empty nodes in LDAP when the last > DNS resource record associated with the node was removed: > > Before DDNS update: > > dn: idnsName=test,idnsName=example.com,o

[Freeipa-devel] [PATCH] bind-dyndb-ldap: Don't leave empty nodes in LDAP after DDNS update

2011-01-12 Thread Adam Tkac
Hello, bind-dyndb-ldap currently leaves empty nodes in LDAP when the last DNS resource record associated with the node was removed: Before DDNS update: dn: idnsName=test,idnsName=example.com,ou=dns,dc=example,dc=com aRecord: 1.1.1.1 dNSTTL: objectClass: idnsRecord idnsName: test After DDNS