On 07/23/2009 09:01 PM, Dmitri Pal wrote:
We are considering combining the log monitor with audit collection.
These are two separate functions it would be logical
to have them in separate threads.
The architecture is and will be event driven with a main event loop. In
most cases event loops
Debug messages should NEVER be conditionally compiled. For an
executable, they should always be set by a runtime flag, and for a
library they should always be set by an argument to the initialization
function or by an environment variable. It should always be possible for
someone running
On 07/23/2009 09:01 PM, Dmitri Pal wrote:
1) There is generally a lack of comments in the code. it is very hard to
read.
IMO the lack of comments is a style issue rather then maturity of the
code issue.
13) I was amazed how well the path_util interface is defined and
documented .
As you
On 07/22/2009 03:05 PM, Stephen Gallagher wrote:
Nack. The following things must be corrected before this patch will be
accepted.
General:
The log file /tmp/lwatch.log is not usable by two users simultaneously.
Each user should have his/her own log file or there should be a
mechanism in place
