The docstring of interactive_prompt_callback could use some tweaking,
but besides that re-ACK.
Dne 21.8.2014 v 14:50 Gabe Alford napsal(a):
Hello,
Just wondering if this needs to be re-ack'd.
Thanks,
Gabe
On Thu, Jul 31, 2014 at 7:57 AM, Gabe Alford redhatri...@gmail.com
Thanks. Pushed to:
master: 9415aba87789512e34cb4ed62534cde7822ff70b
ipa-4-1: 8bb2af0e0ca375e10a406883ada5769963813763
ipa-4-0: b708001074e1fc1e412bc18b1e5e0b408151847b
Martin
On 08/25/2014 12:00 PM, Jan Cholasta wrote:
The docstring of interactive_prompt_callback could use some tweaking, but
Hello,
Just wondering if this needs to be re-ack'd.
Thanks,
Gabe
On Thu, Jul 31, 2014 at 7:57 AM, Gabe Alford redhatri...@gmail.com wrote:
Okay. Sounds good. Update patch attached.
On Thu, Jul 31, 2014 at 7:18 AM, Martin Kosek mko...@redhat.com wrote:
Ah, right. But I still
Dne 24.7.2014 v 00:15 Gabe Alford napsal(a):
Nope. Somehow in my head it felt cleaner. Updated patched attached.
On Wed, Jul 23, 2014 at 1:18 AM, Jan Cholasta jchol...@redhat.com
mailto:jchol...@redhat.com wrote:
On 23.7.2014 01:01, Gabe Alford wrote:
Forgot about --trust-secret.
On Thu, 31 Jul 2014, Martin Kosek wrote:
Sorry for going late in the game, just a quick question - why do we want to add
this part:
+if trust_type is None:
+kw['trust_type'] = self.prompt_param(self.params['trust_type'])
? I do not see a reason for adding a special
On 07/31/2014 10:47 AM, Jan Cholasta wrote:
Dne 24.7.2014 v 00:15 Gabe Alford napsal(a):
Nope. Somehow in my head it felt cleaner. Updated patched attached.
On Wed, Jul 23, 2014 at 1:18 AM, Jan Cholasta jchol...@redhat.com
mailto:jchol...@redhat.com wrote:
On 23.7.2014 01:01, Gabe
Right. The reason I added it in there is that I could see that in the
future trust_type could be more than just 'ad' (maybe 'ipa', 'krb', etc?)
which at that point I'm not sure a default makes sense. So, I thought to go
ahead and add the check for future use cases so that it doesn't have to be
Ah, right. But I still think that's a too-early optimization. We can add this
callback when this necessity arises. Until then, I would rather prefer to keep
the code clean.
Martin
On 07/31/2014 03:17 PM, Gabe Alford wrote:
Right. The reason I added it in there is that I could see that in the
Okay. Sounds good. Update patch attached.
On Thu, Jul 31, 2014 at 7:18 AM, Martin Kosek mko...@redhat.com wrote:
Ah, right. But I still think that's a too-early optimization. We can add
this
callback when this necessity arises. Until then, I would rather prefer to
keep
the code clean.
On 23.7.2014 01:01, Gabe Alford wrote:
Forgot about --trust-secret. Here is an updated patch.
On Mon, Jul 21, 2014 at 2:31 AM, Jan Cholasta jchol...@redhat.com
mailto:jchol...@redhat.com wrote:
On 21.7.2014 10:28, Martin Kosek wrote:
On 07/21/2014 09:56 AM, Jan Cholasta wrote:
Nope. Somehow in my head it felt cleaner. Updated patched attached.
On Wed, Jul 23, 2014 at 1:18 AM, Jan Cholasta jchol...@redhat.com wrote:
On 23.7.2014 01:01, Gabe Alford wrote:
Forgot about --trust-secret. Here is an updated patch.
On Mon, Jul 21, 2014 at 2:31 AM, Jan Cholasta
Forgot about --trust-secret. Here is an updated patch.
On Mon, Jul 21, 2014 at 2:31 AM, Jan Cholasta jchol...@redhat.com wrote:
On 21.7.2014 10:28, Martin Kosek wrote:
On 07/21/2014 09:56 AM, Jan Cholasta wrote:
Hi,
On 16.7.2014 05:48, Gabe Alford wrote:
Hello,
Adds AD admin and
Hi,
On 16.7.2014 05:48, Gabe Alford wrote:
Hello,
Adds AD admin and password to interactive commands.
https://fedorahosted.org/freeipa/ticket/3034
Thanks,
Gabe
I think that instead of making the parameters mandatory, you should
instead set alwaysask=True on them.
Honza
--
Jan Cholasta
On 07/21/2014 09:56 AM, Jan Cholasta wrote:
Hi,
On 16.7.2014 05:48, Gabe Alford wrote:
Hello,
Adds AD admin and password to interactive commands.
https://fedorahosted.org/freeipa/ticket/3034
Thanks,
Gabe
I think that instead of making the parameters mandatory, you should instead
On 21.7.2014 10:28, Martin Kosek wrote:
On 07/21/2014 09:56 AM, Jan Cholasta wrote:
Hi,
On 16.7.2014 05:48, Gabe Alford wrote:
Hello,
Adds AD admin and password to interactive commands.
https://fedorahosted.org/freeipa/ticket/3034
Thanks,
Gabe
I think that instead of making the
Hello,
Adds AD admin and password to interactive commands.
https://fedorahosted.org/freeipa/ticket/3034
Thanks,
Gabe
From ddea4f0a8915a10aa8d9ac5dd2b78e2032ee335f Mon Sep 17 00:00:00 2001
From: Gabe redhatri...@gmail.com
Date: Tue, 15 Jul 2014 20:34:12 -0600
Subject: [PATCH] ipa trust-add
16 matches
Mail list logo
