Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 29.10.2015 18:32, Martin Basti wrote: On 29.10.2015 18:31, Martin Basti wrote: NACK 1) DO NOT use tabs in code to indent 2) Replica uninstallation does not work, uninstallation works different with domain level 0 and 1 (currently uninstallation with domain 1 level will not work, it

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

Hi Martin, On 11/02/2015 10:39 AM, Martin Basti wrote: On 29.10.2015 18:32, Martin Basti wrote: On 29.10.2015 18:31, Martin Basti wrote: NACK 1) DO NOT use tabs in code to indent Fixed 2) Replica uninstallation does not work, uninstallation works different with domain level 0 and 1

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 29.10.2015 18:31, Martin Basti wrote: NACK 1) DO NOT use tabs in code to indent 2) Replica uninstallation does not work, uninstallation works different with domain level 0 and 1 (currently uninstallation with domain 1 level will not work, it is known issue, but still the patch should

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

Hi Martin, The updated version of the patch is attached. Please, see my comments below On 10/26/2015 06:48 PM, Martin Basti wrote: On 26.10.2015 08:59, Oleg Fayans wrote: On 10/23/2015 03:10 PM, Martin Basti wrote: On 23.10.2015 15:00, Oleg Fayans wrote: Hi Martin, Here comes the

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached. Please, see my comments below My comments inline, I may be completely wrong in how the test suite work, so feel free to correct me. Martin On

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached. Please, see my comments below My comments inline, I may be completely wrong in how the test suite work, so feel free to correct me. Martin On 10/26/2015 06:48 PM, Martin Basti wrote: On

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 27.10.2015 13:56, Oleg Fayans wrote: On 10/27/2015 01:22 PM, Martin Basti wrote: On 27.10.2015 12:06, Oleg Fayans wrote: Hi Martin, On 10/27/2015 10:50 AM, Martin Basti wrote: On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 10/27/2015 01:22 PM, Martin Basti wrote: On 27.10.2015 12:06, Oleg Fayans wrote: Hi Martin, On 10/27/2015 10:50 AM, Martin Basti wrote: On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached.

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

Hi Martin, On 10/27/2015 10:50 AM, Martin Basti wrote: On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached. Please, see my comments below My comments inline, I may be completely wrong in how the test

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 27.10.2015 12:06, Oleg Fayans wrote: Hi Martin, On 10/27/2015 10:50 AM, Martin Basti wrote: On 27.10.2015 10:22, Martin Basti wrote: On 27.10.2015 10:00, Oleg Fayans wrote: Hi Martin, The updated version of the patch is attached. Please, see my comments below My comments inline, I

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 10/23/2015 03:10 PM, Martin Basti wrote: On 23.10.2015 15:00, Oleg Fayans wrote: Hi Martin, Here comes the updated version. On 10/22/2015 05:38 PM, Martin Basti wrote: On 22.10.2015 15:23, Martin Basti wrote: On 22.10.2015 14:13, Oleg Fayans wrote: Hello, thank you for the

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 26.10.2015 08:59, Oleg Fayans wrote: On 10/23/2015 03:10 PM, Martin Basti wrote: On 23.10.2015 15:00, Oleg Fayans wrote: Hi Martin, Here comes the updated version. On 10/22/2015 05:38 PM, Martin Basti wrote: On 22.10.2015 15:23, Martin Basti wrote: On 22.10.2015 14:13, Oleg

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 23.10.2015 15:00, Oleg Fayans wrote: Hi Martin, Here comes the updated version. On 10/22/2015 05:38 PM, Martin Basti wrote: On 22.10.2015 15:23, Martin Basti wrote: On 22.10.2015 14:13, Oleg Fayans wrote: Hello, thank you for the patch. 1) please remove the added empty lines,

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

Hi Martin, Here comes the updated version. On 10/22/2015 05:38 PM, Martin Basti wrote: On 22.10.2015 15:23, Martin Basti wrote: On 22.10.2015 14:13, Oleg Fayans wrote: Hello, thank you for the patch. 1) please remove the added empty lines, they are unrelated to this ticket done

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 23.10.2015 15:00, Oleg Fayans wrote: Hi Martin, Here comes the updated version. On 10/22/2015 05:38 PM, Martin Basti wrote: On 22.10.2015 15:23, Martin Basti wrote: On 22.10.2015 14:13, Oleg Fayans wrote: Hello, thank you for the patch. 1) please remove the added empty lines,

[Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

-- Oleg Fayans Quality Engineer FreeIPA team RedHat. From c0a41ec0fbfb70ac33fd97beb1641ecfa126a87d Mon Sep 17 00:00:00 2001 From: Oleg Fayans Date: Thu, 22 Oct 2015 14:05:24 +0200 Subject: [PATCH] Updated the tests according to the new replica installation workflow As of

Re: [Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

On 22.10.2015 14:13, Oleg Fayans wrote: Hello, thank you for the patch. 1) please remove the added empty lines, they are unrelated to this ticket 2) -def install_master(host, setup_dns=True, setup_kra=False): +def install_master(host, setup_dns=True, setup_kra=False, domainlevel=1): I