Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-11-08 Thread Petr Viktorin
On 11/07/2013 07:48 PM, Nathaniel McCallum wrote: On Mon, 2013-10-07 at 16:22 +0200, Petr Viktorin wrote: Sorry for the delay. On 09/25/2013 10:51 PM, Nathaniel McCallum wrote: On Mon, 2013-09-23 at 15:19 +0200, Petr Viktorin wrote: Great, we're getting close! [...] There's another test

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-10 Thread Jan Cholasta
On 12.9.2013 22:47, Nathaniel McCallum wrote: On Thu, 2013-09-05 at 00:04 -0400, Nathaniel McCallum wrote: patch attached Update for ./makeapi attached. Is ipaUserAuthType relevant only to Kerberos or to user authentication in general? For example, if password is removed from

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-10 Thread Nathaniel McCallum
On Thu, 2013-10-10 at 10:04 +0200, Jan Cholasta wrote: On 12.9.2013 22:47, Nathaniel McCallum wrote: On Thu, 2013-09-05 at 00:04 -0400, Nathaniel McCallum wrote: patch attached Update for ./makeapi attached. Is ipaUserAuthType relevant only to Kerberos or to user authentication in

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-10 Thread Jan Cholasta
On 10.10.2013 16:51, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 10:04 +0200, Jan Cholasta wrote: On 12.9.2013 22:47, Nathaniel McCallum wrote: On Thu, 2013-09-05 at 00:04 -0400, Nathaniel McCallum wrote: patch attached Update for ./makeapi attached. Is ipaUserAuthType relevant only

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-10 Thread Dmitri Pal
On 10/10/2013 10:51 AM, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 10:04 +0200, Jan Cholasta wrote: On 12.9.2013 22:47, Nathaniel McCallum wrote: On Thu, 2013-09-05 at 00:04 -0400, Nathaniel McCallum wrote: patch attached Update for ./makeapi attached. Is ipaUserAuthType relevant only

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-10 Thread Dmitri Pal
On 10/10/2013 11:30 AM, Jan Cholasta wrote: On 10.10.2013 16:51, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 10:04 +0200, Jan Cholasta wrote: On 12.9.2013 22:47, Nathaniel McCallum wrote: On Thu, 2013-09-05 at 00:04 -0400, Nathaniel McCallum wrote: patch attached Update for ./makeapi

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-10 Thread Nathaniel McCallum
On Thu, 2013-10-10 at 12:44 -0400, Dmitri Pal wrote: On 10/10/2013 10:51 AM, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 10:04 +0200, Jan Cholasta wrote: On 12.9.2013 22:47, Nathaniel McCallum wrote: On Thu, 2013-09-05 at 00:04 -0400, Nathaniel McCallum wrote: patch attached Update

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-10 Thread Dmitri Pal
On 10/10/2013 03:13 PM, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 12:44 -0400, Dmitri Pal wrote: On 10/10/2013 10:51 AM, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 10:04 +0200, Jan Cholasta wrote: On 12.9.2013 22:47, Nathaniel McCallum wrote: On Thu, 2013-09-05 at 00:04 -0400,

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-10 Thread Nathaniel McCallum
On Thu, 2013-10-10 at 15:53 -0400, Dmitri Pal wrote: On 10/10/2013 03:13 PM, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 12:44 -0400, Dmitri Pal wrote: On 10/10/2013 10:51 AM, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 10:04 +0200, Jan Cholasta wrote: On 12.9.2013 22:47,

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-10 Thread Dmitri Pal
On 10/10/2013 08:33 PM, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 15:53 -0400, Dmitri Pal wrote: On 10/10/2013 03:13 PM, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 12:44 -0400, Dmitri Pal wrote: On 10/10/2013 10:51 AM, Nathaniel McCallum wrote: On Thu, 2013-10-10 at 10:04 +0200,

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-10-07 Thread Petr Viktorin
Sorry for the delay. On 09/25/2013 10:51 PM, Nathaniel McCallum wrote: On Mon, 2013-09-23 at 15:19 +0200, Petr Viktorin wrote: Great, we're getting close! [...] There's another test failure when trying to rename a manager user. I didn't investigate in detail why that happens. Does the

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-09-25 Thread Nathaniel McCallum
On Mon, 2013-09-23 at 15:19 +0200, Petr Viktorin wrote: Great, we're getting close! Please send patches in `git format-patch` style (they include commit info). I usually do, I don't know what happened this last time. Sorry! :) Also, please bump the API revision in VERSION since API.txt was

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-09-23 Thread Petr Viktorin
On 09/18/2013 09:51 PM, Nathaniel McCallum wrote: On Mon, 2013-09-09 at 15:35 +0200, Petr Viktorin wrote: On 09/05/2013 06:04 AM, Nathaniel McCallum wrote: patch attached Thanks, some comments below. Git complains about trailing whitespace in the patch, please strip it. Fixed.

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-09-18 Thread Nathaniel McCallum
On Mon, 2013-09-09 at 15:35 +0200, Petr Viktorin wrote: On 09/05/2013 06:04 AM, Nathaniel McCallum wrote: patch attached Thanks, some comments below. Git complains about trailing whitespace in the patch, please strip it. Fixed.

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-09-13 Thread Nathaniel McCallum
On Thu, 2013-09-05 at 00:04 -0400, Nathaniel McCallum wrote: patch attached Update for ./makeapi attached. From 71da5f82a609f9d52b3f69a50b0006cbec13b512 Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum npmccal...@redhat.com Date: Wed, 4 Sep 2013 23:35:36 -0400 Subject: [PATCH] Add support for

Re: [Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-09-09 Thread Petr Viktorin
On 09/05/2013 06:04 AM, Nathaniel McCallum wrote: patch attached Thanks, some comments below. Git complains about trailing whitespace in the patch, please strip it. freeipa-npmccallum-0015-Add-support-for-managing-user-auth-types.patch From 757436ccc431d26a3e62de830dad0b107a6c48ff Mon

[Freeipa-devel] [PATCH 0015] Add support for managing user auth types

2013-09-04 Thread Nathaniel McCallum
patch attached From 757436ccc431d26a3e62de830dad0b107a6c48ff Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum npmccal...@redhat.com Date: Wed, 4 Sep 2013 23:35:36 -0400 Subject: [PATCH] Add support for managing user auth types https://fedorahosted.org/freeipa/ticket/3368 ---