Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-26 Thread Tomas Babej
ACK. Pushed to: ipa-4-1: ddd7fb6a68fd413b1561eab9c29bac18882e5efd master: ae4ee6b53376bb7f3d1b4707c4e105c91b5cd8ab On 02/26/2015 05:58 PM, Gabe Alford wrote: Yeah. That makes more sense. Updated patch attached. Thanks, Gabe On Wed, Feb 25, 2015 at 3:55 PM, Tomas Babej

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-26 Thread Gabe Alford
Yeah. That makes more sense. Updated patch attached. Thanks, Gabe On Wed, Feb 25, 2015 at 3:55 PM, Tomas Babej wrote: > Hi Gabe, > > sorry for not being clear. This approach will not work: > > +class TestAdvice(BaseTestInvalidAdvice, > + BaseTestFedoraAuthconfig, > +

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-25 Thread Tomas Babej
Hi Gabe, sorry for not being clear. This approach will not work: +class TestAdvice(BaseTestInvalidAdvice, + BaseTestFedoraAuthconfig, + BaseTestFreeBSDNSSPAM, + BaseTestGenericNSSPAM, + BaseTestGenericSSSDBefore19, +

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-25 Thread Gabe Alford
No worries about the delay. Thanks for taking the time! Updated patch attached. Thanks, Gabe On Tue, Feb 24, 2015 at 11:03 AM, Tomas Babej wrote: > Hi Gabe, > > sorry for the delay. Here comes the review! > 1.) All the tests fail, since the IPA master is not installed at all: > > def test

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-24 Thread Tomas Babej
Hi Gabe, sorry for the delay. Here comes the review! 1.) All the tests fail, since the IPA master is not installed at all: def test_advice(self): # Obtain the advice from the server tasks.kinit_admin(self.master) test_integration/test_advise.py:37: _ _ _ _ _ _ _ _ _ _ _ _ _

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-02-17 Thread Gabe Alford
Hello, I was wondering if I could get a review of this patch. Thanks, Gabe On Thursday, January 29, 2015, Gabe Alford wrote: > Hello, > >Here is a patch for https://fedorahosted.org/freeipa/ticket/4029 I > added test cases for valid and invalid advice. > > Thanks, > > Gabe > >

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-29 Thread Gabe Alford
Hello, Here is a patch for https://fedorahosted.org/freeipa/ticket/4029 I added test cases for valid and invalid advice. Thanks, Gabe On Wed, Jan 14, 2015 at 10:23 AM, Tomas Babej wrote: > > On 01/14/2015 06:13 PM, Gabe Alford wrote: > > On Wed, Jan 14, 2015 at 10:05 AM, Tomas Babej

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 06:13 PM, Gabe Alford wrote: > On Wed, Jan 14, 2015 at 10:05 AM, Tomas Babej > wrote: > > > On 01/14/2015 06:00 PM, Tomas Babej wrote: >> >> On 01/14/2015 05:37 PM, Tomas Babej wrote: >>> >>> On 01/14/2015 02:55 PM, Gabe Alford wrote: H

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 06:00 PM, Tomas Babej wrote: > > On 01/14/2015 05:37 PM, Tomas Babej wrote: >> >> On 01/14/2015 02:55 PM, Gabe Alford wrote: >>> Hello, >>> >>>In looking into https://fedorahosted.org/freeipa/ticket/4029 >>> I am wondering if there should be separate ipa-advise test, Yes/No?

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Gabe Alford
On Wed, Jan 14, 2015 at 10:05 AM, Tomas Babej wrote: > > On 01/14/2015 06:00 PM, Tomas Babej wrote: > > > On 01/14/2015 05:37 PM, Tomas Babej wrote: > > > On 01/14/2015 02:55 PM, Gabe Alford wrote: > > Hello, > > In looking into https://fedorahosted.org/freeipa/ticket/4029 I am > wonder

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 05:37 PM, Tomas Babej wrote: > > On 01/14/2015 02:55 PM, Gabe Alford wrote: >> Hello, >> >>In looking into https://fedorahosted.org/freeipa/ticket/4029 I >> am wondering if there should be separate ipa-advise test, Yes/No? >> Could be handy in the future to test more ipa-advi

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Tomas Babej
On 01/14/2015 02:55 PM, Gabe Alford wrote: > Hello, > >In looking into https://fedorahosted.org/freeipa/ticket/4029 I > am wondering if there should be separate ipa-advise test, Yes/No? > Could be handy in the future to test more ipa-advise output? Or should > this test be added to the tes

Re: [Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2015-01-14 Thread Gabe Alford
Hello, In looking into https://fedorahosted.org/freeipa/ticket/4029 I am wondering if there should be separate ipa-advise test, Yes/No? Could be handy in the future to test more ipa-advise output? Or should this test be added to the test_legacy_clients.py? Thanks, Gabe On Tue, Dec 2, 201

[Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

2014-12-02 Thread Gabe Alford
Hello, I was going to try my hand at attempting a patch for ipa-tests. However in wanting to test my patch, I am not sure how to run ipa-tests to check if it works or not. Documentation is not really clear on what needs to be done to start a test and run a test. This is for https://fedorahosted.or