Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-08-16 Thread Stanislav Laznicka
On 08/16/2016 01:03 PM, Martin Basti wrote: On 16.08.2016 12:06, Stanislav Laznicka wrote: On 08/16/2016 08:36 AM, Stanislav Laznicka wrote: On 08/02/2016 01:08 PM, Stanislav Laznicka wrote: On 07/28/2016 10:57 AM, Martin Basti wrote: Hello, suprisingly, patch needs rebase :) 1) Is the

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-08-16 Thread Martin Basti
On 16.08.2016 12:06, Stanislav Laznicka wrote: On 08/16/2016 08:36 AM, Stanislav Laznicka wrote: On 08/02/2016 01:08 PM, Stanislav Laznicka wrote: On 07/28/2016 10:57 AM, Martin Basti wrote: Hello, suprisingly, patch needs rebase :) 1) Is the script error the right Exception? I chose

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-08-16 Thread Stanislav Laznicka
On 08/16/2016 08:36 AM, Stanislav Laznicka wrote: On 08/02/2016 01:08 PM, Stanislav Laznicka wrote: On 07/28/2016 10:57 AM, Martin Basti wrote: Hello, suprisingly, patch needs rebase :) 1) Is the script error the right Exception? I chose ScriptError because it's able to change the return

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-08-16 Thread Stanislav Laznicka
On 08/02/2016 01:08 PM, Stanislav Laznicka wrote: On 07/28/2016 10:57 AM, Martin Basti wrote: Hello, suprisingly, patch needs rebase :) 1) Is the script error the right Exception? I chose ScriptError because it's able to change the return value of the script, which is necessary sometimes.

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-08-02 Thread Stanislav Laznicka
On 07/28/2016 10:57 AM, Martin Basti wrote: On 17.06.2016 13:56, Stanislav Laznicka wrote: On 06/17/2016 01:01 PM, Petr Vobornik wrote: On 17.6.2016 12:12, Stanislav Laznicka wrote: On 06/17/2016 09:51 AM, Petr Vobornik wrote: On 17.6.2016 09:24, Stanislav Laznicka wrote: On 06/17/2016

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-07-28 Thread Martin Basti
On 17.06.2016 13:56, Stanislav Laznicka wrote: On 06/17/2016 01:01 PM, Petr Vobornik wrote: On 17.6.2016 12:12, Stanislav Laznicka wrote: On 06/17/2016 09:51 AM, Petr Vobornik wrote: On 17.6.2016 09:24, Stanislav Laznicka wrote: On 06/17/2016 08:48 AM, Petr Spacek wrote: On 17.6.2016

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-17 Thread Stanislav Laznicka
On 06/17/2016 01:01 PM, Petr Vobornik wrote: On 17.6.2016 12:12, Stanislav Laznicka wrote: On 06/17/2016 09:51 AM, Petr Vobornik wrote: On 17.6.2016 09:24, Stanislav Laznicka wrote: On 06/17/2016 08:48 AM, Petr Spacek wrote: On 17.6.2016 08:43, Stanislav Laznicka wrote: On 06/17/2016 07:45

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-17 Thread Petr Vobornik
On 17.6.2016 12:12, Stanislav Laznicka wrote: > On 06/17/2016 09:51 AM, Petr Vobornik wrote: >> On 17.6.2016 09:24, Stanislav Laznicka wrote: >>> On 06/17/2016 08:48 AM, Petr Spacek wrote: On 17.6.2016 08:43, Stanislav Laznicka wrote: > On 06/17/2016 07:45 AM, Petr Spacek wrote: >> On

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-17 Thread Stanislav Laznicka
On 06/17/2016 09:51 AM, Petr Vobornik wrote: On 17.6.2016 09:24, Stanislav Laznicka wrote: On 06/17/2016 08:48 AM, Petr Spacek wrote: On 17.6.2016 08:43, Stanislav Laznicka wrote: On 06/17/2016 07:45 AM, Petr Spacek wrote: On 16.6.2016 17:33, Stanislav Laznicka wrote: Hello, This patch

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-17 Thread Petr Spacek
On 17.6.2016 09:24, Stanislav Laznicka wrote: > On 06/17/2016 08:48 AM, Petr Spacek wrote: >> On 17.6.2016 08:43, Stanislav Laznicka wrote: >>> On 06/17/2016 07:45 AM, Petr Spacek wrote: On 16.6.2016 17:33, Stanislav Laznicka wrote: > Hello, > > This patch removes most sys.exits()

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-17 Thread Petr Vobornik
On 17.6.2016 09:24, Stanislav Laznicka wrote: > On 06/17/2016 08:48 AM, Petr Spacek wrote: >> On 17.6.2016 08:43, Stanislav Laznicka wrote: >>> On 06/17/2016 07:45 AM, Petr Spacek wrote: On 16.6.2016 17:33, Stanislav Laznicka wrote: > Hello, > > This patch removes most sys.exits()

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-17 Thread Stanislav Laznicka
On 06/17/2016 08:48 AM, Petr Spacek wrote: On 17.6.2016 08:43, Stanislav Laznicka wrote: On 06/17/2016 07:45 AM, Petr Spacek wrote: On 16.6.2016 17:33, Stanislav Laznicka wrote: Hello, This patch removes most sys.exits() from installer modules and scripts and replaces them with ScriptError.

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-17 Thread Petr Spacek
On 17.6.2016 08:43, Stanislav Laznicka wrote: > On 06/17/2016 07:45 AM, Petr Spacek wrote: >> On 16.6.2016 17:33, Stanislav Laznicka wrote: >>> Hello, >>> >>> This patch removes most sys.exits() from installer modules and scripts and >>> replaces them with ScriptError. I only left sys.exits at

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-17 Thread Stanislav Laznicka
On 06/17/2016 07:45 AM, Petr Spacek wrote: On 16.6.2016 17:33, Stanislav Laznicka wrote: Hello, This patch removes most sys.exits() from installer modules and scripts and replaces them with ScriptError. I only left sys.exits at places where the user decides yes/no on continuation of the

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-16 Thread Petr Spacek
On 16.6.2016 17:33, Stanislav Laznicka wrote: > Hello, > > This patch removes most sys.exits() from installer modules and scripts and > replaces them with ScriptError. I only left sys.exits at places where the user > decides yes/no on continuation of the script. I wonder if yes/no should be

[Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-06-16 Thread Stanislav Laznicka
Hello, This patch removes most sys.exits() from installer modules and scripts and replaces them with ScriptError. I only left sys.exits at places where the user decides yes/no on continuation of the script. From 7968f068141e53f7bf111221b38c40cac432 Mon Sep 17 00:00:00 2001 From: