sudorule_mod was ill-conceived, it does not respect the logic
surrounding external users. Suggested to use sudorule_add and
sudorule_del for modification.
--
John Dennis <jden...@redhat.com>
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
From dc724c5f5baee84d252cbc8994e2462a6c8ae995 Mon Sep 17 00:00:00 2001
From: John Dennis <jden...@redhat.com>
Date: Thu, 14 Jul 2011 21:00:52 -0400
Subject: [PATCH 29/29] Remove sudorule_mod, ticket 1307
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
sudorule_mod was ill-conceived, it does not respect the logic
surrounding external users. Suggested to use sudorule_add and
sudorule_del for modification.
---
ipalib/plugins/sudorule.py | 9 ---------
tests/test_xmlrpc/test_sudorule_plugin.py | 15 ++-------------
2 files changed, 2 insertions(+), 22 deletions(-)
diff --git a/ipalib/plugins/sudorule.py b/ipalib/plugins/sudorule.py
index a1d05a8..349b16b 100644
--- a/ipalib/plugins/sudorule.py
+++ b/ipalib/plugins/sudorule.py
@@ -195,15 +195,6 @@ class sudorule_del(LDAPDelete):
api.register(sudorule_del)
-class sudorule_mod(LDAPUpdate):
- """
- Modify Sudo Rule.
- """
- msg_summary = _('Modified sudo rule "%(value)s"')
-
-api.register(sudorule_mod)
-
-
class sudorule_find(LDAPSearch):
"""
Search for Sudo Rule.
diff --git a/tests/test_xmlrpc/test_sudorule_plugin.py b/tests/test_xmlrpc/test_sudorule_plugin.py
index 88c608d..90d7950 100644
--- a/tests/test_xmlrpc/test_sudorule_plugin.py
+++ b/tests/test_xmlrpc/test_sudorule_plugin.py
@@ -32,7 +32,6 @@ class test_sudorule(XMLRPC_test):
rule_name = u'testing_sudorule1'
rule_command = u'/usr/bin/testsudocmd1'
rule_desc = u'description'
- rule_desc_mod = u'description modified'
test_user = u'sudorule_test_user'
test_external_user = u'external_test_user'
@@ -83,28 +82,18 @@ class test_sudorule(XMLRPC_test):
assert_attr_equal(entry, 'cn', self.rule_name)
assert_attr_equal(entry, 'description', self.rule_desc)
- def test_3_sudorule_mod(self):
- """
- Test modifying a Sudo rule using `xmlrpc.sudorule_mod`.
- """
- ret = api.Command['sudorule_mod'](
- self.rule_name, description=self.rule_desc_mod
- )
- entry = ret['result']
- assert_attr_equal(entry, 'description', self.rule_desc_mod)
-
def test_6_sudorule_find(self):
"""
Test searching for Sudo rules using `xmlrpc.sudorule_find`.
"""
ret = api.Command['sudorule_find'](
name=self.rule_name,
- description=self.rule_desc_mod
+ description=self.rule_desc
)
assert ret['truncated'] is False
entries = ret['result']
assert_attr_equal(entries[0], 'cn', self.rule_name)
- assert_attr_equal(entries[0], 'description', self.rule_desc_mod)
+ assert_attr_equal(entries[0], 'description', self.rule_desc)
def test_7_sudorule_init_testing_data(self):
"""
--
1.7.4.4
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
