Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-20 Thread Petr Viktorin
On 01/19/2016 04:52 PM, Jan Cholasta wrote: > On 19.1.2016 13:45, Petr Viktorin wrote: [...] >>> Otherwise LGTM, including patch 758. >> >> Attaching updated patches, with py3k check as as default squashed in. >> I also added a pylint exception for a new use of reload() in 0756. >> One more thing

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-20 Thread Jan Cholasta
On 20.1.2016 10:15, Petr Viktorin wrote: On 01/19/2016 04:52 PM, Jan Cholasta wrote: On 19.1.2016 13:45, Petr Viktorin wrote: [...] Otherwise LGTM, including patch 758. Attaching updated patches, with py3k check as as default squashed in. I also added a pylint exception for a new use of

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-19 Thread Jan Cholasta
On 19.1.2016 13:45, Petr Viktorin wrote: On 01/19/2016 08:45 AM, Jan Cholasta wrote: On 14.1.2016 18:29, Petr Viktorin wrote: On 01/12/2016 03:44 PM, Petr Viktorin wrote: Hello I tried --py3k option and it doesn't print any error, can we enable that check by default to prevent python3

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-18 Thread Jan Cholasta
On 14.1.2016 18:29, Petr Viktorin wrote: On 01/12/2016 03:44 PM, Petr Viktorin wrote: Hello I tried --py3k option and it doesn't print any error, can we enable that check by default to prevent python3 regressions? # ./make-lint --py3k No config file found, using default configuration

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-14 Thread Petr Viktorin
On 01/12/2016 03:44 PM, Petr Viktorin wrote: > >>> Hello I tried --py3k option and it doesn't print any error, can we >>> enable that check by default to prevent python3 regressions? >>> >>> # ./make-lint --py3k >>> No config file found, using default configuration >> >> Squash in the other

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-12 Thread Petr Viktorin
On 01/11/2016 02:49 PM, Martin Basti wrote: > > > On 08.01.2016 12:45, Petr Viktorin wrote: >> On 01/06/2016 03:28 PM, Petr Viktorin wrote: >>> Hello, >>> >>> Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except >>> "no-absolute-import" (which seems redundant to me) and the ones

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-12 Thread Petr Viktorin
>> Hello I tried --py3k option and it doesn't print any error, can we >> enable that check by default to prevent python3 regressions? >> >> # ./make-lint --py3k >> No config file found, using default configuration > > Squash in the other attached patch to enable it by default. Sorry, please

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-11 Thread Martin Basti
On 08.01.2016 12:45, Petr Viktorin wrote: On 01/06/2016 03:28 PM, Petr Viktorin wrote: Hello, Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except "no-absolute-import" (which seems redundant to me) and the ones in contrib/RHEL4. The last patch adds py3k lint check to

Re: [Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

2016-01-08 Thread Petr Viktorin
On 01/06/2016 03:28 PM, Petr Viktorin wrote: > Hello, > > Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except > "no-absolute-import" (which seems redundant to me) and the ones in > contrib/RHEL4. > The last patch adds py3k lint check to make-lint. It's a bit > cumbersome,