Re: [Freeipa-devel] [PATCHES 0002-0008] [RFE] Implement iCal based time managment in HBAC

2015-10-14 Thread Martin Basti
I just read the code did not testing, maybe I will read design tomorrow. I found a few minor issues 0) You use too much brackets in code, it looks more like C than python: if not(elem): --> if not elem if(len(elempair) > 2) --> if len(elempair) > 2: return(something) --> return something 1) +d

[Freeipa-devel] [PATCHES 0002-0008] [RFE] Implement iCal based time managment in HBAC

2015-10-07 Thread Stanislav Laznicka
Hi, The moment's here, I'd like to share my code with you now. Let me comment on some additions from my last post here in August. The methods for testing HBAC rules in hbactest module were modified so that a time zone can now also be picked in case there are some rules with the "host" time z