Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-04-20 Thread Jan Cholasta
Dne 20.4.2015 v 10:06 Martin Babinsky napsal(a): On 04/20/2015 09:48 AM, Jan Cholasta wrote: Dne 15.4.2015 v 15:17 Martin Babinsky napsal(a): On 04/13/2015 02:16 PM, Martin Babinsky wrote: On 04/09/2015 03:38 PM, Jan Cholasta wrote: Some comments: Patch 15: 1) The functions should be as s

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-04-20 Thread Martin Babinsky
On 04/20/2015 09:48 AM, Jan Cholasta wrote: Dne 15.4.2015 v 15:17 Martin Babinsky napsal(a): On 04/13/2015 02:16 PM, Martin Babinsky wrote: On 04/09/2015 03:38 PM, Jan Cholasta wrote: Some comments: Patch 15: 1) The functions should be as similar as possible: a) kinit_password() shou

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-04-20 Thread Jan Cholasta
Dne 15.4.2015 v 15:17 Martin Babinsky napsal(a): On 04/13/2015 02:16 PM, Martin Babinsky wrote: On 04/09/2015 03:38 PM, Jan Cholasta wrote: Some comments: Patch 15: 1) The functions should be as similar as possible: a) kinit_password() should have a 'ccache_path' argument instead of p

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-04-15 Thread Martin Babinsky
On 04/13/2015 02:16 PM, Martin Babinsky wrote: On 04/09/2015 03:38 PM, Jan Cholasta wrote: Some comments: Patch 15: 1) The functions should be as similar as possible: a) kinit_password() should have a 'ccache_path' argument instead of passing the path in KRB5CCNAME in the 'env' argumen

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-04-13 Thread Martin Babinsky
On 04/09/2015 03:38 PM, Jan Cholasta wrote: Some comments: Patch 15: 1) The functions should be as similar as possible: a) kinit_password() should have a 'ccache_path' argument instead of passing the path in KRB5CCNAME in the 'env' argument. b) I don't think kinit_password() shoul

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-04-09 Thread Simo Sorce
On Thu, 2015-04-09 at 15:38 +0200, Jan Cholasta wrote: > Dne 9.4.2015 v 14:41 Simo Sorce napsal(a): > > On Wed, 2015-03-25 at 11:52 +0100, Martin Babinsky wrote: > >> On 03/23/2015 03:13 PM, Simo Sorce wrote: > >>> On Mon, 2015-03-23 at 14:22 +0100, Petr Spacek wrote: > On 23.3.2015 14:08, Sim

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-04-09 Thread Jan Cholasta
Dne 9.4.2015 v 14:41 Simo Sorce napsal(a): On Wed, 2015-03-25 at 11:52 +0100, Martin Babinsky wrote: On 03/23/2015 03:13 PM, Simo Sorce wrote: On Mon, 2015-03-23 at 14:22 +0100, Petr Spacek wrote: On 23.3.2015 14:08, Simo Sorce wrote: On Mon, 2015-03-23 at 12:48 +0100, Martin Babinsky wrote:

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-04-09 Thread Simo Sorce
On Wed, 2015-03-25 at 11:52 +0100, Martin Babinsky wrote: > On 03/23/2015 03:13 PM, Simo Sorce wrote: > > On Mon, 2015-03-23 at 14:22 +0100, Petr Spacek wrote: > >> On 23.3.2015 14:08, Simo Sorce wrote: > >>> On Mon, 2015-03-23 at 12:48 +0100, Martin Babinsky wrote: > On 03/17/2015 06:00 PM, S

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-25 Thread Martin Babinsky
On 03/23/2015 03:13 PM, Simo Sorce wrote: On Mon, 2015-03-23 at 14:22 +0100, Petr Spacek wrote: On 23.3.2015 14:08, Simo Sorce wrote: On Mon, 2015-03-23 at 12:48 +0100, Martin Babinsky wrote: On 03/17/2015 06:00 PM, Simo Sorce wrote: On Mon, 2015-03-16 at 13:30 +0100, Martin Babinsky wrote:

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-23 Thread Simo Sorce
On Mon, 2015-03-23 at 14:22 +0100, Petr Spacek wrote: > On 23.3.2015 14:08, Simo Sorce wrote: > > On Mon, 2015-03-23 at 12:48 +0100, Martin Babinsky wrote: > >> On 03/17/2015 06:00 PM, Simo Sorce wrote: > >>> On Mon, 2015-03-16 at 13:30 +0100, Martin Babinsky wrote: > On 03/16/2015 12:15 PM, M

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-23 Thread Petr Spacek
On 23.3.2015 14:08, Simo Sorce wrote: > On Mon, 2015-03-23 at 12:48 +0100, Martin Babinsky wrote: >> On 03/17/2015 06:00 PM, Simo Sorce wrote: >>> On Mon, 2015-03-16 at 13:30 +0100, Martin Babinsky wrote: On 03/16/2015 12:15 PM, Martin Kosek wrote: > On 03/13/2015 05:37 PM, Martin Babinsky

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-23 Thread Simo Sorce
On Mon, 2015-03-23 at 12:48 +0100, Martin Babinsky wrote: > On 03/17/2015 06:00 PM, Simo Sorce wrote: > > On Mon, 2015-03-16 at 13:30 +0100, Martin Babinsky wrote: > >> On 03/16/2015 12:15 PM, Martin Kosek wrote: > >>> On 03/13/2015 05:37 PM, Martin Babinsky wrote: > Attaching the next iterati

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-23 Thread Martin Babinsky
On 03/17/2015 06:00 PM, Simo Sorce wrote: On Mon, 2015-03-16 at 13:30 +0100, Martin Babinsky wrote: On 03/16/2015 12:15 PM, Martin Kosek wrote: On 03/13/2015 05:37 PM, Martin Babinsky wrote: Attaching the next iteration of patches. I have tried my best to reword the ipa-client-install man pag

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-17 Thread Simo Sorce
On Mon, 2015-03-16 at 13:30 +0100, Martin Babinsky wrote: > On 03/16/2015 12:15 PM, Martin Kosek wrote: > > On 03/13/2015 05:37 PM, Martin Babinsky wrote: > >> Attaching the next iteration of patches. > >> > >> I have tried my best to reword the ipa-client-install man page bit about > >> the > >>

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-17 Thread Martin Babinsky
On 03/17/2015 12:09 PM, Petr Spacek wrote: On 16.3.2015 17:20, Martin Babinsky wrote: On 03/16/2015 01:35 PM, Jan Cholasta wrote: Dne 16.3.2015 v 13:30 Martin Babinsky napsal(a): On 03/16/2015 12:15 PM, Martin Kosek wrote: On 03/13/2015 05:37 PM, Martin Babinsky wrote: Attaching the next ite

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-17 Thread Petr Spacek
On 16.3.2015 17:20, Martin Babinsky wrote: > On 03/16/2015 01:35 PM, Jan Cholasta wrote: >> Dne 16.3.2015 v 13:30 Martin Babinsky napsal(a): >>> On 03/16/2015 12:15 PM, Martin Kosek wrote: On 03/13/2015 05:37 PM, Martin Babinsky wrote: > Attaching the next iteration of patches. Very good!

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-16 Thread Martin Babinsky
On 03/16/2015 01:35 PM, Jan Cholasta wrote: Dne 16.3.2015 v 13:30 Martin Babinsky napsal(a): On 03/16/2015 12:15 PM, Martin Kosek wrote: On 03/13/2015 05:37 PM, Martin Babinsky wrote: Attaching the next iteration of patches. I have tried my best to reword the ipa-client-install man page bit a

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-16 Thread Jan Cholasta
Dne 16.3.2015 v 13:30 Martin Babinsky napsal(a): On 03/16/2015 12:15 PM, Martin Kosek wrote: On 03/13/2015 05:37 PM, Martin Babinsky wrote: Attaching the next iteration of patches. I have tried my best to reword the ipa-client-install man page bit about the new option. Any suggestions to furth

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-16 Thread Martin Babinsky
On 03/16/2015 12:15 PM, Martin Kosek wrote: On 03/13/2015 05:37 PM, Martin Babinsky wrote: Attaching the next iteration of patches. I have tried my best to reword the ipa-client-install man page bit about the new option. Any suggestions to further improve it are welcome. I have also slightly m

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-16 Thread Martin Kosek
On 03/13/2015 05:37 PM, Martin Babinsky wrote: > Attaching the next iteration of patches. > > I have tried my best to reword the ipa-client-install man page bit about the > new option. Any suggestions to further improve it are welcome. > > I have also slightly modified the 'kinit_keytab' function

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-13 Thread Martin Babinsky
Attaching the next iteration of patches. I have tried my best to reword the ipa-client-install man page bit about the new option. Any suggestions to further improve it are welcome. I have also slightly modified the 'kinit_keytab' function so that in Kerberos errors are reported for each attem

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-13 Thread Simo Sorce
On Wed, 2015-03-11 at 12:42 +0100, Petr Spacek wrote: > I would like to see new code compatible with Python 3. Here I'm not > sure what is the generic solution for xrange but in this particular > case I would recommend you to use just range. Attempts variable should > have small values so the x/ran

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-13 Thread Martin Babinsky
On 03/11/2015 12:42 PM, Petr Spacek wrote: diff --git a/ipaserver/rpcserver.py b/ipaserver/rpcserver.py index d6bc955b9d9910a24eec5df1def579310eb54786..36f16908ac8477d9982bfee613b77576853054eb 100644 --- a/ipaserver/rpcserver.py +++ b/ipaserver/rpcserver.py @@ -958,8 +958,8 @@ class login_passw

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-11 Thread Martin Babinsky
On 03/11/2015 03:53 PM, Petr Spacek wrote: On 11.3.2015 14:27, Martin Babinsky wrote: Actually, now that I think about it, I will try to address some of your comments: +except krbV.Krb5Error, e: except ... , ... syntax is not going to work in Python 3. Maybe 'as' would be better?

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-11 Thread Petr Spacek
On 11.3.2015 14:27, Martin Babinsky wrote: > Actually, now that I think about it, I will try to address some of your > comments: >>> +except krbV.Krb5Error, e: >> except ... , ... syntax is not going to work in Python 3. Maybe 'as' would be >> better? >> > AFAIK except ... as ... syntax w

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-11 Thread Martin Babinsky
Actually, now that I think about it, I will try to address some of your comments: On 03/11/2015 12:42 PM, Petr Spacek wrote: Hello Martin^3, good work, we are almost there! Please see my nitpicks in-line. On 9.3.2015 13:06, Martin Babinsky wrote: On 03/06/2015 01:05 PM, Martin Babinsky wrote

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-11 Thread Martin Babinsky
On 03/11/2015 12:42 PM, Petr Spacek wrote: Hello Martin^3, good work, we are almost there! Please see my nitpicks in-line. On 9.3.2015 13:06, Martin Babinsky wrote: On 03/06/2015 01:05 PM, Martin Babinsky wrote: This series of patches for the master/4.1 branch attempts to implement some of th

Re: [Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-11 Thread Petr Spacek
Hello Martin^3, good work, we are almost there! Please see my nitpicks in-line. On 9.3.2015 13:06, Martin Babinsky wrote: > On 03/06/2015 01:05 PM, Martin Babinsky wrote: >> This series of patches for the master/4.1 branch attempts to implement >> some of the Rob's and Petr Vobornik's ideas which

[Freeipa-devel] [PATCHES 0015-0017] consolidation of various Kerberos auth methods in FreeIPA code

2015-03-09 Thread Martin Babinsky
On 03/06/2015 01:05 PM, Martin Babinsky wrote: This series of patches for the master/4.1 branch attempts to implement some of the Rob's and Petr Vobornik's ideas which originated from a discussion on this list regarding my original patch fixing https://fedorahosted.org/freeipa/ticket/4808. I sup