URL: https://github.com/freeipa/freeipa/pull/184
Title: #184: Minor install script fixes
martbab commented:
"""
Reverted the Fix install scripts debugging commit.
master:
* dc873007f8616ab9e77f903e235ba49f45ecde37 Revert "Fix install scripts
debugging"
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/184
Title: #184: Minor install script fixes
abbra commented:
"""
I'm fine with that (revert --debug commit). Either alternative (make
Configurable be aware of the debug or do a refactoring of an installer) is
roughly going into the same direction.
URL: https://github.com/freeipa/freeipa/pull/184
Title: #184: Minor install script fixes
martbab commented:
"""
Note that the installer class has no access to debug options. These are only
used in the containing ConfigureTool class to set up loggers (see
URL: https://github.com/freeipa/freeipa/pull/184
Title: #184: Minor install script fixes
pvoborni commented:
"""
The debug patch breaks test installation on RHEL. Following exception is
printed only if install.py is adjusted to print exception on line
```
ipa : ERRORdebug
On ma, 24 loka 2016, Simo Sorce wrote:
On Mon, 2016-10-24 at 17:38 +0200, abbra wrote:
URL: https://github.com/freeipa/freeipa/pull/184
Title: #184: Minor install script fixes
abbra commented:
"""
ACK from my side if you would split the commit into two small ones, please.
Note that CI
On Mon, 2016-10-24 at 17:38 +0200, abbra wrote:
> URL: https://github.com/freeipa/freeipa/pull/184
> Title: #184: Minor install script fixes
>
> abbra commented:
> """
> ACK from my side if you would split the commit into two small ones, please.
>
> Note that CI integration is currently broken
URL: https://github.com/freeipa/freeipa/pull/184
Title: #184: Minor install script fixes
abbra commented:
"""
ACK from my side if you would split the commit into two small ones, please.
Note that CI integration is currently broken so travis says your commits failed
the checks.
"""
See the
