mbasti-rh commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/afea9616318fbbffc2c296b7c41890db8595e3cc
https://fedorahosted.org/freeipa/changeset/dce95a14595a37ce83bcf3e28f41feab715d0c81
mbasti-rh commented on a pull request
"""
IMO api version should be incremented, otherwise works for me
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/34#issuecomment-244784027
--
Manage your subscription for the Freeipa-devel mailing list:
mbasti-rh commented on a pull request
"""
Fix works for me partially, it fixes issues reported in ticket. Do you want to
open new ticket for this or should it be part of this ticket?
Expected:
```
[root@vm-058-080 ~]# ipa dnsrecord-add test. rec
Please choose a type of DNS resource record to be
jcholast commented on a pull request
"""
I have decided to instead copy & paste the code, as it exists solely for the
purpose of supporting old servers, so it should not get any additional
improvements in the future.
"""
See the full comment at
mbasti-rh commented on a pull request
"""
Can we move DNS record classes to ipalib/dnsrecords.py and use it in both
client and server?
IMO for server side code it should work just fine, not sure about client.
"""
See the full comment at
jcholast commented on a pull request
"""
I'm afraid this can't be easily fixed due to the manner in which the dns plugin
is implemented.
I'm open to suggestions if you have any.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/34#issuecomment-243114929
--
Manage your
mbasti-rh commented on a pull request
"""
I really don't like to move definitions how to split params from classes to
single function
```
def split_rrparam(name, value):
```
It doesn't look safe for me or easy to understand and maintain. When I want to
add new DNS type, I have to check 3
