URL: https://github.com/freeipa/freeipa/pull/390
Author: pvomacka
Title: #390: WebUI: Fix Coverity JS bugs
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/390/head:pr390
git checkout pr390
From 8b35a9710d8476903f00c57e63b8f734a344235c Mon Sep 17 00:00:00 2001
From: Pavel Vomacka <pvoma...@redhat.com>
Date: Wed, 11 Jan 2017 17:13:19 +0100
Subject: [PATCH 1/2] Coverity: Fix possibility of access to attribute of
undefined
---
install/ui/src/freeipa/widgets/APIBrowserWidget.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/install/ui/src/freeipa/widgets/APIBrowserWidget.js b/install/ui/src/freeipa/widgets/APIBrowserWidget.js
index 2164df2..ff1c8ee 100644
--- a/install/ui/src/freeipa/widgets/APIBrowserWidget.js
+++ b/install/ui/src/freeipa/widgets/APIBrowserWidget.js
@@ -253,7 +253,7 @@ widgets.APIBrowserWidget = declare([Stateful, Evented], {
// switch widget
if (widget && !widget.el) widget.render();
- if (this.current_details_w !== widget) {
+ if (widget && this.current_details_w !== widget) {
this.details_el.empty();
this.details_el.append(widget.el);
}
From 9b07762989f53adeb6dbad92f61622946cf52509 Mon Sep 17 00:00:00 2001
From: Pavel Vomacka <pvoma...@redhat.com>
Date: Wed, 11 Jan 2017 17:14:01 +0100
Subject: [PATCH 2/2] Coverity: removed useless semicolon which ends statement
earlier
---
install/ui/src/freeipa/widgets/LoginScreen.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/install/ui/src/freeipa/widgets/LoginScreen.js b/install/ui/src/freeipa/widgets/LoginScreen.js
index 29a5efc..0096433 100644
--- a/install/ui/src/freeipa/widgets/LoginScreen.js
+++ b/install/ui/src/freeipa/widgets/LoginScreen.js
@@ -339,10 +339,10 @@ define(['dojo/_base/declare',
set_login_aside_text: function() {
var aside = "";
if (this.password_enabled()) {
- aside += "<p>"+this.form_auth_msg;+"<p/>";
+ aside += "<p>"+this.form_auth_msg+"<p/>";
}
if (this.kerberos_enabled()) {
- aside += "<p>"+this.kerberos_msg;+"<p/>";
+ aside += "<p>"+this.kerberos_msg+"<p/>";
}
this.set('aside', aside);
},
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
