URL: https://github.com/freeipa/freeipa/pull/451
Author: tomaskrizek
Title: #451: certdb: remove unused keysize property
Action: opened
PR body:
"""
Keysize property is no longer used anywhere in the code. It was
originally introduced for the request_cert function, which was later
refactored to use a function argument instead.
---
The value of this property caught my eye, because I don't think we should be
using 1024bit keys. Fortunately, I discovered this bit of code is obsolete and
we actually use 2048bit key length by default.
Commit that originally introduced the property:
158b4e8ff4704b967d4049e2a16f9b32fbb33b80
Commit that removed the usage of the property:
9182c10b03a7841c9318ad64ae6c5deda77d93d1
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/451/head:pr451
git checkout pr451
From 1de9bfd05dab3cc221b1f72241c71ccbd17ce4d8 Mon Sep 17 00:00:00 2001
From: Tomas Krizek <tkri...@redhat.com>
Date: Wed, 8 Feb 2017 18:28:25 +0100
Subject: [PATCH] certdb: remove unused keysize property
Keysize property is no longer used anywhere in the code. It was
originally introduced for the request_cert function, which was later
refactored to use a function argument instead.
---
ipaserver/install/certs.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/ipaserver/install/certs.py b/ipaserver/install/certs.py
index 80918d4..e6d0ce2 100644
--- a/ipaserver/install/certs.py
+++ b/ipaserver/install/certs.py
@@ -110,7 +110,6 @@ def __init__(
self.cacert_name = get_ca_nickname(self.realm)
self.valid_months = "120"
- self.keysize = "1024"
# We are going to set the owner of all of the cert
# files to the owner of the containing directory
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
