URL: https://github.com/freeipa/freeipa/pull/454 Author: martbab Title: #454: Move AD trust installation code to a separate module Action: opened
PR body: """ This facilitates calling the necessary checks and configuration code as a module from e.g. a composite installer. The code that checks for the admin credentials stays in the standalone installer as the code inside the adtrust module is expected to operate also without admin credentials. https://fedorahosted.org/freeipa/ticket/6629 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/454/head:pr454 git checkout pr454
From 9feed648b75fc239f713108d33c9a39f03036430 Mon Sep 17 00:00:00 2001 From: Martin Babinsky <mbabi...@redhat.com> Date: Wed, 8 Feb 2017 17:02:09 +0100 Subject: [PATCH] Move AD trust installation code to a separate module This facilitates calling the necessary checks and configuration code as a module from e.g. a composite installer. The code that checks for the admin credentials stays in the standalone installer as the code inside the adtrust module is expected to operate also without admin credentials. https://fedorahosted.org/freeipa/ticket/6629 --- install/tools/ipa-adtrust-install | 349 +---------------------------------- ipaserver/install/adtrust.py | 371 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 378 insertions(+), 342 deletions(-) create mode 100644 ipaserver/install/adtrust.py diff --git a/install/tools/ipa-adtrust-install b/install/tools/ipa-adtrust-install index b504c08..443c3c4 100755 --- a/install/tools/ipa-adtrust-install +++ b/install/tools/ipa-adtrust-install @@ -25,27 +25,24 @@ from __future__ import print_function import os import sys -import ldap import six from optparse import SUPPRESS_HELP # pylint: disable=deprecated-module from ipalib.install import sysrestore -from ipaserver.install import adtrustinstance +from ipaserver.install import adtrust from ipaserver.install.installutils import ( read_password, check_server_configuration, run_script) -from ipaserver.install import service from ipapython.admintool import ScriptError from ipapython import version -from ipapython import ipautil, ipaldap +from ipapython import ipautil from ipalib import api, errors, krb_utils from ipapython.config import IPAOptionParser from ipaplatform.paths import paths from ipapython.ipa_log_manager import root_logger, standard_logging_setup -from ipapython.dn import DN if six.PY3: unicode = str @@ -98,35 +95,6 @@ def parse_options(): return safe_options, options -def netbios_name_error(name): - print("\nIllegal NetBIOS name [%s].\n" % name) - print("Up to 15 characters and only uppercase ASCII letters, digits " - "and dashes are allowed. Empty string is not allowed.") - - -def read_netbios_name(netbios_default): - netbios_name = "" - - print("Enter the NetBIOS name for the IPA domain.") - print("Only up to 15 uppercase ASCII letters, digits " - "and dashes are allowed.") - print("Example: EXAMPLE.") - print("") - print("") - if not netbios_default: - netbios_default = "EXAMPLE" - while True: - netbios_name = ipautil.user_input( - "NetBIOS domain name", netbios_default, allow_empty=False) - print("") - if adtrustinstance.check_netbios_name(netbios_name): - break - - netbios_name_error(netbios_name) - - return netbios_name - - def read_admin_password(admin_name): print("Configuring cross-realm trusts for IPA server requires password " "for user '%s'." % (admin_name)) @@ -137,95 +105,6 @@ def read_admin_password(admin_name): return admin_password -def set_and_check_netbios_name(netbios_name, unattended): - """ - Depending if trust in already configured or not a given NetBIOS domain - name must be handled differently. - - If trust is not configured the given NetBIOS is used or the NetBIOS is - generated if none was given on the command line. - - If trust is already configured the given NetBIOS name is used to reset - the stored NetBIOS name it it differs from the current one. - """ - - flat_name_attr = 'ipantflatname' - cur_netbios_name = None - gen_netbios_name = None - reset_netbios_name = False - entry = None - - try: - entry = api.Backend.ldap2.get_entry( - DN(('cn', api.env.domain), api.env.container_cifsdomains, - ipautil.realm_to_suffix(api.env.realm)), - [flat_name_attr]) - except errors.NotFound: - # trust not configured - pass - else: - cur_netbios_name = entry.get(flat_name_attr)[0] - - if cur_netbios_name and not netbios_name: - # keep the current NetBIOS name - netbios_name = cur_netbios_name - reset_netbios_name = False - elif cur_netbios_name and cur_netbios_name != netbios_name: - # change the NetBIOS name - print("Current NetBIOS domain name is %s, new name is %s.\n" - % (cur_netbios_name, netbios_name)) - print("Please note that changing the NetBIOS name might " - "break existing trust relationships.") - if unattended: - reset_netbios_name = True - print("NetBIOS domain name will be changed to %s.\n" - % netbios_name) - else: - print("Say 'yes' if the NetBIOS shall be changed and " - "'no' if the old one shall be kept.") - reset_netbios_name = ipautil.user_input( - 'Do you want to reset the NetBIOS domain name?', - default=False, allow_empty=False) - if not reset_netbios_name: - netbios_name = cur_netbios_name - elif cur_netbios_name and cur_netbios_name == netbios_name: - # keep the current NetBIOS name - reset_netbios_name = False - elif not cur_netbios_name: - if not netbios_name: - gen_netbios_name = adtrustinstance.make_netbios_name( - api.env.domain) - - if entry is not None: - # Fix existing trust configuration - print("Trust is configured but no NetBIOS domain name found, " - "setting it now.") - reset_netbios_name = True - else: - # initial trust configuration - reset_netbios_name = False - else: - # all possible cases should be covered above - raise Exception('Unexpected state while checking NetBIOS domain name') - - if unattended and netbios_name is None and gen_netbios_name: - netbios_name = gen_netbios_name - - if not adtrustinstance.check_netbios_name(netbios_name): - if unattended: - netbios_name_error(netbios_name) - raise ScriptError("Aborting installation.") - else: - if netbios_name: - netbios_name_error(netbios_name) - netbios_name = None - - if not unattended and not netbios_name: - netbios_name = read_netbios_name(gen_netbios_name) - - return (netbios_name, reset_netbios_name) - - def ensure_admin_kinit(admin_name, admin_password): try: ipautil.run(['kinit', admin_name], stdin=admin_password+'\n') @@ -236,20 +115,6 @@ def ensure_admin_kinit(admin_name, admin_password): return True -def enable_compat_tree(): - print("Do you want to enable support for trusted domains in Schema " - "Compatibility plugin?") - print("This will allow clients older than SSSD 1.9 and non-Linux " - "clients to work with trusted users.") - print("") - enable_compat = ipautil.user_input( - "Enable trusted domains support in slapi-nis?", - default=False, - allow_empty=False) - print("") - return enable_compat - - def main(): safe_options, options = parse_options() @@ -286,8 +151,9 @@ def main(): print("") # Check if samba packages are installed - if not adtrustinstance.check_inst(): - raise ScriptError("Aborting installation.") + # the same check is in the adtrust module but we must fail first if the + # package is missing + adtrust.check_for_installed_deps() # Initialize the ipalib api api.bootstrap( @@ -298,46 +164,6 @@ def main(): ) api.finalize() - # If domain name and realm does not match, IPA server will not be able - # to estabilish trust with Active Directory. Print big fat warning. - - realm_not_matching_domain = (api.env.domain.upper() != api.env.realm) - - if realm_not_matching_domain: - print("WARNING: Realm name does not match the domain name.\n" - "You will not be able to estabilish trusts with Active " - "Directory unless\nthe realm name of the IPA server matches its " - "domain name.\n\n") - if not options.unattended: - if not ipautil.user_input("Do you wish to continue?", - default=False, - allow_empty=False): - raise ScriptError("Aborting installation.") - - # Check if /etc/samba/smb.conf already exists. In case it was not generated - # by IPA, print a warning that we will break existing configuration. - - if adtrustinstance.ipa_smb_conf_exists(): - if not options.unattended: - print("IPA generated smb.conf detected.") - if not ipautil.user_input("Overwrite smb.conf?", - default=False, - allow_empty=False): - raise ScriptError("Aborting installation.") - - elif os.path.exists(paths.SMB_CONF): - print("WARNING: The smb.conf already exists. Running " - "ipa-adtrust-install will break your existing samba " - "configuration.\n\n") - if not options.unattended: - if not ipautil.user_input("Do you wish to continue?", - default=False, - allow_empty=False): - raise ScriptError("Aborting installation.") - - if not options.unattended and not options.enable_compat: - options.enable_compat = enable_compat_tree() - admin_password = options.admin_password if not (options.unattended or admin_password): admin_password = read_admin_password(options.admin_name) @@ -381,169 +207,8 @@ def main(): raise ScriptError( "Unrecognized error during check of admin rights: %s" % e) - netbios_name, reset_netbios_name = set_and_check_netbios_name( - options.netbios_name, options.unattended) - - if not options.add_sids: - # The filter corresponds to ipa_sidgen_task.c LDAP search filter - filter = '(&(objectclass=ipaobject)(!(objectclass=mepmanagedentry))' \ - '(|(objectclass=posixaccount)(objectclass=posixgroup)' \ - '(objectclass=ipaidobject))(!(ipantsecurityidentifier=*)))' - base_dn = api.env.basedn - try: - root_logger.debug( - "Searching for objects with missing SID with " - "filter=%s, base_dn=%s", filter, base_dn) - entries, _truncated = api.Backend.ldap2.find_entries( - filter=filter, base_dn=base_dn, attrs_list=['']) - except errors.NotFound: - # All objects have SIDs assigned - pass - except (errors.DatabaseError, errors.NetworkError) as e: - print("Could not retrieve a list of objects that need a SID " - "identifier assigned:") - print(unicode(e)) - else: - object_count = len(entries) - if object_count > 0: - print("") - print("WARNING: %d existing users or groups do not have " - "a SID identifier assigned." % len(entries)) - print("Installer can run a task to have ipa-sidgen " - "Directory Server plugin generate") - print("the SID identifier for all these users. Please note, " - "the in case of a high") - print("number of users and groups, the operation might " - "lead to high replication") - print("traffic and performance degradation. Refer to " - "ipa-adtrust-install(1) man page") - print("for details.") - print("") - if options.unattended: - print("Unattended mode was selected, installer will " - "NOT run ipa-sidgen task!") - else: - if ipautil.user_input( - "Do you want to run the ipa-sidgen task?", - default=False, - allow_empty=False): - options.add_sids = True - - if not options.unattended: - print("") - print("The following operations may take some minutes to complete.") - print("Please wait until the prompt is returned.") - print("") - - smb = adtrustinstance.ADTRUSTInstance(fstore) - smb.realm = api.env.realm - smb.autobind = ipaldap.AUTOBIND_ENABLED - smb.setup(api.env.host, api.env.realm, - netbios_name, reset_netbios_name, - options.rid_base, options.secondary_rid_base, - options.add_sids, - enable_compat=options.enable_compat) - smb.find_local_id_range() - smb.create_instance() - - if options.add_agents: - # Find out IPA masters which are not part of the cn=adtrust agents - # and propose them to be added to the list - base_dn = api.env.basedn - masters_dn = DN( - ('cn', 'masters'), ('cn', 'ipa'), ('cn', 'etc'), base_dn) - agents_dn = DN( - ('cn', 'adtrust agents'), ('cn', 'sysaccounts'), - ('cn', 'etc'), base_dn) - new_agents = [] - entries_m = [] - entries_a = [] - try: - # Search only masters which have support for domain levels - # because only these masters will have SSSD recent enough - # to support AD trust agents - entries_m, _truncated = api.Backend.ldap2.find_entries( - filter=("(&(objectclass=ipaSupportedDomainLevelConfig)" - "(ipaMaxDomainLevel=*)(ipaMinDomainLevel=*))"), - base_dn=masters_dn, attrs_list=['cn'], - scope=ldap.SCOPE_ONELEVEL) - except errors.NotFound: - pass - except (errors.DatabaseError, errors.NetworkError) as e: - print("Could not retrieve a list of existing IPA masters:") - print(unicode(e)) - - try: - entries_a, _truncated = api.Backend.ldap2.find_entries( - filter="", base_dn=agents_dn, attrs_list=['member'], - scope=ldap.SCOPE_BASE) - except errors.NotFound: - pass - except (errors.DatabaseError, errors.NetworkError) as e: - print("Could not retrieve a list of adtrust agents:") - print(unicode(e)) - - if len(entries_m) > 0: - existing_masters = [x['cn'][0] for x in entries_m] - adtrust_agents = entries_a[0]['member'] - potential_agents = [] - for m in existing_masters: - mdn = DN(('fqdn', m), api.env.container_host, api.env.basedn) - found = False - for a in adtrust_agents: - if mdn == a: - found = True - break - if not found: - potential_agents += [[m, mdn]] - - object_count = len(potential_agents) - if object_count > 0: - print("") - print("WARNING: %d IPA masters are not yet able to serve " - "information about users from trusted forests." - % (object_count)) - print("Installer can add them to the list of IPA masters " - "allowed to access information about trusts.") - print("If you choose to do so, you also need to restart " - "LDAP service on those masters.") - print("Refer to ipa-adtrust-install(1) man page for details.") - print("") - if options.unattended: - print("Unattended mode was selected, installer will NOT " - "add other IPA masters to the list of allowed to") - print("access information about trusted forests!") - else: - print( - "Do you want to allow following IPA masters to " - "serve information about users from trusted forests?") - for (name, dn) in potential_agents: - if name == api.env.host: - # Don't add this host here - # it shouldn't be here as it was added by the - # adtrustinstance setup code - continue - if ipautil.user_input( - "IPA master [%s]?" % (name), - default=False, - allow_empty=False): - new_agents += [[name, dn]] - - if len(new_agents) > 0: - # Add the CIFS and host principals to the 'adtrust agents' - # group as 389-ds only operates with GroupOfNames, we have to - # use the principal's proper dn as defined in self.cifs_agent - service.add_principals_to_group( - api.Backend.ldap2, - agents_dn, - "member", - [x[1] for x in new_agents]) - print(""" -WARNING: you MUST restart (e.g. ipactl restart) the following IPA masters in -order to activate them to serve information about users from trusted forests: -""") - for x in new_agents: - print(x[0]) + adtrust.install_check(True, options, api) + adtrust.install(options, fstore, api) print(""" ============================================================================= diff --git a/ipaserver/install/adtrust.py b/ipaserver/install/adtrust.py new file mode 100644 index 0000000..6645679 --- /dev/null +++ b/ipaserver/install/adtrust.py @@ -0,0 +1,371 @@ +# +# Copyright (C) 2017 FreeIPA Contributors see COPYING for license +# + +""" +AD trust installer module +""" + +from __future__ import print_function + +import os +import ldap + +import six + +from ipalib import errors +from ipaplatform.paths import paths +from ipapython.admintool import ScriptError +from ipapython import ipaldap, ipautil +from ipapython.dn import DN +from ipapython.ipa_log_manager import root_logger +from ipaserver.install import adtrustinstance +from ipaserver.install import service + + +if six.PY3: + unicode = str + +netbios_name = None +reset_netbios_name = False + + +def netbios_name_error(name): + print("\nIllegal NetBIOS name [%s].\n" % name) + print("Up to 15 characters and only uppercase ASCII letters, digits " + "and dashes are allowed. Empty string is not allowed.") + + +def read_netbios_name(netbios_default): + netbios_name = "" + + print("Enter the NetBIOS name for the IPA domain.") + print("Only up to 15 uppercase ASCII letters, digits " + "and dashes are allowed.") + print("Example: EXAMPLE.") + print("") + print("") + if not netbios_default: + netbios_default = "EXAMPLE" + while True: + netbios_name = ipautil.user_input( + "NetBIOS domain name", netbios_default, allow_empty=False) + print("") + if adtrustinstance.check_netbios_name(netbios_name): + break + + netbios_name_error(netbios_name) + + return netbios_name + + +def set_and_check_netbios_name(netbios_name, unattended, api): + """ + Depending if trust in already configured or not a given NetBIOS domain + name must be handled differently. + + If trust is not configured the given NetBIOS is used or the NetBIOS is + generated if none was given on the command line. + + If trust is already configured the given NetBIOS name is used to reset + the stored NetBIOS name it it differs from the current one. + """ + + flat_name_attr = 'ipantflatname' + cur_netbios_name = None + gen_netbios_name = None + reset_netbios_name = False + entry = None + + try: + entry = api.Backend.ldap2.get_entry( + DN(('cn', api.env.domain), api.env.container_cifsdomains, + ipautil.realm_to_suffix(api.env.realm)), + [flat_name_attr]) + except errors.NotFound: + # trust not configured + pass + else: + cur_netbios_name = entry.get(flat_name_attr)[0] + + if cur_netbios_name and not netbios_name: + # keep the current NetBIOS name + netbios_name = cur_netbios_name + reset_netbios_name = False + elif cur_netbios_name and cur_netbios_name != netbios_name: + # change the NetBIOS name + print("Current NetBIOS domain name is %s, new name is %s.\n" + % (cur_netbios_name, netbios_name)) + print("Please note that changing the NetBIOS name might " + "break existing trust relationships.") + if unattended: + reset_netbios_name = True + print("NetBIOS domain name will be changed to %s.\n" + % netbios_name) + else: + print("Say 'yes' if the NetBIOS shall be changed and " + "'no' if the old one shall be kept.") + reset_netbios_name = ipautil.user_input( + 'Do you want to reset the NetBIOS domain name?', + default=False, allow_empty=False) + if not reset_netbios_name: + netbios_name = cur_netbios_name + elif cur_netbios_name and cur_netbios_name == netbios_name: + # keep the current NetBIOS name + reset_netbios_name = False + elif not cur_netbios_name: + if not netbios_name: + gen_netbios_name = adtrustinstance.make_netbios_name( + api.env.domain) + + if entry is not None: + # Fix existing trust configuration + print("Trust is configured but no NetBIOS domain name found, " + "setting it now.") + reset_netbios_name = True + else: + # initial trust configuration + reset_netbios_name = False + else: + # all possible cases should be covered above + raise Exception('Unexpected state while checking NetBIOS domain name') + + if unattended and netbios_name is None and gen_netbios_name: + netbios_name = gen_netbios_name + + if not adtrustinstance.check_netbios_name(netbios_name): + if unattended: + netbios_name_error(netbios_name) + raise ScriptError("Aborting installation.") + else: + if netbios_name: + netbios_name_error(netbios_name) + netbios_name = None + + if not unattended and not netbios_name: + netbios_name = read_netbios_name(gen_netbios_name) + + return (netbios_name, reset_netbios_name) + + +def enable_compat_tree(): + print("Do you want to enable support for trusted domains in Schema " + "Compatibility plugin?") + print("This will allow clients older than SSSD 1.9 and non-Linux " + "clients to work with trusted users.") + print("") + enable_compat = ipautil.user_input( + "Enable trusted domains support in slapi-nis?", + default=False, + allow_empty=False) + print("") + return enable_compat + + +def check_for_installed_deps(): + # Check if samba packages are installed + if not adtrustinstance.check_inst(): + raise ScriptError("Aborting installation.") + + +def install_check(standalone, options, api): + global netbios_name + global reset_netbios_name + + if standalone: + check_for_installed_deps() + + realm_not_matching_domain = (api.env.domain.upper() != api.env.realm) + + if realm_not_matching_domain: + print("WARNING: Realm name does not match the domain name.\n" + "You will not be able to estabilish trusts with Active " + "Directory unless\nthe realm name of the IPA server matches its " + "domain name.\n\n") + if not options.unattended: + if not ipautil.user_input("Do you wish to continue?", + default=False, + allow_empty=False): + raise ScriptError("Aborting installation.") + + elif os.path.exists(paths.SMB_CONF): + print("WARNING: The smb.conf already exists. Running " + "ipa-adtrust-install will break your existing samba " + "configuration.\n\n") + if not options.unattended: + if not ipautil.user_input("Do you wish to continue?", + default=False, + allow_empty=False): + raise ScriptError("Aborting installation.") + elif os.path.exists(paths.SMB_CONF): + print("WARNING: The smb.conf already exists. Running " + "ipa-adtrust-install will break your existing samba " + "configuration.\n\n") + if not options.unattended: + if not ipautil.user_input("Do you wish to continue?", + default=False, + allow_empty=False): + raise ScriptError("Aborting installation.") + + if not options.unattended and not options.enable_compat: + options.enable_compat = enable_compat_tree() + + netbios_name, reset_netbios_name = set_and_check_netbios_name( + options.netbios_name, options.unattended, api) + + if not options.add_sids: + # The filter corresponds to ipa_sidgen_task.c LDAP search filter + filter = '(&(objectclass=ipaobject)(!(objectclass=mepmanagedentry))' \ + '(|(objectclass=posixaccount)(objectclass=posixgroup)' \ + '(objectclass=ipaidobject))(!(ipantsecurityidentifier=*)))' + base_dn = api.env.basedn + try: + root_logger.debug( + "Searching for objects with missing SID with " + "filter=%s, base_dn=%s", filter, base_dn) + entries, _truncated = api.Backend.ldap2.find_entries( + filter=filter, base_dn=base_dn, attrs_list=['']) + except errors.NotFound: + # All objects have SIDs assigned + pass + except (errors.DatabaseError, errors.NetworkError) as e: + print("Could not retrieve a list of objects that need a SID " + "identifier assigned:") + print(unicode(e)) + else: + object_count = len(entries) + if object_count > 0: + print("") + print("WARNING: %d existing users or groups do not have " + "a SID identifier assigned." % len(entries)) + print("Installer can run a task to have ipa-sidgen " + "Directory Server plugin generate") + print("the SID identifier for all these users. Please note, " + "the in case of a high") + print("number of users and groups, the operation might " + "lead to high replication") + print("traffic and performance degradation. Refer to " + "ipa-adtrust-install(1) man page") + print("for details.") + print("") + if options.unattended: + print("Unattended mode was selected, installer will " + "NOT run ipa-sidgen task!") + else: + if ipautil.user_input( + "Do you want to run the ipa-sidgen task?", + default=False, + allow_empty=False): + options.add_sids = True + + if not options.unattended: + print("") + print("The following operations may take some minutes to complete.") + print("Please wait until the prompt is returned.") + print("") + + +def install(options, fstore, api): + smb = adtrustinstance.ADTRUSTInstance(fstore) + smb.realm = api.env.realm + smb.autobind = ipaldap.AUTOBIND_ENABLED + smb.setup(api.env.host, api.env.realm, + netbios_name, reset_netbios_name, + options.rid_base, options.secondary_rid_base, + options.add_sids, + enable_compat=options.enable_compat) + smb.find_local_id_range() + smb.create_instance() + + if options.add_agents: + # Find out IPA masters which are not part of the cn=adtrust agents + # and propose them to be added to the list + base_dn = api.env.basedn + masters_dn = DN( + ('cn', 'masters'), ('cn', 'ipa'), ('cn', 'etc'), base_dn) + agents_dn = DN( + ('cn', 'adtrust agents'), ('cn', 'sysaccounts'), + ('cn', 'etc'), base_dn) + new_agents = [] + entries_m = [] + entries_a = [] + try: + # Search only masters which have support for domain levels + # because only these masters will have SSSD recent enough + # to support AD trust agents + entries_m, _truncated = api.Backend.ldap2.find_entries( + filter=("(&(objectclass=ipaSupportedDomainLevelConfig)" + "(ipaMaxDomainLevel=*)(ipaMinDomainLevel=*))"), + base_dn=masters_dn, attrs_list=['cn'], + scope=ldap.SCOPE_ONELEVEL) + except errors.NotFound: + pass + except (errors.DatabaseError, errors.NetworkError) as e: + print("Could not retrieve a list of existing IPA masters:") + print(unicode(e)) + + try: + entries_a, _truncated = api.Backend.ldap2.find_entries( + filter="", base_dn=agents_dn, attrs_list=['member'], + scope=ldap.SCOPE_BASE) + except errors.NotFound: + pass + except (errors.DatabaseError, errors.NetworkError) as e: + print("Could not retrieve a list of adtrust agents:") + print(unicode(e)) + + if len(entries_m) > 0: + existing_masters = [x['cn'][0] for x in entries_m] + adtrust_agents = entries_a[0]['member'] + potential_agents = [] + for m in existing_masters: + mdn = DN(('fqdn', m), api.env.container_host, api.env.basedn) + found = False + for a in adtrust_agents: + if mdn == a: + found = True + break + if not found: + potential_agents += [[m, mdn]] + + object_count = len(potential_agents) + if object_count > 0: + print("") + print("WARNING: %d IPA masters are not yet able to serve " + "information about users from trusted forests." + % (object_count)) + print("Installer can add them to the list of IPA masters " + "allowed to access information about trusts.") + print("If you choose to do so, you also need to restart " + "LDAP service on those masters.") + print("Refer to ipa-adtrust-install(1) man page for details.") + print("") + if options.unattended: + print("Unattended mode was selected, installer will NOT " + "add other IPA masters to the list of allowed to") + print("access information about trusted forests!") + else: + print( + "Do you want to allow following IPA masters to " + "serve information about users from trusted forests?") + for (name, dn) in potential_agents: + if name == api.env.host: + # Don't add this host here + # it shouldn't be here as it was added by the + # adtrustinstance setup code + continue + if ipautil.user_input( + "IPA master [%s]?" % (name), + default=False, + allow_empty=False): + new_agents += [[name, dn]] + + if len(new_agents) > 0: + # Add the CIFS and host principals to the 'adtrust agents' + # group as 389-ds only operates with GroupOfNames, we have to + # use the principal's proper dn as defined in self.cifs_agent + service.add_principals_to_group( + api.Backend.ldap2, + agents_dn, + "member", + [x[1] for x in new_agents])
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
