[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ master: * 2e784336b0fe99baa47cf3e024f744ed56dc12ec Packaging: Add placeholder packages * e2b9ea2fd58b98edbb8d6aec97aadeea7cf11dcb Add python-wheel as build requirement * acdd1f59782bb836d6c4c255689918368adb8dab Add placeholders for ipaplatform, ipaserver and ipatests * b4c1bf1c7d1a63e802abe6334bd1112d2d468513 Add with_wheels global to install wheel and PyPI packaging dependencies * ab9f42d6eeefeaca2e4a5a9acfbb07b428be4616 Python build: use --build-base everywhere * 60cfacc54167b7b94b63874ade62740d980e3746 pylint: ignore pypi placeholders * bc1f60b3ba74032cb0895e154e02971aa380a6b3 Default to pkginstall=true without duplicated definitions """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-283656502 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ Commit 1f8326aa fixes an issue in ```Makefile.python.am```. I think the issue caused ```ipaplatform``` and ```pypi/ipaplatform``` to cross streams. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281989060 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ The old pylint issue is back ``` * Module ipaserver.install.installutils ipaserver/install/installutils.py:1209: [E1101(no-member), store_version] Module 'ipaplatform' has no 'NAME' member) ipaserver/install/installutils.py:1221: [E1101(no-member), check_version] Module 'ipaplatform' has no 'NAME' member) ipaserver/install/installutils.py:1224: [E1101(no-member), check_version] Module 'ipaplatform' has no 'NAME' member) ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281970741 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ @MartinBasti I dropped the last commit. make check no longer checks wheel packages. I'm going to open a new ticket for @martbab and ask him to add to add a proper test for wheel building to his awesome container magic. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281946900 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ @tiran I thought we agreed on having `with_wheels` in specfile and install dependencies only when you want to build wheel packages, what is not the case of RHEL. So what is the issue with python-wheel? My only concern it to not run wheel build in make check """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281943814 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages lslebodn commented: """ NACK for downstream patch. The intentin of build system refactoring was make packaging in downstream simpler. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281935052 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages lslebodn commented: """ NACK for downstream patch. The intentin of build system refactoring was make packaging in downstream simpler. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281935052 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages pvoborni commented: """ Some distros like RHEL doesn't have python-wheel packaged. It can be disabled by downstream patch, but better would be to remove it or make it configurable. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281934554 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages lslebodn commented: """ FYI: At the moment, `make check` run just C-based unit test and all of them are optional. If required dependency is not found at configure time then test is not build/executed. The reason is that required dependencies are not in some downstream distributions and IIRC python-wheel is not there either. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281933816 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ That's not the point here. We are arguing about a new build dependency (python-wheel). """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281930993 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages lslebodn commented: """ I agree with @MartinBasti it is not a unit test. IMHO better approach is to test it in CI/travis/... """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281929628 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ I'm open to suggestions here, but I like to have automatic validation of packaging. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281928143 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ Is really needed to have this is make check? It makes build dependencies of wheel mandratory not optional ``` error: invalid command 'bdist_wheel' make[5]: *** [bdist_wheel] Error 1 Makefile:591: recipe for target 'bdist_wheel' failed make[5]: Leaving directory '/freeipa/rpmbuild/BUILD/freeipa-4.4.90.dev201702221837+git07cd377/pypi/freeipa' Makefile:1192: recipe for target 'wheel_placeholder' failed make[4]: *** [wheel_placeholder] Error 1 make[4]: *** Waiting for unfinished jobs usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] or: setup.py --help [cmd1 cmd2 ...] or: setup.py --help-commands or: setup.py cmd --help ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281926018 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ Is really needed to have this is make check? It makes build dependencies of wheel mandratory not optional ``` error: invalid command 'bdist_wheel' make[5]: *** [bdist_wheel] Error 1 Makefile:591: recipe for target 'bdist_wheel' failed make[5]: Leaving directory '/freeipa/rpmbuild/BUILD/freeipa-4.4.90.dev201702221837+git07cd377/pypi/freeipa' Makefile:1192: recipe for target 'wheel_placeholder' failed make[4]: *** [wheel_placeholder] Error 1 make[4]: *** Waiting for unfinished jobs usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] or: setup.py --help [cmd1 cmd2 ...] or: setup.py --help-commands or: setup.py cmd --help ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281926018 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ @MartinBasti I have rebased the branch and added wheel + placeholder building to make check. The pylint violations have disappeared. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281759354 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ LGTM, please rebase and I will test it. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281749499 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ Thank you. I see errors reported by pylint ``` * Module ipaserver.install.installutils ipaserver/install/installutils.py:1209: [E1101(no-member), store_version] Module 'ipaplatform' has no 'NAME' member) ipaserver/install/installutils.py:1221: [E1101(no-member), check_version] Module 'ipaplatform' has no 'NAME' member) ipaserver/install/installutils.py:1224: [E1101(no-member), check_version] Module 'ipaplatform' has no 'NAME' member) ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281614386 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ You requsted a dependency in the first place :) If you are going to add a special build or dependency flavor for PyPI packaging, please also add ```python[23]-twine```. It's the uploader tool we are going to use to upload packages to PyPI. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281317542 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ I talked with Honza how to handle the build dependency for pypi, and we may to remove the commit that adds python-wheel or add new option to specfile that will install pypi related packages `with_pypi` or so. Do you plan to have more dependencies related only to pypi? """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281315896 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ Yes, it is the right thing to do. You can trust in the expert with a decade of experience with Python packaging (formerly known as cheese shop). """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281282232 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ We want to prevent others to have packages in PyPI with the same names as used for IPA. This is reasonable for protecting users to get attacker code from PyPI and rewrite working modules installed from rpms. In case that somebody install `ipamodulefromhell` we really cannot help this user """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281056392 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages HonzaCholasta commented: """ Is this really the right thing to do? IMO it does not make much sense to have placeholders for every `ipa*` package, as it does not scale at all - nothing is preventing a potential attacker to register their own `ipa*` package, which will confuse PyPI users all the same and will prevent us to use that name ourselves in the future, should we want to. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281011551 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ At the moment wheels are not required for RPM building. python-wheel is not available on RHEL, but I can work around it. Should the RPM spec file only contain dependencies for RPM packaging or also dependencies for general development and general packaging? I can create placeholder modules for ipaserver, ipaplatform and ipatests, too. It's going to be a bit more tricky. Let's see... """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-280690085 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ I'm not an expert about how PyPI is working, but shouldn't be there also placeholder packages for: - ipaserver - ipaplatform - ipatests How about [free]ipa-server and friends, can a bad person use this for an attack when somebody uses `pip install freeipa-server` ? """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-280682669 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ Shouldn't we have build dependency on `python[3]-wheel` without it `bdist_wheel` target is not working """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-280679788 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
