[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-23 Thread pvoborni
  URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft

pvoborni commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/728a6bd4229ba170b2e94f216127b19d5d94e2ba
https://fedorahosted.org/freeipa/changeset/a39effed7603d66acd238e3142f4df8081ff7bc8
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/484#issuecomment-281997170
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-23 Thread tomaskrizek
  URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft

tomaskrizek commented:
"""
Works as expected.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/484#issuecomment-281979229
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-20 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft

stlaz commented:
"""
All should be fixed now.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/484#issuecomment-281120295
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-20 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft

tiran commented:
"""
pylint needs some attention, too.

```
* Module ipaserver.install.cainstance
ipaserver/install/cainstance.py:685: [E1101(no-member), 
CAInstance.import_ra_cert] Instance of 'CAInstance' has no 'ra_agent_db' member)
ipaserver/install/cainstance.py:685: [E1101(no-member), 
CAInstance.import_ra_cert] Instance of 'CAInstance' has no 'ra_agent_pwd' 
member)
ipaserver/install/cainstance.py:831: [E1101(no-member), 
CAInstance.__request_ra_certificate] Instance of 'CAInstance' has no 
'ra_agent_db' member)
ipaserver/install/cainstance.py:834: [E1101(no-member), 
CAInstance.__request_ra_certificate] Instance of 'CAInstance' has no 
'ra_agent_pwd' member)
* Module ipaserver.install.dogtaginstance
ipaserver/install/dogtaginstance.py:78: [E0602(undefined-variable), 
export_kra_agent_pem] Undefined variable 'tempfile')
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/484#issuecomment-281075216
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-20 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft

stlaz commented:
"""
Always tend to forget about the upgrade part, will do, thanks  
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/484#issuecomment-281069900
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-20 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft

tiran commented:
"""
Or you could always clean up ```/root/.dogtag``` and remove the tmp dir when 
the var is not None.

By the way do you clean up ```/root/.dogtag``` during update?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/484#issuecomment-281063403
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-20 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft

stlaz commented:
"""
Hm, originally had this over the nsslib removal patchset but the rebase was not 
as successful as I thought, will fix the issues.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/484#issuecomment-281061194
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-20 Thread MartinBasti
  URL: https://github.com/freeipa/freeipa/pull/484
Title: #484: FIPS: Remove pkispawn cruft

MartinBasti commented:
"""
```
* Module ipaserver.install.cainstance
ipaserver/install/cainstance.py:685: [E1101(no-member), 
CAInstance.import_ra_cert] Instance of 'CAInstance' has no 'ra_agent_db' member)
ipaserver/install/cainstance.py:685: [E1101(no-member), 
CAInstance.import_ra_cert] Instance of 'CAInstance' has no 'ra_agent_pwd' 
member)
ipaserver/install/cainstance.py:831: [E1101(no-member), 
CAInstance.__request_ra_certificate] Instance of 'CAInstance' has no 
'ra_agent_db' member)
ipaserver/install/cainstance.py:834: [E1101(no-member), 
CAInstance.__request_ra_certificate] Instance of 'CAInstance' has no 
'ra_agent_pwd' member)
* Module ipaserver.install.dogtaginstance
ipaserver/install/dogtaginstance.py:78: [E0602(undefined-variable), 
export_kra_agent_pem] Undefined variable 'tempfile')
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/484#issuecomment-281060112
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code