URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: certdb: use certutil and match_hostname for cert verification
MartinBasti commented:
"""
master:
* 9183cf2a7505624235b255b1406702cdaa65bb38 certdb: use certutil and
match_hostname for cert verification
*
URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: certdb: use certutil and match_hostname for cert verification
HonzaCholasta commented:
"""
Awesome indeed!
As for your suggestions to improve the validation, I completely agree with
them, but the focus of this PR is to refactor the
URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: certdb: use certutil and match_hostname for cert verification
tiran commented:
"""
Your PR is going to remove the last import from python-nss. Awesome!
Please remove the requirement from ```ipapython/setup.py``` and
URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: certdb: use certutil and match_hostname for cert verification
tiran commented:
"""
github magic is bad magic :/ It still shows up as 'conflicting' for me.
I'll try to find time to review the issue tomorrow, Thursday latest.
"""
See
URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: certdb: use certutil and match_hostname for cert verification
stlaz commented:
"""
I tried to use the wonderful github tool to resolve conflicts to make this more
review-friendly but I guess it kind of missed the magic, it's ready
URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: certdb: use certutil and match_hostname for cert verification
stlaz commented:
"""
@tiran Could you please finish the review? I guess we can omit the change in
`.spec.in` for the review time being.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/490
Title: #490: certdb: use certutil and match_hostname for cert verification
HonzaCholasta commented:
"""
I think this PR is ready now.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/490#issuecomment-285002490
--
Manage your
