URL: https://github.com/freeipa/freeipa/pull/546
Title: #546: Store session cookie in a ccache option
MartinBasti commented:
"""
master:
* 7cab95955539b5f9596dcda5886ea3d9755fb193 Store session cookie in a ccache
option
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/546
Title: #546: Store session cookie in a ccache option
simo5 commented:
"""
Oops sorry, forgot to run make pylint on my last iteration, should be all fixed
now
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/546
Title: #546: Store session cookie in a ccache option
MartinBasti commented:
"""
```
* Module ipapython.session_storage
ipapython/session_storage.py:187: [W1624(indexing-exception), remove_data]
Indexing exceptions will not work on
URL: https://github.com/freeipa/freeipa/pull/546
Title: #546: Store session cookie in a ccache option
simo5 commented:
"""
Ok I decide to do away with the whole class stuff, given we never really keep a
round the class object for more than one operation at a time in actual use.
As @rcritten
URL: https://github.com/freeipa/freeipa/pull/546
Title: #546: Store session cookie in a ccache option
simo5 commented:
"""
I also renamed the module and the class, makes more sense to me this way around.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/546
Title: #546: Store session cookie in a ccache option
simo5 commented:
"""
Ok removed a bunch of code and made sure pylint passes.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/546#issuecomment-284775623
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/546
Title: #546: Store session cookie in a ccache option
simo5 commented:
"""
@rcritten the keyring stuff is still used for detection of keyring in other
places, so I did not touch it as those uses are still vaild
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/546
Title: #546: Store session cookie in a ccache option
MartinBasti commented:
"""
Pylint failed and I have a few inline comments
```
* Module ipapython.ccache_storage
ipapython/ccache_storage.py:234: [C0305(trailing-newlines), ]
