[Freeipa-devel] [freeipa PR#584][comment] Improve the implementation of PKINIT certificate retrieval

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/584 Title: #584: Improve the implementation of PKINIT certificate retrieval MartinBasti commented: """ master: * 95768de06fbef78169329af12b29e4d65e4bf157 Make PKINIT certificate request logic consistent with other installers *

[Freeipa-devel] [freeipa PR#584][comment] Improve the implementation of PKINIT certificate retrieval

2017-03-15 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/584 Title: #584: Improve the implementation of PKINIT certificate retrieval MartinBasti commented: """ Works for me and code looks OK """ See the full comment at https://github.com/freeipa/freeipa/pull/584#issuecomment-286781521 -- Manage your

[Freeipa-devel] [freeipa PR#584][comment] Improve the implementation of PKINIT certificate retrieval

2017-03-15 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/584 Title: #584: Improve the implementation of PKINIT certificate retrieval martbab commented: """ I have reworked the PR quite a bit and added/changed a few checks due to replication race conditions affecting PKINIT requests from replica to master.

[Freeipa-devel] [freeipa PR#584][comment] Improve the implementation of PKINIT certificate retrieval

2017-03-15 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/584 Title: #584: Improve the implementation of PKINIT certificate retrieval martbab commented: """ @simo5 are you OK with @abbra's inline suggestions (it is your commit after all :))? @MartinBasti hmmm I will try to reproduce the issue with fresh

[Freeipa-devel] [freeipa PR#584][comment] Improve the implementation of PKINIT certificate retrieval

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/584 Title: #584: Improve the implementation of PKINIT certificate retrieval MartinBasti commented: """ Since I applied this PR, I cannot pass through failing client side installation: ``` Forwarding 'ping' to json server