[Freeipa-devel] [freeipa PR#682][comment] ipserver/dcerpc: unify error processing

2017-04-10 Thread pvoborni
  URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipserver/dcerpc: unify error processing

pvoborni commented:
"""
A ticket was created for this PR: https://pagure.io/freeipa/issue/6859
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/682#issuecomment-292910558
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#682][comment] ipserver/dcerpc: unify error processing

2017-04-07 Thread MartinBasti
  URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipserver/dcerpc: unify error processing

MartinBasti commented:
"""
Please fix issues found by pylint
```
* Module ipaserver.plugins.trust
ipaserver/plugins/trust.py:1753: [W0612(unused-variable), 
trust_fetch_domains.execute] Unused variable 'trust_direction')
ipaserver/plugins/trust.py:1754: [W0612(unused-variable), 
trust_fetch_domains.execute] Unused variable 'is_nontransitive')
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/682#issuecomment-292560905
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#682][comment] ipserver/dcerpc: unify error processing

2017-04-03 Thread abbra
  URL: https://github.com/freeipa/freeipa/pull/682
Title: #682: ipserver/dcerpc: unify error processing

abbra commented:
"""
Note: this is WIP, I'm waiting for Sudhir to provide a bug and logs that show 
the changes he encountered when running existing test suite against Samba 4.6.2.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/682#issuecomment-291070811
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code