Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

2015-12-02 Thread Martin Basti
. - alich - - Original Message - From: "Milan Kubík" <mku...@redhat.com> To: freeipa-devel@redhat.com Sent: Friday, November 27, 2015 3:40:29 PM Subject: Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package On 11/27/2015 03:36 PM, M

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

2015-12-02 Thread Aleš Mareček
y.builtin.exec_(co, mod.__dict__) > > test_xmlrpc/test_certprofile_plugin.py:17: in > > from ipatests.test_xmlrpc.tracker.certprofile_plugin import > > CertprofileTracker > > E ImportError: No module named tracker.certprofile_plugin > > > > > > ..

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

2015-11-30 Thread Aleš Mareček
Tested with today's master, ACK. - alich - - Original Message - > From: "Milan Kubík" <mku...@redhat.com> > To: freeipa-devel@redhat.com > Sent: Friday, November 27, 2015 3:40:29 PM > Subject: Re: [Freeipa-devel] [patch 0025] Separated Tracker implementation

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

2015-11-30 Thread Martin Basti
9 PM Subject: Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package On 11/27/2015 03:36 PM, Milan Kubík wrote: On 11/27/2015 03:31 PM, Milan Kubík wrote: On 11/23/2015 10:43 AM, Lenka Doudova wrote: NACK - there's a "typo" in /tracker/user_plu

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

2015-11-27 Thread Milan Kubík
On 11/27/2015 03:31 PM, Milan Kubík wrote: On 11/23/2015 10:43 AM, Lenka Doudova wrote: NACK - there's a "typo" in /tracker/user_plugin.py, line 17-18: def get_user_dn(cn): return DN(('cn', cn), api.env.container_user, api.env.basedn) should be def get_user_dn(uid): return

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

2015-11-23 Thread Lenka Doudova
NACK - there's a "typo" in /tracker/user_plugin.py, line 17-18: def get_user_dn(cn): return DN(('cn', cn), api.env.container_user, api.env.basedn) should be def get_user_dn(uid): return DN(('uid', uid), api.env.container_user, api.env.basedn) Some tests may fail because of

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

2015-11-20 Thread Aleš Mareček
Looks good. ACK. - Original Message - > From: "Milan Kubík" > To: "freeipa-devel" > Cc: "Filip Skola" , "Ales Marecek" > Sent: Friday, November 20, 2015 3:44:30 PM > Subject: [patch 0025] Separated