[Freeipa-devel] [freeipa PR#829][comment] client.py: Replace hardcoded 'admin' with options.principal

2017-06-02 Thread Tiboris via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/829 Title: #829: client.py: Replace hardcoded 'admin' with options.principal Tiboris commented: """ Hello @flo-renaud do I have to create new ticket for it or the ipa-client-automount will remain as it is? """ See the full comment at

[Freeipa-devel] [freeipa PR#844][comment] py3: fix regression in schemaupdate

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/844 Title: #844: py3: fix regression in schemaupdate MartinBasti commented: """ Thank you for this catch """ See the full comment at https://github.com/freeipa/freeipa/pull/844#issuecomment-305716693 ___

[Freeipa-devel] [freeipa PR#844][+ack] py3: fix regression in schemaupdate

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/844 Title: #844: py3: fix regression in schemaupdate Label: +ack ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to

[Freeipa-devel] [freeipa PR#829][comment] client.py: Replace hardcoded 'admin' with options.principal

2017-06-02 Thread flo-renaud via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/829 Title: #829: client.py: Replace hardcoded 'admin' with options.principal flo-renaud commented: """ Hi @Tiboris I think we can leave ipa-client-automount as it is. """ See the full comment at

[Freeipa-devel] [freeipa PR#844][comment] py3: fix regression in schemaupdate

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/844 Title: #844: py3: fix regression in schemaupdate MartinBasti commented: """ master: * 89eb162fcd60861ed4c628dab4e1aaf10c6160bb py3: fix regression in schemaupdate """ See the full comment at

[Freeipa-devel] [freeipa PR#844][closed] py3: fix regression in schemaupdate

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/844 Author: frasertweedale Title: #844: py3: fix regression in schemaupdate Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/844/head:pr844 git checkout pr844

[Freeipa-devel] [freeipa PR#844][+py3] py3: fix regression in schemaupdate

2017-06-02 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/844 Title: #844: py3: fix regression in schemaupdate Label: +py3 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to

[Freeipa-devel] [freeipa PR#845][synchronized] ipadiscovery: Return realm as a string

2017-06-02 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/845 Author: stlaz Title: #845: ipadiscovery: Return realm as a string Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/845/head:pr845 git checkout pr845 From

[Freeipa-devel] [freeipa PR#845][comment] ipadiscovery: Return realm as a string

2017-06-02 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/845 Title: #845: ipadiscovery: Return realm as a string stlaz commented: """ https://tools.ietf.org/html/rfc1464 suggests that only ASCII may be contained in a TXT record, although I like to go with the Internet rule: "Trust noone." and so I

[Freeipa-devel] [freeipa PR#845][+py3] ipadiscovery: Return realm as a string

2017-06-02 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/845 Title: #845: ipadiscovery: Return realm as a string Label: +py3 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to

[Freeipa-devel] [freeipa PR#845][opened] ipadiscovery: Return realm as a string

2017-06-02 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/845 Author: stlaz Title: #845: ipadiscovery: Return realm as a string Action: opened PR body: """ We don't have a use for realm as a bytes instance, return it as a string, otherwise there's a use of str() on bytes in py3.

[Freeipa-devel] [freeipa PR#845][comment] ipadiscovery: Return realm as a string

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/845 Title: #845: ipadiscovery: Return realm as a string MartinBasti commented: """ A TXT record can contain anything in any encoding, it contains just bytes without predefined semantic, we should play safe here and catch UnicodeDecodeError. Also

[Freeipa-devel] [freeipa PR#846][+WIP] Travis: Add tox tests

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/846 Title: #846: Travis: Add tox tests Label: +WIP ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#842][edited] Changed ownership of ldiffile to DS_USER

2017-06-02 Thread tscherf via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/842 Author: tscherf Title: #842: Changed ownership of ldiffile to DS_USER Action: edited Changed field: body Original value: """ Changes the ownership of the modified ldiffile created by ipa-restore to dirsrv. If the file is owned by root,

[Freeipa-devel] [freeipa PR#845][comment] ipadiscovery: Return realm as a string

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/845 Title: #845: ipadiscovery: Return realm as a string MartinBasti commented: """ That is an experimental only RFC. By general it can contain any byte textually represented in octal form. str() in python2 converts from bytes using ASCII codec, so

[Freeipa-devel] [freeipa PR#823][comment] ipa-kdb: reload certificate mapping rules periodically

2017-06-02 Thread dkupka via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/823 Title: #823: ipa-kdb: reload certificate mapping rules periodically dkupka commented: """ @sumit-bose I got confused by "periodically" in title and "every 5 minutes" in description. It works as expected. """ See the full comment at

[Freeipa-devel] [freeipa PR#849][opened] session_storage: Correctly handle string/byte types

2017-06-02 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/849 Author: stlaz Title: #849: session_storage: Correctly handle string/byte types Action: opened PR body: """ In session_storage.py, store_data() stores data as the bytes data type but get_data() is returning a string. Have get_data() return bytes

[Freeipa-devel] [freeipa PR#849][+py3] session_storage: Correctly handle string/byte types

2017-06-02 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/849 Title: #849: session_storage: Correctly handle string/byte types Label: +py3 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to

[Freeipa-devel] [freeipa PR#847][opened] Turn off OCSP check

2017-06-02 Thread pvomacka via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/847 Author: pvomacka Title: #847: Turn off OCSP check Action: opened PR body: """ The OCSP check was previously turned on but it introduced several issues. Therefore the check will be turned off by default. For turning on should be used ipa advise

[Freeipa-devel] [freeipa PR#701][comment] ipa help doesn't always work

2017-06-02 Thread neffs via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/701 Title: #701: ipa help doesn't always work neffs commented: """ Not sure why pylint is reporting this, it looks fine to me and I didn't change this function. ```python if isinstance(self._help, bytes): self._help =

[Freeipa-devel] [freeipa PR#823][comment] ipa-kdb: reload certificate mapping rules periodically

2017-06-02 Thread sumit-bose via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/823 Title: #823: ipa-kdb: reload certificate mapping rules periodically sumit-bose commented: """ > @sumit-bose I got confused by "periodically" in title and "every 5 minutes" > in description. It works as expected. ah, yes, I'm sorry the wording

[Freeipa-devel] [freeipa PR#848][opened] sssd.py: Deprecating no-sssd option.

2017-06-02 Thread Tiboris via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/848 Author: Tiboris Title: #848: sssd.py: Deprecating no-sssd option. Action: opened PR body: """ Resolves: https://pagure.io/freeipa/issue/5860 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git

[Freeipa-devel] [freeipa PR#847][+prioritized] Turn off OCSP check

2017-06-02 Thread pvoborni via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/847 Title: #847: Turn off OCSP check Label: +prioritized ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#850][opened] ipaldap py3 fixes

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/850 Author: MartinBasti Title: #850: ipaldap py3 fixes Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/850/head:pr850 git checkout pr850 From

[Freeipa-devel] [freeipa PR#850][+py3] ipaldap py3 fixes

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/850 Title: #850: ipaldap py3 fixes Label: +py3 ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org

[Freeipa-devel] [freeipa PR#823][closed] ipa-kdb: reload certificate mapping rules periodically

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/823 Author: sumit-bose Title: #823: ipa-kdb: reload certificate mapping rules periodically Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/823/head:pr823 git checkout

[Freeipa-devel] [freeipa PR#847][comment] Turn off OCSP check

2017-06-02 Thread martbab via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/847 Title: #847: Turn off OCSP check martbab commented: """ How did we resolve the issue of tracking nssocsp status in sysupgrade state? Shouldn't we record this so that we now it was disabled by our installer/upgrader? """ See the full comment at

[Freeipa-devel] [freeipa PR#846][synchronized] Travis: Add tox tests

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/846 Author: MartinBasti Title: #846: Travis: Add tox tests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/846/head:pr846 git checkout pr846 From

[Freeipa-devel] [freeipa PR#818][comment] Avoid possible endless recursion in RPC call from client

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client MartinBasti commented: """ master: * 81a808caeb5676427610e113b5a259511c2835d6 Avoid possible endless recursion in RPC call * 79d1752577e8fcb568b701509fe5b52f949d5e4b rpc:

[Freeipa-devel] [freeipa PR#818][+pushed] Avoid possible endless recursion in RPC call from client

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/818 Title: #818: Avoid possible endless recursion in RPC call from client Label: +pushed ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to

[Freeipa-devel] [freeipa PR#818][closed] Avoid possible endless recursion in RPC call from client

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/818 Author: stlaz Title: #818: Avoid possible endless recursion in RPC call from client Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/818/head:pr818 git checkout

[Freeipa-devel] [freeipa PR#812][+pushed] Refactoring cert-find to use API call directly instead of using

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Title: #812: Refactoring cert-find to use API call directly instead of using Label: +pushed ___ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to

[Freeipa-devel] [freeipa PR#812][comment] Refactoring cert-find to use API call directly instead of using

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Title: #812: Refactoring cert-find to use API call directly instead of using MartinBasti commented: """ master: * 44bd5e358b027f8956b730f250854efb5087f05e Changing cert-find to do not use only primary key to search in LDAP. ipa-4-5: *

[Freeipa-devel] [freeipa PR#812][closed] Refactoring cert-find to use API call directly instead of using

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Author: felipevolpone Title: #812: Refactoring cert-find to use API call directly instead of using Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/812/head:pr812

[Freeipa-devel] [freeipa PR#846][synchronized] Travis: Add tox tests

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/846 Author: MartinBasti Title: #846: Travis: Add tox tests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/846/head:pr846 git checkout pr846 From

[Freeipa-devel] [freeipa PR#821][comment] fix incorrect suffix handling in topology checks

2017-06-02 Thread felipevolpone via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/821 Title: #821: fix incorrect suffix handling in topology checks felipevolpone commented: """ Tested, works as advertised. """ See the full comment at https://github.com/freeipa/freeipa/pull/821#issuecomment-305861037