URL: https://github.com/freeipa/freeipa/pull/1459 Author: felipevolpone Title: #1459: Make IntegrationTest fail if an error happened during uninstall Action: opened
PR body: """ Before this change, if the uninstall process fails, the test would not fail, due to the raiseonerr=False. Fixes: https://pagure.io/freeipa/issue/7357 The results can be checked here: https://fedorapeople.org/groups/freeipa/prci/jobs/e0c64916-f6ff-11e7-baa4-001a4a23169a/ https://fedorapeople.org/groups/freeipa/prci/jobs/05d5be8a-f700-11e7-a97e-001a4a231699/ """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/1459/head:pr1459 git checkout pr1459
From d865bde3f00699c68f1e62cb5abd075eb4f73764 Mon Sep 17 00:00:00 2001 From: Felipe Barreto <fbarr...@redhat.com> Date: Thu, 11 Jan 2018 17:33:59 -0200 Subject: [PATCH] Make IntegrationTest fail if an error happened during uninstall Before this change if the uninstall process fails, the test would not fail, due to the raiseonerr=False. Fixes: https://pagure.io/freeipa/issue/7357 --- ipatests/pytest_plugins/integration/tasks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipatests/pytest_plugins/integration/tasks.py b/ipatests/pytest_plugins/integration/tasks.py index b407145ace..2d1932ff62 100644 --- a/ipatests/pytest_plugins/integration/tasks.py +++ b/ipatests/pytest_plugins/integration/tasks.py @@ -709,7 +709,7 @@ def uninstall_master(host, ignore_topology_disconnect=True, if ignore_last_of_role and host_domain_level != DOMAIN_LEVEL_0: uninstall_cmd.append('--ignore-last-of-role') - host.run_command(uninstall_cmd, raiseonerr=False) + host.run_command(uninstall_cmd) host.run_command(['pkidestroy', '-s', 'CA', '-i', 'pki-tomcat'], raiseonerr=False) host.run_command(['rm', '-rf',
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
