URL: https://github.com/freeipa/freeipa/pull/1136 Author: slaykovsky Title: #1136: ipaclient.plugins.dns: Cast DNS name to unicode. Action: opened
PR body: """ cmd.api.Command.dnsrecord_split_parts expects name to be unicode string and instead gets ascii. It leads to an error: ipa: ERROR: invalid 'name': must be Unicode text This commit's change is casting name's type to unicode so 'ipa dnsrecord-mod' will not fail with error above. https://pagure.io/freeipa/issue/7185 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/1136/head:pr1136 git checkout pr1136
From bcd3a67aaf90a546557d6653337aa6d28cc672d2 Mon Sep 17 00:00:00 2001 From: Aleksei Slaikovskii <aslai...@redhat.com> Date: Fri, 6 Oct 2017 11:08:12 +0200 Subject: [PATCH] ipaclient.plugins.dns: Cast DNS name to unicode. cmd.api.Command.dnsrecord_split_parts expects name to be unicode string and instead gets ascii. It leads to an error: ipa: ERROR: invalid 'name': must be Unicode text This commit's change is casting name's type to unicode so 'ipa dnsrecord-mod' will not fail with error above. https://pagure.io/freeipa/issue/7185 --- ipaclient/plugins/dns.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipaclient/plugins/dns.py b/ipaclient/plugins/dns.py index f67189757d..ba3734b1e7 100644 --- a/ipaclient/plugins/dns.py +++ b/ipaclient/plugins/dns.py @@ -62,7 +62,7 @@ def __get_part_param(rrtype, cmd, part, output_kw, default=None): def prompt_parts(rrtype, cmd, mod_dnsvalue=None): mod_parts = None if mod_dnsvalue is not None: - name = record_name_format % rrtype.lower() + name = unicode(record_name_format % rrtype.lower()) mod_parts = cmd.api.Command.dnsrecord_split_parts( name, mod_dnsvalue)['result']
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
