URL: https://github.com/freeipa/freeipa/pull/1486
Author: tiran
Title: #1486: Fix pylint error in ipapython/dn.py
Action: opened
PR body:
"""
ipapython/dn.py:1324: [R1710(inconsistent-return-statements), DN.__contains__]
Either all return statements in a function should return an expression, or none
of them should.)
Signed-off-by: Christian Heimes <chei...@redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1486/head:pr1486
git checkout pr1486
From 4504efa0703544253db0a373fcb211003eccc26e Mon Sep 17 00:00:00 2001
From: Christian Heimes <chei...@redhat.com>
Date: Tue, 23 Jan 2018 14:12:33 +0100
Subject: [PATCH] Fix pylint error in ipapython/dn.py
ipapython/dn.py:1324: [R1710(inconsistent-return-statements), DN.__contains__]
Either all return statements in a function should return an expression, or none of them should.)
Signed-off-by: Christian Heimes <chei...@redhat.com>
---
ipapython/dn.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ipapython/dn.py b/ipapython/dn.py
index 9499096f45..33d06eed00 100644
--- a/ipapython/dn.py
+++ b/ipapython/dn.py
@@ -1336,8 +1336,7 @@ def __contains__(self, other):
return True
i += 1
return False
- else:
- raise TypeError("expected DN or RDN but got %s" % (other.__class__.__name__))
+ raise TypeError("expected DN or RDN but got %s" % (other.__class__.__name__))
def find(self, pattern, start=None, end=None):
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
