URL: https://github.com/freeipa/freeipa/pull/2707
Author: xxblx
 Title: #2707: Remove stale kdcinfo_* files when upgrading IPA server
Action: opened

PR body:
"""
Added removing of stale `/var/lib/sss/pubconf/kdcinfo_*` files generated by 
SSSD during IPA server upgrade.

Fixes: https://pagure.io/freeipa/issue/7578
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2707/head:pr2707
git checkout pr2707
From f68052890b2f610689f38762633bcb99efc3dcc5 Mon Sep 17 00:00:00 2001
From: Oleg Kozlov <okoz...@redhat.com>
Date: Thu, 20 Dec 2018 17:16:08 +0100
Subject: [PATCH] Remove stale kdcinfo_* files when upgrading IPA server

Added removing of stale /var/lib/sss/pubconf/kdcinfo_* files generated by SSSD during IPA server upgrade.

Fixes: https://pagure.io/freeipa/issue/7578
---
 ipaserver/install/server/upgrade.py | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/ipaserver/install/server/upgrade.py b/ipaserver/install/server/upgrade.py
index 02ffaa10b9..d863fc44cc 100644
--- a/ipaserver/install/server/upgrade.py
+++ b/ipaserver/install/server/upgrade.py
@@ -8,6 +8,7 @@
 import logging
 import re
 import os
+import glob
 import shutil
 import pwd
 import fileinput
@@ -269,6 +270,7 @@ def cleanup_kdc(fstore):
             fstore.untrack_file(filename)
             logger.debug('Uninstalling %s', filename)
 
+
 def cleanup_adtrust(fstore):
     """
     Clean up any old Samba backup files that were deprecated.
@@ -304,6 +306,14 @@ def cleanup_dogtag():
         instance.clean_pkispawn_files()
 
 
+def cleanup_kdcinfo():
+    """ Remove stale kdcinfo_* files generated by SSSD """
+
+    for filename in glob.glob('/var/lib/sss/pubconf/kdcinfo_*'):
+        logger.debug('Removing stale KDC info file %s', filename)
+        os.unlink(filename)
+
+
 def upgrade_adtrust_config():
     """
     Upgrade 'dedicated keytab file' in smb.conf to omit FILE: prefix
@@ -1955,6 +1965,7 @@ def upgrade_configuration():
     cleanup_kdc(fstore)
     cleanup_adtrust(fstore)
     cleanup_dogtag()
+    cleanup_kdcinfo()
     upgrade_adtrust_config()
 
     bind = bindinstance.BindInstance(fstore)
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org

Reply via email to