URL: https://github.com/freeipa/freeipa/pull/826 Author: MartinBasti Title: #826: Pylint 3 fixes Action: opened
PR body: """ Accidentally we weren't running pylint-3 in travis """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/826/head:pr826 git checkout pr826
From 2c151760755fefb6d73b0082a3f183b5c23c37ac Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Fri, 26 May 2017 22:10:57 +0200 Subject: [PATCH 1/2] py3: add missing py3 pylint depedencies https://pagure.io/freeipa/issue/6874 https://pagure.io/freeipa/issue/4985 --- freeipa.spec.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/freeipa.spec.in b/freeipa.spec.in index 3cb137f3a7..e6f63a2675 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -238,6 +238,10 @@ BuildRequires: python3-paste BuildRequires: python3-systemd BuildRequires: python3-jinja2 BuildRequires: python3-augeas +BuildRequires: python3-netaddr +BuildRequires: python3-pyasn1 +BuildRequires: python3-pyasn1-modules +BuildRequires: python3-pyldap %endif # with_python3 %endif # with_lint From 556abddaea267f57c11bde15fc82be98a80cddf1 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Fri, 26 May 2017 23:05:17 +0200 Subject: [PATCH 2/2] travis: fix pylint execution with py3 Python version was placed at wrong position, py3 hasn't been tested at all in travis. https://pagure.io/freeipa/issue/4985 --- .test_runner_config.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.test_runner_config.yaml b/.test_runner_config.yaml index cfb65db1bf..014c64854b 100644 --- a/.test_runner_config.yaml +++ b/.test_runner_config.yaml @@ -51,8 +51,8 @@ steps: - sed -ri "s/mode = production/mode = development/" /etc/ipa/default.conf - systemctl restart httpd.service lint: - - PYTHON=/usr/bin/python2 make V=0 lint - - PYTHON=/usr/bin/python3 make V=0 pylint + - make PYTHON=/usr/bin/python2 V=0 lint + - make PYTHON=/usr/bin/python3 V=0 pylint prepare_tests: - echo ${server_password} | kinit admin && ipa ping - cp -r /etc/ipa/* ~/.ipa/
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org