URL: https://github.com/freeipa/freeipa/pull/845
Title: #845: ipadiscovery: Return realm as a string
MartinBasti commented:
"""
LGTM, we anyway assume inside framework that everything is in utf-8
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/845#issuecomment-307142144
URL: https://github.com/freeipa/freeipa/pull/845
Title: #845: ipadiscovery: Return realm as a string
MartinBasti commented:
"""
That is an experimental only RFC. By general it can contain any byte textually
represented in octal form.
str() in python2 converts from bytes using ASCII codec, so
URL: https://github.com/freeipa/freeipa/pull/845
Title: #845: ipadiscovery: Return realm as a string
stlaz commented:
"""
https://tools.ietf.org/html/rfc1464 suggests that only ASCII may be contained
in a TXT record, although I like to go with the Internet rule: "Trust noone."
and so I
URL: https://github.com/freeipa/freeipa/pull/845
Title: #845: ipadiscovery: Return realm as a string
MartinBasti commented:
"""
A TXT record can contain anything in any encoding, it contains just bytes
without predefined semantic, we should play safe here and catch
UnicodeDecodeError.
Also
