[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-07 Thread MartinBasti via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

MartinBasti commented:
"""
master:

* 77db574cca900eb03d8e0ab577568c2058ae4a86 Add code to be able to set default 
kinit lifetime
* c52ca92cdabf07da5b3b27344b8eaa8b161ea49b Revert setting sessionMaxAge for old 
clients


ipa-4-5:

* 0def2ec653ac29210414aa09499b309dd1c3ac7d Add code to be able to set default 
kinit lifetime
* 728e2f681a938f25d091a8480ec6db3961ebfc98 Revert setting sessionMaxAge for old 
clients


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306796858
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-07 Thread simo5 via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

simo5 commented:
"""
Ok I added it to pylint_plugins, hopefully it is addressed fully now

"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306767611
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-07 Thread MartinBasti via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

MartinBasti commented:
"""
@pvoborni yes, this is the way how to handle false positive missing members in 
pylint
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306759907
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-07 Thread pvoborni via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

pvoborni commented:
"""
@MartinBasti is the correct way how to solve this pylint issue to extend 
pylint_plugins.py?

snippet. of similar vars: 
```python
fake_api_env = {'env': [
'host',
'realm',
'session_auth_duration',
'session_duration_type',
]}

# this is due ipaserver.rpcserver.KerberosSession where api is undefined
fake_api = {'api': [fake_api_env] + NAMESPACE_ATTRS}
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306758867
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-07 Thread abbra via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

abbra commented:
"""
Looks like pylint is unhappy with such definitions. For most of other options 
from default.conf we have them explicitly set in `Env._bootstrap()`.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306755293
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-07 Thread simo5 via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

simo5 commented:
"""
Change to used the correct bug number:
https://pagure.io/freeipa/issue/7001
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306741024
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-06 Thread simo5 via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

simo5 commented:
"""
I thought just defining it as None in the constants was enough ?
We do not want to set a kinit_lifetime entry in defaults.conf, I am ok with the 
default being None for now I think.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306616228
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-06 Thread abbra via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

abbra commented:
"""
Pylint failed:
```
* Module ipaserver.rpcserver
ipaserver/rpcserver.py:973: [E1101(no-member), login_password.kinit] Class 
'env' has no 'kinit_lifetime' member)
make: *** [pylint] Error 2
```

Do we want to set `kinit_lifetime` during upgrade if it is missing?

"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306563697
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-06 Thread simo5 via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

simo5 commented:
"""
In my test setup I verified the cookie does not have the MaxAge setting, and 
that kinit_lifetime properly causes the session to expire after the lifetime 
indicated.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306539239
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#855][comment] Prevent issues with older clients

2017-06-06 Thread simo5 via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/855
Title: #855: Prevent issues with older clients

simo5 commented:
"""
Fixes https://pagure.io/freeipa/issue/6774
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/855#issuecomment-306538965
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org