[Freeipa-devel] [freeipa PR#867][comment] trust-mod: allow modifying list of UPNs of a trusted forest

2017-06-14 Thread martbab via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/867
Title: #867: trust-mod: allow modifying list of UPNs of a trusted forest

martbab commented:
"""
ipa-4-5:

* 9a31b21bff7c83219a4973adf815c900628ab620 trust-mod: allow modifying list of 
UPNs of a trusted forest


master:

* abb638487580af99882b4751b64939d0aff0d38b trust-mod: allow modifying list of 
UPNs of a trusted forest


"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/867#issuecomment-308452464
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#867][comment] trust-mod: allow modifying list of UPNs of a trusted forest

2017-06-14 Thread martbab via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/867
Title: #867: trust-mod: allow modifying list of UPNs of a trusted forest

martbab commented:
"""
Nevermind I fixed this for @abbra. Let's wait for Travis and then we can push 
it.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/867#issuecomment-308434278
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org


[Freeipa-devel] [freeipa PR#867][comment] trust-mod: allow modifying list of UPNs of a trusted forest

2017-06-14 Thread martbab via FreeIPA-devel
  URL: https://github.com/freeipa/freeipa/pull/867
Title: #867: trust-mod: allow modifying list of UPNs of a trusted forest

martbab commented:
"""
LGTM, the only little nitpick I have is that the CLI option should be named 
`--upn-suffixes` as `--upns` implies that you can specify full User principal 
names which you don't. You only specify suffixes.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/867#issuecomment-308396576
___
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org