Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0026-fixed-formatting-of-search-table.patch

2010-09-20 Thread Pavel Zuna
On 09/17/2010 04:33 PM, Adam Young wrote: admiyo-freeipa-0026-fixed-formatting-of-search-table.patch ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0027-fix-sampledata.patch

2010-09-20 Thread Pavel Zuna
On 09/17/2010 04:34 PM, Adam Young wrote: URL needs to be relative, not absolute in order for in tree development ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0031-unbroke-the-facets-link.patch

2010-09-20 Thread Pavel Zuna
On 09/17/2010 04:41 PM, Adam Young wrote: This has a fix for a previous patch which turned the facets into a hortizontal list, but broke the clickability. ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0032-css-cleanup.patch

2010-09-20 Thread Pavel Zuna
On 09/17/2010 04:42 PM, Adam Young wrote: Fixes many of the CSS issues introduced by jquery.ui.tabs. Not all, but it looks a lot better ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0033-pointer-cursor-for-facets.patch

2010-09-20 Thread Pavel Zuna
On 09/17/2010 04:43 PM, Adam Young wrote: Changes the mouse icon for facets to a the pointer, signifying clickability ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Icons

2010-09-20 Thread Pavel Zuna
On 09/18/2010 02:35 AM, Adam Young wrote: THese are just place holder icons until we get the offical ones from UXD. They look roughly like the finished product, with have some rough points. They will be used by the next patch to Generate the quick links and facets. THis is a huga patch, but it

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Pavel Zuna
On 09/17/2010 04:38 PM, Adam Young wrote: moved images up Adding an 'images' subdir was proliferating changes throughout the build system this seemed easier Submitted as a separate patch to signify where wea re departing from what is generated by theme-roller Doesn't apply for me. Missing

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0036-links-and-facet-icons.patch

2010-09-20 Thread Pavel Zuna
On 09/18/2010 02:36 AM, Adam Young wrote: This patch makes use of the previous patch to put the icons in the facets and quick links It looks OK, but I can't test it because the required patch 30 doesn't apply for me. Pavel ___ Freeipa-devel

[Freeipa-devel] [PATCH] admiyo-freeipa-0028-theme.patch

2010-09-20 Thread Adam Young
admiyo-freeipa-0028-theme.patch Use customized theme and images that is closer to the UX suggested look and feel This is required to get patch 30 to apply as well. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0028-theme.patch

2010-09-20 Thread Adam Young
On 09/20/2010 09:19 AM, Adam Young wrote: admiyo-freeipa-0028-theme.patch Use customized theme and images that is closer to the UX suggested look and feel This is required to get patch 30 to apply as well. ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0034-2-Metadata-I18N.patch

2010-09-20 Thread Rob Crittenden
Adam Young wrote: On 09/17/2010 02:24 PM, Adam Young wrote: Metadata I18N Created a clone of the json_metadata plugin called plugin_metadata It is identical in all reagards to the json_metadata plugin, except it performs the gettext transalation based on the 'language' parameter Once this is

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0034-2-Metadata-I18N.patch

2010-09-20 Thread Rob Crittenden
Adam Young wrote: On 09/20/2010 10:07 AM, Rob Crittenden wrote: Adam Young wrote: On 09/17/2010 02:24 PM, Adam Young wrote: Metadata I18N Created a clone of the json_metadata plugin called plugin_metadata It is identical in all reagards to the json_metadata plugin, except it performs the

Re: [Freeipa-devel] [PATCH] Adding quick links in user and group search results.

2010-09-20 Thread Adam Young
On 09/15/2010 03:04 PM, Adam Young wrote: On 09/15/2010 01:48 PM, Endi Sukma Dewata wrote: - Adam Youngayo...@redhat.com wrote: ACK, but change the Column heading to Quick Links first OK, fixed. Thanks. -- Endi S. Dewata I've pushed my version of Pavel's patch to my Fedora people

Re: [Freeipa-devel] [PATCH] Add jQuery UI and jQuery BBQ libraries to the project

2010-09-20 Thread Adam Young
On 09/17/2010 01:28 PM, Pavel Zůna wrote: On 2010-09-16 17:10, Pavel Zuna wrote: This adds the minimized version - the ones we want to ship to the end user. For development you can still use the non-minimized versions just by renaming files in your index. Pavel Latest version attached.

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Endi Sukma Dewata
- Adam Young ayo...@redhat.com wrote: moved images up Adding an 'images' subdir was proliferating changes throughout the build system this seemed easier Submitted as a separate patch to signify where wea re departing from what is generated by theme-roller

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Adam Young
On 09/20/2010 12:14 PM, Endi Sukma Dewata wrote: - Adam Youngayo...@redhat.com wrote: moved images up Adding an 'images' subdir was proliferating changes throughout the build system this seemed easier Submitted as a separate patch to signify where wea re departing from what is

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0026-fixed-formatting-of-search-table.patch

2010-09-20 Thread Adam Young
On 09/20/2010 07:22 AM, Pavel Zuna wrote: On 09/17/2010 04:33 PM, Adam Young wrote: admiyo-freeipa-0026-fixed-formatting-of-search-table.patch ACK. Pavel Pushed to Master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0025-remove-pagaparams.patch

2010-09-20 Thread Adam Young
On 09/17/2010 04:03 PM, Endi Sukma Dewata wrote: - Adam Youngayo...@redhat.com wrote: Fixes a minor glitch in pzuna-freeipa-0022-4-BIG which re-introduced the pageparams.js entry into the Makefile.am ACK -- Endi S. Dewata Pushed top master

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0029-css-tabs-and-facets.patch

2010-09-20 Thread Adam Young
On 09/17/2010 10:39 AM, Adam Young wrote: On 09/17/2010 10:36 AM, Adam Young wrote: css tabs and facets includes Makfile changes to get images to deploy Note that the Makefile changes are undone by a later patch. ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0027-fix-sampledata.patch

2010-09-20 Thread Adam Young
On 09/20/2010 07:23 AM, Pavel Zuna wrote: On 09/17/2010 04:34 PM, Adam Young wrote: URL needs to be relative, not absolute in order for in tree development ACK. Pavel Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0031-unbroke-the-facets-link.patch

2010-09-20 Thread Adam Young
On 09/20/2010 07:57 AM, Pavel Zuna wrote: On 09/17/2010 04:41 PM, Adam Young wrote: This has a fix for a previous patch which turned the facets into a hortizontal list, but broke the clickability. ACK. Pavel Pushed to master ___ Freeipa-devel

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0032-css-cleanup.patch

2010-09-20 Thread Adam Young
On 09/20/2010 07:57 AM, Pavel Zuna wrote: On 09/17/2010 04:42 PM, Adam Young wrote: Fixes many of the CSS issues introduced by jquery.ui.tabs. Not all, but it looks a lot better ACK. Pavel Pushed to master ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] Icons

2010-09-20 Thread Adam Young
On 09/17/2010 08:35 PM, Adam Young wrote: THese are just place holder icons until we get the offical ones from UXD. They look roughly like the finished product, with have some rough points. They will be used by the next patch to Generate the quick links and facets. THis is a huga patch,

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch

2010-09-20 Thread Adam Young
On 09/20/2010 11:30 AM, Endi Sukma Dewata wrote: - Adam Youngayo...@redhat.com wrote: On 09/20/2010 08:10 AM, Pavel Zuna wrote: On 09/17/2010 04:38 PM, Adam Young wrote: moved images up Adding an 'images' subdir was proliferating changes throughout the build

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0036-links-and-facet-icons.patch

2010-09-20 Thread Adam Young
On 09/20/2010 08:29 AM, Pavel Zuna wrote: On 09/18/2010 02:36 AM, Adam Young wrote: This patch makes use of the previous patch to put the icons in the facets and quick links It looks OK, but I can't test it because the required patch 30 doesn't apply for me. Pavel ACKed in IRC by

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0034-2-Metadata-I18N.patch

2010-09-20 Thread Adam Young
On 09/20/2010 10:44 AM, John Dennis wrote: On 09/20/2010 10:19 AM, Adam Young wrote: On 09/20/2010 10:07 AM, Rob Crittenden wrote: And a small nit. The help for the argument says 2-character language code. This ignores the language subtags (e.g. en-US). If we get to the point that we are

[Freeipa-devel] [PATCH] 533 add hostname resolver

2010-09-20 Thread Rob Crittenden
Basic here is a hostname see if it is in DNS resolver. I put it as part of the DNS plugin because it seemed more of a natural fit there. It will work whether IPA is configured with a DNS server or not. It uses a pure DNS resolver library to find a host. It will append the default IPA domain

[Freeipa-devel] [PATCH] 534 updates to spec file

2010-09-20 Thread Rob Crittenden
Drop Requires on python-configobj. It is a leftover from TurboGears. Remove ipa-ldap-updater message. It was meant to detect when an upgrade is required, we're doing this differently in v2. rob freeipa-534-spec.patch Description: application/mbox

[Freeipa-devel] [PATCH] 536 throw and catch CertificateOperationError properly in replica preparer

2010-09-20 Thread Rob Crittenden
Properly handle CertificateOperationErrors in replication prepration. The problem here was two-fold: the certs manager was raising an error it didn't know about and ipa-replica-prepare wasn't catching it. rob freeipa-536-certs.patch Description: application/mbox

[Freeipa-devel] admiyo-freeipa-0038-I18N-of-RPC.patch

2010-09-20 Thread Adam Young
This is the simplest, most global approach to I18N. It does complete I18N on the server side by setting the locale on each request, based on the value in the http header. If we go this route, I can remove the parameter as a parameter on the metadata plugin To test this: curl -H

Re: [Freeipa-devel] [PATCH] 531 make DNS autodiscovery smarter

2010-09-20 Thread Adam Young
On 09/17/2010 09:33 PM, Rob Crittenden wrote: Better distinguish between when DNS discovery works and search more domains. Passing domain and server on the command-line used to be considered as DNS autodiscovery worked. This was problematic if there was in fact no SRV records because

Re: [Freeipa-devel] [PATCH] 532 unenroll when a client is uninstalled

2010-09-20 Thread Adam Young
On 09/17/2010 09:44 PM, Rob Crittenden wrote: Unenroll a host when a client is uninstalled. This means we bind using the host credentials and disable our own keytab. This will let the client be re-enrolled without requiring admin input (used to have to either delete the host or disable the

Re: [Freeipa-devel] admiyo-freeipa-0038-I18N-of-RPC.patch

2010-09-20 Thread Rob Crittenden
Adam Young wrote: This is the simplest, most global approach to I18N. It does complete I18N on the server side by setting the locale on each request, based on the value in the http header. If we go this route, I can remove the parameter as a parameter on the metadata plugin To test this:

Re: [Freeipa-devel] admiyo-freeipa-0038-I18N-of-RPC.patch

2010-09-20 Thread Adam Young
On 09/20/2010 03:18 PM, Rob Crittenden wrote: Adam Young wrote: This is the simplest, most global approach to I18N. It does complete I18N on the server side by setting the locale on each request, based on the value in the http header. If we go this route, I can remove the parameter as a

[Freeipa-devel] [PATCH] 537 add --zonemgr option to installer

2010-09-20 Thread Rob Crittenden
Add option to set the zone mgr e-mail address during install. rob freeipa-537-zonemgr.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 523 add 2 missing man pages

2010-09-20 Thread Rob Crittenden
Adam Young wrote: On 09/09/2010 06:00 PM, Rob Crittenden wrote: Add missing man pages for ipa-dns-install and ipa-upgradeconfig. tickets 130 and 131 rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 529 ipaUniqueId enforcement

2010-09-20 Thread Rob Crittenden
Adam Young wrote: On 09/15/2010 01:23 PM, Rob Crittenden wrote: Enforce that ipaUniqueId is a unique attribute via the DS uniqueness plugin and prevent updates to the attribute once it is written. rob ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 531 make DNS autodiscovery smarter

2010-09-20 Thread Rob Crittenden
Adam Young wrote: On 09/17/2010 09:33 PM, Rob Crittenden wrote: Better distinguish between when DNS discovery works and search more domains. Passing domain and server on the command-line used to be considered as DNS autodiscovery worked. This was problematic if there was in fact no SRV records

Re: [Freeipa-devel] [PATCH] 532 unenroll when a client is uninstalled

2010-09-20 Thread Rob Crittenden
Adam Young wrote: On 09/17/2010 09:44 PM, Rob Crittenden wrote: Unenroll a host when a client is uninstalled. This means we bind using the host credentials and disable our own keytab. This will let the client be re-enrolled without requiring admin input (used to have to either delete the host

[Freeipa-devel] [PATCH] Rolegroups tab.

2010-09-20 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks. The Makefile.am and index.xhtml has been modified to include rolegroup.js. The webui.js has been modified to register the rolegroup tab. The rolegroup.js defines the rolegroup's search, add, and details pages. Sample data for some rolegroup

[Freeipa-devel] admiyo-freeipa-0039-language-as-a-list.patch

2010-09-20 Thread Adam Young
The previous I18N patch only works if a single language is set in the headers. Typically, this header is a list, comma separated. THis version parsese the list and selects the first language. From 6f6ab56c0479faed3a1ae2474121891fd6983277 Mon Sep 17 00:00:00 2001 From: Adam Young

Re: [Freeipa-devel] [PATCH] Rolegroups tab.

2010-09-20 Thread Adam Young
On 09/20/2010 04:40 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks. The Makefile.am and index.xhtml has been modified to include rolegroup.js. The webui.js has been modified to register the rolegroup tab. The rolegroup.js defines the rolegroup's search, add, and

Re: [Freeipa-devel] [PATCH] Rolegroups tab.

2010-09-20 Thread Adam Young
On 09/20/2010 04:40 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks. The Makefile.am and index.xhtml has been modified to include rolegroup.js. The webui.js has been modified to register the rolegroup tab. The rolegroup.js defines the rolegroup's search, add, and

Re: [Freeipa-devel] admiyo-freeipa-0039-language-as-a-list.patch

2010-09-20 Thread Rob Crittenden
Adam Young wrote: The previous I18N patch only works if a single language is set in the headers. Typically, this header is a list, comma separated. THis version parsese the list and selects the first language. nack. You should make sure there isn't a weight on the language too.