[Freeipa-devel] [PATCH] import NSPRError in host.py

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The host plugin references NSPRError on couple of places but never imports it. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

Re: [Freeipa-devel] [PATCH] Modified ipa help behavior

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/09/2010 09:54 AM, Jan Zelený wrote: Jan Zelený jzel...@redhat.com wrote: Jan Zelený jzel...@redhat.com wrote: Now each plugin can define its topic as a 2-tuple, where the first item is the name of topic it belongs to and the second item is

Re: [Freeipa-devel] [PATCH] Added option --no-reverse to add-host

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/2010 07:05 PM, Jan Zelený wrote: When adding a host with specific IP address, the operation would fail in case we don't own the reverse DNS. This new option overrides the check for reverse DNS zone and falls back to different IP address

[Freeipa-devel] [PATCH] Allow renaming of object that have a parent

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 When performing an RDN change, we would construct the new DN from the RDN attribute only. This doesn't work when the object needs has a parent. There's currently no testcase, I hit that when working on automount - so this patch will be testable with

[Freeipa-devel] [PATCH] Make pkey always iterable when deleting

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 When deleting multiple objects, the code tries to enforce that the primary key is always iterable by doing: keys = keys[:-1] + (keys[-1], ) But this doesn't work, the line only concatenates two tuples effectively returning the original one. See the

[Freeipa-devel] [PATCH] 029 Enforce uniqueness on (key, info) pairs in automount keys

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Attached is a patch that changes the uniqueness constraint of automount keys from (key) to (key,info) pairs. The patch is not really standard baseldap style. The reason is that during development, I found that baseldap is really dependent on having a

Re: [Freeipa-devel] [PATCH] Make pkey always iterable when deleting

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/20/2010 03:07 PM, Jan Zelený wrote: Jakub Hrozek jhro...@redhat.com wrote: When deleting multiple objects, the code tries to enforce that the primary key is always iterable by doing: keys = keys[:-1] + (keys[-1], ) But this doesn't work,

Re: [Freeipa-devel] [PATCH] 029 Enforce uniqueness on (key, info) pairs in automount keys

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/20/2010 02:49 PM, Jakub Hrozek wrote: Attached is a patch that changes the uniqueness constraint of automount keys from (key) to (key,info) pairs. The patch is not really standard baseldap style. The reason is that during development, I found

[Freeipa-devel] [PATCH] 030 Fix delegation.ldif

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There was a typo in the delagation LDIF file that caused the LDIF to fail to load during installation. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

Re: [Freeipa-devel] [PATCH] 030 Fix delegation.ldif

2010-12-20 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There was a typo in the delagation LDIF file that caused the LDIF to fail to load during installation. ack, pushed to master rob ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 030 Fix delegation.ldif

2010-12-20 Thread Simo Sorce
On Mon, 20 Dec 2010 15:52:36 +0100 Jakub Hrozek jhro...@redhat.com wrote: There was a typo in the delagation LDIF file that caused the LDIF to fail to load during installation. Obviously correct, ACK and pushed to master. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [Freeipa-devel] [PATCH] Make pkey always iterable when deleting

2010-12-20 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/20/2010 03:07 PM, Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: When deleting multiple objects, the code tries to enforce that the primary key is always iterable by doing: keys = keys[:-1] + (keys[-1], ) But

Re: [Freeipa-devel] [PATCH] Allow renaming of object that have a parent

2010-12-20 Thread Rob Crittenden
Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: When performing an RDN change, we would construct the new DN from the RDN attribute only. This doesn't work when the object needs has a parent. There's currently no testcase, I hit that when working on automount - so this patch will be

Re: [Freeipa-devel] [PATCH] Added option --no-reverse to add-host

2010-12-20 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/2010 07:05 PM, Jan Zelený wrote: When adding a host with specific IP address, the operation would fail in case we don't own the reverse DNS. This new option overrides the check for reverse DNS zone and falls back to

Re: [Freeipa-devel] [PATCH] import NSPRError in host.py

2010-12-20 Thread Rob Crittenden
Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: The host plugin references NSPRError on couple of places but never imports it. Obviously ack pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] Fixed typos in man page of ipa-getkeytab.

2010-12-20 Thread Rob Crittenden
David O'Brien wrote: Gowrishankar Rajaiyan wrote: Hi All, Fixed typos in the man page of ipa-getkeytab and corrected my name in Contributors.txt. Regards /Shanks ACK pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 023 Clarify ipa-replica-install error message

2010-12-20 Thread Rob Crittenden
Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: Just a cosmetic fix to the replica installation error message, there's no ticket for this. ack Jan pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 025 Allow RDN changes from CLI

2010-12-20 Thread Rob Crittenden
Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: Adds a new parameter 'rename' to all objects with 'rdnattr' attribute. This parameter is a clone of the rdnattr attribute, except for name and docs, so normalizer, default_from and also the type are the same as the original attribute.

Re: [Freeipa-devel] [PATCH] 022 Check the number of fields when importing automount maps

2010-12-20 Thread Rob Crittenden
Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: https://fedorahosted.org/freeipa/ticket/359 Sending this separately from the other automount changes since those are more intrusive and may be under review for a while. ack Jan pushed to master

Re: [Freeipa-devel] [PATCH] 021 Make the IPA installer IPv6 friendly

2010-12-20 Thread Rob Crittenden
Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: On 12/15/2010 10:55 AM, Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: This is a first patch towards IPv6 support. Currently it only touches the installer only as other changes will be fully testable only when python-nss is

Re: [Freeipa-devel] [PATCH] 0032 Cleanup when deleting a replica

2010-12-20 Thread Jakub Hrozek
On Wed, Dec 15, 2010 at 08:01:10PM -0500, Simo Sorce wrote: Clean up records related to the master being deleted in the shared tree. This also avoid issues later on if you want to rejoin the server as a master. It is also needed in order to give back valid information for patch 0035

Re: [Freeipa-devel] [PATCH] 0033 Add disconnect command to change topology

2010-12-20 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/16/2010 02:02 AM, Simo Sorce wrote: This command will delete a replication agreement unless it is the last one on either server. It is used to change replication topology without actually removing any single master for the domain (the del

Re: [Freeipa-devel] [PATCH] Enable filtering search results by member attributes.

2010-12-20 Thread Adam Young
On 12/20/2010 11:20 AM, Jan Zelený wrote: Pavel Zunapz...@redhat.com wrote: On 12/08/2010 08:30 PM, Rob Crittenden wrote: Pavel Zůna wrote: On 2010-11-30 04:06, Rob Crittenden wrote: Pavel Zůna wrote: LDAPSearch base class has now the ability to

Re: [Freeipa-devel] [PATCH] Added option --no-reverse to add-host

2010-12-20 Thread Adam Young
On 12/20/2010 10:45 AM, Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/2010 07:05 PM, Jan Zelený wrote: When adding a host with specific IP address, the operation would fail in case we don't own the reverse DNS. This new option overrides the

[Freeipa-devel] [PATCH] 655 translation delegation group dns to names

2010-12-20 Thread Rob Crittenden
Translate the membergroup dn into a group name. Drop filter from the output, it is superfluous. ticket 634 From b8077ae7945f5395afc47f5d6d317e07d283fe3e Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Mon, 20 Dec 2010 13:53:35 -0500 Subject: [PATCH] Translate the

Re: [Freeipa-devel] [PATCH] Bugfixes for bind-dyndb-ldap

2010-12-20 Thread Simo Sorce
On Wed, 15 Dec 2010 12:29:01 -0500 Simo Sorce sso...@redhat.com wrote: On Wed, 15 Dec 2010 18:21:20 +0100 Adam Tkac at...@redhat.com wrote: Hello, those four patches for bind-dyndb-ldap fix following issues: 0001-Bugfix-Improve-LDAP-schema-to-be-loadable-by-OpenLDA.patch: -

Re: [Freeipa-devel] [PATCH] 0032 Cleanup when deleting a replica

2010-12-20 Thread Simo Sorce
On Mon, 20 Dec 2010 18:02:02 +0100 Jakub Hrozek jhro...@redhat.com wrote: On Wed, Dec 15, 2010 at 08:01:10PM -0500, Simo Sorce wrote: Clean up records related to the master being deleted in the shared tree. This also avoid issues later on if you want to rejoin the server as a

Re: [Freeipa-devel] [PATCH] 0033 Add disconnect command to change topology

2010-12-20 Thread Simo Sorce
On Mon, 20 Dec 2010 18:22:48 +0100 Jakub Hrozek jhro...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/16/2010 02:02 AM, Simo Sorce wrote: This command will delete a replication agreement unless it is the last one on either server. It is used to change

[Freeipa-devel] [PATCH] Remove referrals to removed replicas/links

2010-12-20 Thread Simo Sorce
When a replication agreement is removed also make sure to remove referrals to the replicas to avoid dangling referrals. This patch also fixes acis related to replica as the fix is also required to be able to change the referrals attributes. Simo. -- Simo Sorce * Red Hat, Inc * New York From

Re: [Freeipa-devel] [PATCH] 655 translation delegation group dns to names

2010-12-20 Thread Adam Young
On 12/20/2010 02:06 PM, Rob Crittenden wrote: Translate the membergroup dn into a group name. Drop filter from the output, it is superfluous. ticket 634 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 656 move permissions and privileges

2010-12-20 Thread Rob Crittenden
Move permissions and privileges to their own container. They don't really belong in cn=accounts any more. This leaves just roles there. ticket 638 rob From fd0716e92fa90f726f226e1c705d4f22b3742923 Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Mon, 20 Dec 2010 15:54:00

Re: [Freeipa-devel] [PATCH] Added option --no-reverse to add-host

2010-12-20 Thread Rob Crittenden
Adam Young wrote: On 12/20/2010 10:45 AM, Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/2010 07:05 PM, Jan Zelený wrote: When adding a host with specific IP address, the operation would fail in case we don't own the reverse DNS. This new

Re: [Freeipa-devel] [PATCH] 0032 Cleanup when deleting a replica

2010-12-20 Thread Jakub Hrozek
On 12/20/2010 09:02 PM, Simo Sorce wrote: On Mon, 20 Dec 2010 18:02:02 +0100 Jakub Hrozekjhro...@redhat.com wrote: On Wed, Dec 15, 2010 at 08:01:10PM -0500, Simo Sorce wrote: Clean up records related to the master being deleted in the shared tree. This also avoid issues later on if you

[Freeipa-devel] [PATCH]admiyo-0119-cusor-pointer-for-undo-link

2010-12-20 Thread Adam Young
From 14cefe3790baa167dba2b4fa6342bcb680abdea0 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 20 Dec 2010 16:56:14 -0500 Subject: [PATCH] cusor pointer for undo link --- install/static/details.js |2 +- install/static/ipa.css|4 2 files changed, 5

Re: [Freeipa-devel] [PATCH]admiyo-0119-cusor-pointer-for-undo-link

2010-12-20 Thread Adam Young
On 12/20/2010 04:57 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Graphical diff is here:

Re: [Freeipa-devel] [PATCH] 0032 Cleanup when deleting a replica

2010-12-20 Thread Simo Sorce
On Mon, 20 Dec 2010 22:40:50 +0100 Jakub Hrozek jhro...@redhat.com wrote: The rest of the code looks OK, but I'm currently not able to test as the deletion fails with Insufficient access. In my setup, vm-061 is the master and vm-038 is the replica: [r...@vm-061 ~]# ipa-replica-manage

Re: [Freeipa-devel] [PATCH] 024 Change FreeIPA license to GPLv3+

2010-12-20 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, attached is a patch that replaces all GPLv2 license blobs with GPLv3+ blobs. The new blobs also tell users to see a website for the complete license text (the old ones advised to write to a snail mail address..). The SLAPI

Re: [Freeipa-devel] [PATCH]admiyo-0119-cusor-pointer-for-undo-link

2010-12-20 Thread Simo Sorce
On Mon, 20 Dec 2010 16:58:49 -0500 Adam Young ayo...@redhat.com wrote: On 12/20/2010 04:57 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Graphical diff

[Freeipa-devel] [PATCH] 0037 Fix race condition in install

2010-12-20 Thread Simo Sorce
This seem to fix a long-standing bug that was mitigated by a workaround, but was still present after all. Simo. -- Simo Sorce * Red Hat, Inc * New York From 04777b8938d929e0464d3953cbfce76f243e04c8 Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Mon, 20 Dec 2010 21:19:36

Re: [Freeipa-devel] [PATCH]admiyo-0119-cusor-pointer-for-undo-link

2010-12-20 Thread Adam Young
On 12/20/2010 08:47 PM, Simo Sorce wrote: On Mon, 20 Dec 2010 16:58:49 -0500 Adam Youngayo...@redhat.com wrote: On 12/20/2010 04:57 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-0118-aci-ui

2010-12-20 Thread Rob Crittenden
Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ack. Adam, I'm going to let you push this. There were a couple of trivial merge errors but I figure you're best to

Re: [Freeipa-devel] [PATCH] 0037 Fix race condition in install

2010-12-20 Thread Adam Young
On 12/20/2010 09:23 PM, Simo Sorce wrote: This seem to fix a long-standing bug that was mitigated by a workaround, but was still present after all. Simo. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 657 fix a few ACI problems found

2010-12-20 Thread Rob Crittenden
This depends on Adam's patch 0118. In meta data make ACI attributes lower-case, sorted. Add possible attributes. The metadata contains a list of possible attributes that an ACI for that object might need. Add a new variable to hold possible objectclasses for optional elements (like

Re: [Freeipa-devel] [PATCH] admiyo-0118-aci-ui

2010-12-20 Thread Adam Young
On 12/20/2010 11:23 PM, Rob Crittenden wrote: Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ack. Adam, I'm going to let you push this. There were a couple of

[Freeipa-devel] Issues with ACI UI

2010-12-20 Thread Adam Young
1. Can't add an ACI. Before, I was able to get away with a blank filter, but that doesn't seem to work anymore. 2. Delegation-add : the group-find for the combo boxes isn't getting executed. 3. Some edits are broken for Permissions: For certain, update dns entries 4. adding self service

Re: [Freeipa-devel] [PATCH] 0037 Fix race condition in install

2010-12-20 Thread Adam Young
On 12/20/2010 11:31 PM, Adam Young wrote: On 12/20/2010 09:23 PM, Simo Sorce wrote: This seem to fix a long-standing bug that was mitigated by a workaround, but was still present after all. Simo. ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] 0038 Rework init and sync commands of ipa-replica-prepare

2010-12-20 Thread Simo Sorce
These commands had a very confusing syntax as well as issues (init was running the memberof task on the wrong server). The commands has been renamed to make it clearer what they do. init - re-initialize synch - force-sync both commands now require a --from hostname as the server they get their