Re: [Freeipa-devel] [PATCH] 033 Add new installer option for reverse zone creation

2011-01-07 Thread Simo Sorce
On Thu, 2011-01-06 at 19:43 +0100, Jakub Hrozek wrote: On reading the complete discussion (thanks for reminding me, Dmitri), we only flip the default for the reverse zone creation to True. Attached is a patch that has a --no-reverse option instead of --create-reverse and reverts the

Re: [Freeipa-devel] [PATCH] 0042 Fix dns install on replicas

2011-01-07 Thread Simo Sorce
On Thu, 2011-01-06 at 13:00 +0100, Jan Zelený wrote: Simo Sorce sso...@redhat.com wrote: DNS installation on replicas was broken. This patch fixes both the --setup-dns switch of ipa-replica-install as well as running ipa-dns-install on an existing replica. Simo. ack Pushed to

Re: [Freeipa-devel] [PATCH] 0043 fix ipa-dns-install to not require DM password

2011-01-07 Thread Simo Sorce
On Fri, 2011-01-07 at 10:44 +0100, Jan Zelený wrote: Simo Sorce sso...@redhat.com wrote: On Fri, 2011-01-07 at 09:53 +0100, Jan Zelený wrote: Simo Sorce sso...@redhat.com wrote: On Thu, 2011-01-06 at 10:35 +0100, Jan Zelený wrote: Simo Sorce sso...@redhat.com wrote: This patch

Re: [Freeipa-devel] [PATCH] 033 Add new installer option for reverse zone creation

2011-01-07 Thread Simo Sorce
On Fri, 2011-01-07 at 04:52 -0500, Simo Sorce wrote: On Thu, 2011-01-06 at 19:43 +0100, Jakub Hrozek wrote: On reading the complete discussion (thanks for reminding me, Dmitri), we only flip the default for the reverse zone creation to True. Attached is a patch that has a

Re: [Freeipa-devel] [PATCH] Rename --ipaddr option of host-add command

2011-01-07 Thread Simo Sorce
On Wed, 2011-01-05 at 12:21 -0500, Simo Sorce wrote: On Wed, 2011-01-05 at 16:44 +0100, Jan Zelený wrote: The option is renamed to --ip-address to be consistent with ipa-replica-prepare. https://fedorahosted.org/freeipa/ticket/655 ACK, Pushed to master. Simo.

[Freeipa-devel] [PATCH] Use of pointer after free in ipa-join

2011-01-07 Thread Martin Kosek
In some cases recently freed memory was used/freed again. This patch introduces more consistency between functions join_ldap/join_krb5 when dealing with affected variables. https://fedorahosted.org/freeipa/ticket/709 From 48cfd9c6c5e94d21cabacc9f1e81a59882931f8d Mon Sep 17 00:00:00 2001 From:

Re: [Freeipa-devel] [PATCH] Modified ipa help behavior

2011-01-07 Thread Rob Crittenden
Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: On 01/05/2011 11:55 AM, Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: Nack, the hbac-hbacrule rename is still not complete. There is still from ipalib.plugins.hbac import is_all in ipalib/plugins/netgroup.py and

[Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Jakub Hrozek
The attached patch fixes ticket #730 as well as a couple of typos in the module help. To test: $ ipa dnszone-add barzone.com --name-server ns.idm.lab.bos.redhat.com --admin-email ad...@idm.lab.bos.redhat.com (there must be an A or record for the nameserver) $ ipa dnsrecord-add barzone.com

Re: [Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Jakub Hrozek
On Fri, Jan 07, 2011 at 04:54:49PM +0100, Jakub Hrozek wrote: The attached patch fixes ticket #730 as well as a couple of typos in the module help. To test: $ ipa dnszone-add barzone.com --name-server ns.idm.lab.bos.redhat.com --admin-email ad...@idm.lab.bos.redhat.com (there must be an

[Freeipa-devel] [PATCH] one-liner

2011-01-07 Thread Rob Crittenden
While doing some aci debugging I noticed that the kdc wasn't allowed to write krbExtraData. I pushed a one-liner to allow that. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [Fwd: [PATCH] admiyo-0122-cancel-on-failure]

2011-01-07 Thread Adam Young
Withdrawn. It has been superceeded by a one liner. On 01/07/2011 05:12 AM, Simo Sorce wrote: This one looks unpushed, is it still valid ? Simo. Forwarded Message From: Adam Youngayo...@redhat.com To: freeipa-develfreeipa-devel@redhat.com Subject: [Freeipa-devel] [PATCH]

Re: [Freeipa-devel] [PATCH] Use of pointer after free in ipa-join

2011-01-07 Thread Adam Young
On 01/07/2011 09:21 AM, Martin Kosek wrote: In some cases recently freed memory was used/freed again. This patch introduces more consistency between functions join_ldap/join_krb5 when dealing with affected variables. https://fedorahosted.org/freeipa/ticket/709

Re: [Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Adam Young
I'm Not a pythonista. What is this line doing? On 01/07/2011 10:58 AM, Jakub Hrozek wrote: +nameserver = nameserver[-1] == '.' and nameserver or nameserver + '.' ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Jakub Hrozek
On 01/07/2011 05:28 PM, Adam Young wrote: I'm Not a pythonista. What is this line doing? On 01/07/2011 10:58 AM, Jakub Hrozek wrote: + nameserver = nameserver[-1] == '.' and nameserver or nameserver + '.' This construct is called the 'and-or trick' and somewhat resembles ternary operator

Re: [Freeipa-devel] [PATCH] 035 Fixes for the DNS plugin

2011-01-07 Thread Adam Young
On 01/07/2011 11:59 AM, Jakub Hrozek wrote: On 01/07/2011 05:28 PM, Adam Young wrote: I'm Not a pythonista. What is this line doing? On 01/07/2011 10:58 AM, Jakub Hrozek wrote: + nameserver = nameserver[-1] == '.' and nameserver or nameserver + '.' This construct is called the 'and-or

Re: [Freeipa-devel] [PATCH] Changed dns permission types

2011-01-07 Thread Adam Young
On 01/07/2011 12:05 PM, Jan Zelený wrote: Recent change of DNS module to version caused that dns object type was replaced by dnszone and dnsrecord. This patch corrects dns types in permissions class. https://fedorahosted.org/freeipa/ticket/646 ___

[Freeipa-devel] [PATCH] 667 display failures when deleting with --continue

2011-01-07 Thread Rob Crittenden
If you deleted a bunch of entries with --continue and some would fail you would get no notification of the ones that did. I had to change the return type of the baseldap LDAPDelete function to return a dict instead of a boolean. So now it returns a string of the failures. I also added a new

[Freeipa-devel] admiyo-0135-fix-entity-unit-tests

2011-01-07 Thread Adam Young
Minor unit test breakage due to a change in the action panel. From 42b894b733a275812e1f48fa210f334cb59a64e7 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 7 Jan 2011 13:00:30 -0500 Subject: [PATCH] fix entity unit tests unit tests updated to accoount for the facet_group

[Freeipa-devel] [PATCH] admiyo-0136-remove-permissions-checkbox

2011-01-07 Thread Adam Young
https://fedorahosted.org/freeipa/ticket/679 From 6deeca6ac4ddc8020cf7d014d718393fe168ba8f Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Fri, 7 Jan 2011 14:40:08 -0500 Subject: [PATCH] remove permissions checkbox self service defaults to write permission, the only acceptable

Re: [Freeipa-devel] [PATCH] 665 simple build instructions

2011-01-07 Thread Rob Crittenden
Jan Zelený wrote: Nack: I think using rpm -Uvh dist/rpms/* is not a good option. Using yum -- nogpgcheck localinstall dist/rpms/* is much better, because it also installs runtime dependencies, which might not be included by previous installation of build dependencies. One suggestion: I'd

Re: [Freeipa-devel] [PATCH] Fix 'ipa help permissions'; add 'dns' in allowed types.

2011-01-07 Thread Rob Crittenden
Adam Young wrote: On 12/30/2010 04:29 AM, Pavel Zůna wrote: Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK pushed to master

Re: [Freeipa-devel] [PATCH] Enable custom list of attributes to retrieve effective rights.

2011-01-07 Thread Rob Crittenden
Pavel Zůna wrote: LDAPObject sub-classes can define a custom list of attributes for effective rights retrieval. Fix #677 Pavel Nack. --rights should only return data when --all is also included. Otherwise it looks ok. rob ___ Freeipa-devel

[Freeipa-devel] [PATCH] fix installer issue

2011-01-07 Thread Rob Crittenden
The installation was failing during the KDC install with an error about being unable to connect to the LDAP server. I tracked this down to using SSL but I haven't yet figured out why (or where) it is breaking. I pushed this under the 1-liner rule. rob From

[Freeipa-devel] [PATCH] Fix SudoRule RunAs users/groups

2011-01-07 Thread JR Aquino
Attached is the patch to fix the following: (Per ticket 570: https://fedorahosted.org/freeipa/ticket/570 Issue #5) * Runas users to support groups * Runas users to support external users * runasgroup to support external groups * compat fix to account for the runas users to support %groups *

Re: [Freeipa-devel] [PATCH] admiyo-0134-Validate-add-dialog-text-fields

2011-01-07 Thread Endi Sukma Dewata
On 1/7/2011 11:15 PM, Adam Young wrote: While this does not solve https://fedorahosted.org/freeipa/ticket/470, it is a necessary precursor. ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] admiyo-0135-fix-entity-unit-tests

2011-01-07 Thread Endi Sukma Dewata
On 1/8/2011 1:05 AM, Adam Young wrote: Minor unit test breakage due to a change in the action panel. ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] admiyo-0136-remove-permissions-checkbox

2011-01-07 Thread Endi Sukma Dewata
On 1/8/2011 2:43 AM, Adam Young wrote: https://fedorahosted.org/freeipa/ticket/679 ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel