Re: [Freeipa-devel] [PATCH] 736 hard limit for # of batch requests

2011-02-22 Thread Martin Kosek
On Mon, 2011-02-21 at 11:48 -0500, Rob Crittenden wrote: Set a hard limit of 256 for the # of commands in a batch request we'll handle. ticket 984 rob ACK. Works for me. Tested by custom JSON command via curl. Martin ___ Freeipa-devel

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Jan Zeleny
Rob Crittenden rcrit...@redhat.com wrote: Move some BuildRequires so building with ONLY_CLIENT works. I tested with: $ mock -r fedora-14-x86_64 --define='ONLY_CLIENT 1' ./dist/srpms/freeipa-2.0.0GIT055a668-0.fc14.src.rpm rob I'm a little confused. Some of the lines are only moved a

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Jakub Hrozek
On Tue, Feb 22, 2011 at 10:34:35AM +0100, Jan Zeleny wrote: Rob Crittenden rcrit...@redhat.com wrote: Move some BuildRequires so building with ONLY_CLIENT works. I tested with: $ mock -r fedora-14-x86_64 --define='ONLY_CLIENT 1' ./dist/srpms/freeipa-2.0.0GIT055a668-0.fc14.src.rpm

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Jakub Hrozek
On Tue, Feb 22, 2011 at 11:21:41AM +0100, Jakub Hrozek wrote: Note the %else. Sorry, %endif. That separates BRs for !ONLY_CLIENT from those that are needed in both cases. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 061 Validate NAPTR records

2011-02-22 Thread Jakub Hrozek
On Mon, Feb 21, 2011 at 01:18:07PM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm not sure about checking the flags - this might be a little too much validation. https://fedorahosted.org/freeipa/ticket/840 I think the flags length

Re: [Freeipa-devel] [PATCH] 738 default.conf man page

2011-02-22 Thread Jakub Hrozek
On Mon, Feb 21, 2011 at 04:57:22PM -0500, Rob Crittenden wrote: Add a man page for the IPA configuration file default.conf. ticket 969 rob Looks good to me, Ack. The options that are in constants.py but not documented in the manpage seem to be unused. I guess we can remove them in the

Re: [Freeipa-devel] [PATCH] 735 configure krb5_realm in sssd ipa provider

2011-02-22 Thread Jakub Hrozek
On Mon, Feb 21, 2011 at 11:30:04AM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: On Mon, Feb 21, 2011 at 10:27:26AM -0500, Rob Crittenden wrote: Set krb5_realm in sssd.conf in the ipa provider. ticket 925 rob This works fine, so Ack. One question, though, why don't we add the

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Jan Zelený
Jakub Hrozek jhro...@redhat.com wrote: On Tue, Feb 22, 2011 at 11:21:41AM +0100, Jakub Hrozek wrote: Note the %else. Sorry, %endif. That separates BRs for !ONLY_CLIENT from those that are needed in both cases. Yes I noticed that and I understand that part. I meant the part after the

Re: [Freeipa-devel] [PATCH] 728 default roles

2011-02-22 Thread Jan Zelený
Rob Crittenden rcrit...@redhat.com wrote: Jakub Hrozek wrote: On Mon, Feb 21, 2011 at 10:11:38AM -0500, Rob Crittenden wrote: Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/17/2011 04:35 AM, Rob Crittenden wrote: Add default roles

Re: [Freeipa-devel] [PATCH] 728 default roles

2011-02-22 Thread Martin Kosek
On Tue, 2011-02-22 at 13:14 +0100, Jan Zelený wrote: Rob Crittenden rcrit...@redhat.com wrote: Jakub Hrozek wrote: On Mon, Feb 21, 2011 at 10:11:38AM -0500, Rob Crittenden wrote: Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On

Re: [Freeipa-devel] [PATCH] 738 default.conf man page

2011-02-22 Thread David O'Brien
Rob Crittenden wrote: Add a man page for the IPA configuration file default.conf. ticket 969 rob NACK A few too many typos and other errors. Spaces between the equals sign are ignored. Do you mean, Spaces surrounding equals signs are ignored.? +Specifies the base DN to use when performan

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Rob Crittenden
Jan Zelený wrote: Jakub Hrozekjhro...@redhat.com wrote: On Tue, Feb 22, 2011 at 11:21:41AM +0100, Jakub Hrozek wrote: Note the %else. Sorry, %endif. That separates BRs for !ONLY_CLIENT from those that are needed in both cases. Yes I noticed that and I understand that part. I meant the

Re: [Freeipa-devel] [PATCH] 735 configure krb5_realm in sssd ipa provider

2011-02-22 Thread Rob Crittenden
Jakub Hrozek wrote: On Mon, Feb 21, 2011 at 11:30:04AM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: On Mon, Feb 21, 2011 at 10:27:26AM -0500, Rob Crittenden wrote: Set krb5_realm in sssd.conf in the ipa provider. ticket 925 rob This works fine, so Ack. One question, though, why don't

Re: [Freeipa-devel] [PATCH] 737 move BuildRequires

2011-02-22 Thread Rob Crittenden
Jan Zeleny wrote: Rob Crittendenrcrit...@redhat.com wrote: Move some BuildRequires so building with ONLY_CLIENT works. I tested with: $ mock -r fedora-14-x86_64 --define='ONLY_CLIENT 1' ./dist/srpms/freeipa-2.0.0GIT055a668-0.fc14.src.rpm rob I'm a little confused. Some of the lines are

Re: [Freeipa-devel] [PATCH] 736 hard limit for # of batch requests

2011-02-22 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2011-02-21 at 11:48 -0500, Rob Crittenden wrote: Set a hard limit of 256 for the # of commands in a batch request we'll handle. ticket 984 rob ACK. Works for me. Tested by custom JSON command via curl. Martin pushed to master

Re: [Freeipa-devel] [PATCH] 061 Validate NAPTR records

2011-02-22 Thread Rob Crittenden
Jakub Hrozek wrote: On Mon, Feb 21, 2011 at 01:18:07PM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm not sure about checking the flags - this might be a little too much validation. https://fedorahosted.org/freeipa/ticket/840 I think the

Re: [Freeipa-devel] [PATCH] 738 default.conf man page

2011-02-22 Thread Rob Crittenden
David O'Brien wrote: Rob Crittenden wrote: Add a man page for the IPA configuration file default.conf. ticket 969 rob NACK A few too many typos and other errors. Spaces between the equals sign are ignored. Do you mean, Spaces surrounding equals signs are ignored.? +Specifies the base DN

Re: [Freeipa-devel] [PATCH] 728 default roles

2011-02-22 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-02-22 at 13:14 +0100, Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: Jakub Hrozek wrote: On Mon, Feb 21, 2011 at 10:11:38AM -0500, Rob Crittenden wrote: Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On

Re: [Freeipa-devel] [PATCH] 728 default roles

2011-02-22 Thread Martin Kosek
On Tue, 2011-02-22 at 09:22 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2011-02-22 at 13:14 +0100, Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: Jakub Hrozek wrote: On Mon, Feb 21, 2011 at 10:11:38AM -0500, Rob Crittenden wrote: Rob Crittenden wrote: Jakub

[Freeipa-devel] [PATCH] 034 Entitlements ACIs not visible to Permission plugin

2011-02-22 Thread Martin Kosek
This patch fixes Entitlements privileges and ACIs. There were missing descriptions or the ACIs could not be processed by Permissino plugin because of missing prefix. https://fedorahosted.org/freeipa/ticket/997 From 2b088549da0b3c8beb4451d09e337b1dfa8ee9ce Mon Sep 17 00:00:00 2001 From: Martin

Re: [Freeipa-devel] [PATCH] 034 Entitlements ACIs not visible to Permission plugin

2011-02-22 Thread Martin Kosek
On Tue, 2011-02-22 at 15:46 +0100, Martin Kosek wrote: This patch fixes Entitlements privileges and ACIs. There were missing descriptions or the ACIs could not be processed by Permissino plugin because of missing prefix. https://fedorahosted.org/freeipa/ticket/997 I just want to add that

Re: [Freeipa-devel] [PATCH] 728 default roles

2011-02-22 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-02-22 at 09:22 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2011-02-22 at 13:14 +0100, Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: Jakub Hrozek wrote: On Mon, Feb 21, 2011 at 10:11:38AM -0500, Rob Crittenden wrote: Rob

Re: [Freeipa-devel] [PATCH] 034 Entitlements ACIs not visible to Permission plugin

2011-02-22 Thread Rob Crittenden
Martin Kosek wrote: This patch fixes Entitlements privileges and ACIs. There were missing descriptions or the ACIs could not be processed by Permissino plugin because of missing prefix. https://fedorahosted.org/freeipa/ticket/997 ack, pushed to master

[Freeipa-devel] [PATCH] 112 I18n update for dialog box buttons.

2011-02-22 Thread Endi Sukma Dewata
https://fedorahosted.org/freeipa/ticket/899 -- Endi S. Dewata From b8881ccdd02965a70c0136ba66de2006b96379a9 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Mon, 21 Feb 2011 18:36:42 -0600 Subject: [PATCH] I18n update for dialog box buttons.

[Freeipa-devel] [PATCH] admiyo-0199-Net-group-to-Netgroup

2011-02-22 Thread Adam Young
From b0cb901f26834ba6e4e32d7d3a3ae10452de04e6 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Tue, 22 Feb 2011 11:35:25 -0500 Subject: [PATCH 199/203] Net group to Netgroup --- ipalib/plugins/netgroup.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Freeipa-devel] [PATCH] admiyo-0200-adder-dialogs-with-external

2011-02-22 Thread Adam Young
https://fedorahosted.org/freeipa/ticket/986 From c0af47af158ec9a30924f2571f8a1fef13c414ad Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Tue, 22 Feb 2011 12:58:26 -0500 Subject: [PATCH 200/203] adder dialogs with external made the styles for the internal and external classes

[Freeipa-devel] [PATCH] admiyo-0202-move-expand-and-collapse-all-to-the-right-hand-side

2011-02-22 Thread Adam Young
From ad998f2c36c48ae2bd9ea37cf10b755167b53bec Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Tue, 22 Feb 2011 13:09:14 -0500 Subject: [PATCH 202/203] move expand and collpase all to the right hand side --- install/ui/details.js |4 +++- install/ui/ipa.css|5 +

[Freeipa-devel] [PATCH] admiyo-0203-Space-above-line-in-table-footer.

2011-02-22 Thread Adam Young
From a32b182bf83fdf9aab71aec325628d5a589b3f87 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Tue, 22 Feb 2011 13:16:59 -0500 Subject: [PATCH 203/203] Space above line in table footer --- install/ui/ipa.css |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[Freeipa-devel] [PATCH] 739 update permission help text

2011-02-22 Thread Rob Crittenden
Based on feedback from David here is a hopefully clearer description of permissions. ticket 996 rob freeipa-rcrit-739-permission.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] Don't load the LDAP schema during startup

2011-02-22 Thread Jan Zelený
Rob Crittenden rcrit...@redhat.com wrote: Jan Zelený wrote: Loading of the schema is now performed in the first request that requires it. https://fedorahosted.org/freeipa/ticket/583 Jan We still need to enforce that we get the schema, some low-level functions depend on it. Also,

Re: [Freeipa-devel] [PATCH] 112 I18n update for dialog box buttons.

2011-02-22 Thread Adam Young
On 02/22/2011 12:28 PM, Endi Sukma Dewata wrote: https://fedorahosted.org/freeipa/ticket/899 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK. Pushed to master

Re: [Freeipa-devel] Localization patches.

2011-02-22 Thread Rob Crittenden
Pavel Zůna wrote: On 2011-02-17 22:52, Rob Crittenden wrote: Pavel Zůna wrote: On 2011-02-17 05:09, Rob Crittenden wrote: Pavel Zůna wrote: My efforts in fixing localization all around the framework and preparing it for localizing docstrings have resulted in a lot of patches. Because I

Re: [Freeipa-devel] [PATCH] admiyo-0199-Net-group-to-Netgroup

2011-02-22 Thread Endi Sukma Dewata
On 2/22/2011 12:20 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] admiyo-0203-Space-above-line-in-table-footer.

2011-02-22 Thread Endi Sukma Dewata
On 2/22/2011 12:23 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] admiyo-0201-reorder-user-search-columns

2011-02-22 Thread Endi Sukma Dewata
On 2/22/2011 12:22 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 739 update permission help text

2011-02-22 Thread Jakub Hrozek
On Tue, Feb 22, 2011 at 01:38:11PM -0500, Rob Crittenden wrote: Based on feedback from David here is a hopefully clearer description of permissions. ticket 996 rob I think you sent a wrong patch, this is the default.conf manpage one. ___

Re: [Freeipa-devel] [PATCH] Don't load the LDAP schema during startup

2011-02-22 Thread Rob Crittenden
Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: Jan Zelený wrote: Loading of the schema is now performed in the first request that requires it. https://fedorahosted.org/freeipa/ticket/583 Jan We still need to enforce that we get the schema, some low-level functions depend on

Re: [Freeipa-devel] [PATCH] 739 update permission help text

2011-02-22 Thread Rob Crittenden
Jakub Hrozek wrote: On Tue, Feb 22, 2011 at 01:38:11PM -0500, Rob Crittenden wrote: Based on feedback from David here is a hopefully clearer description of permissions. ticket 996 rob I think you sent a wrong patch, this is the default.conf manpage one. D'oh, here you go. rob

Re: [Freeipa-devel] [PATCH] 739 update permission help text

2011-02-22 Thread Jakub Hrozek
On Tue, Feb 22, 2011 at 03:24:01PM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: On Tue, Feb 22, 2011 at 01:38:11PM -0500, Rob Crittenden wrote: Based on feedback from David here is a hopefully clearer description of permissions. ticket 996 rob I think you sent a wrong patch, this

Re: [Freeipa-devel] Localization patches.

2011-02-22 Thread Jakub Hrozek
On Tue, Feb 22, 2011 at 02:16:01PM -0500, Rob Crittenden wrote: Pavel Zůna wrote: On 2011-02-17 22:52, Rob Crittenden wrote: Pavel Zůna wrote: On 2011-02-17 05:09, Rob Crittenden wrote: Pavel Zůna wrote: My efforts in fixing localization all around the framework and preparing it for

Re: [Freeipa-devel] [PATCH] 739 update permission help text

2011-02-22 Thread Rob Crittenden
Jakub Hrozek wrote: On Tue, Feb 22, 2011 at 03:24:01PM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: On Tue, Feb 22, 2011 at 01:38:11PM -0500, Rob Crittenden wrote: Based on feedback from David here is a hopefully clearer description of permissions. ticket 996 rob I think you sent a

[Freeipa-devel] [PATCH] admiyo-0204-split-logo

2011-02-22 Thread Adam Young
From b34ce11a9d9894edbb80fe4b2576f688249ff4a5 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Tue, 22 Feb 2011 16:46:33 -0500 Subject: [PATCH] split logo This allows for more flexilibity in customizing the site, as an end user can replace the logo, the banner or both ---

Re: [Freeipa-devel] [PATCH] admiyo-0204-split-logo

2011-02-22 Thread Endi Sukma Dewata
On 2/22/2011 3:48 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 113 Fixed buttons for DNS records.

2011-02-22 Thread Endi Sukma Dewata
The order of the Add and Delete buttons has been reversed to be consistent with those in other facets. -- Endi S. Dewata From 77070192fec42b64697f8456d1303b6bf722d082 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Tue, 22 Feb 2011 17:00:50 -0600 Subject: [PATCH] Fixed

Re: [Freeipa-devel] [PATCH] 738 default.conf man page

2011-02-22 Thread David O'Brien
Rob Crittenden wrote: David O'Brien wrote: Rob Crittenden wrote: Add a man page for the IPA configuration file default.conf. ticket 969 rob NACK A few too many typos and other errors. Spaces between the equals sign are ignored. Do you mean, Spaces surrounding equals signs are ignored.?

Re: [Freeipa-devel] [PATCH] 739 update permission help text

2011-02-22 Thread David O'Brien
Rob Crittenden wrote: Jakub Hrozek wrote: On Tue, Feb 22, 2011 at 03:24:01PM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: On Tue, Feb 22, 2011 at 01:38:11PM -0500, Rob Crittenden wrote: Based on feedback from David here is a hopefully clearer description of permissions. ticket 996 rob

[Freeipa-devel] [PATCH] 20 Create default disabled sudo bind user

2011-02-22 Thread JR Aquino
This patch addressees ticket #998 It adds: * ldif to create a default sudo bind user: dn: uid=sudo,cn=sysaccounts,cn=etc,$SUFFIX * modifications to dsinstance.py to add the ldif * modifications to dsinstance.py to add a call to ipautil.ipa_generate_password() for an random password. It is