Re: [Freeipa-devel] [PATCH] Don't load the LDAP schema during startup

2011-02-23 Thread Jan Zelený
Jan Zelený jzel...@redhat.com wrote: Rob Crittenden rcrit...@redhat.com wrote: Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: Jan Zelený wrote: Loading of the schema is now performed in the first request that requires it.

[Freeipa-devel] [PATCH] 065 Replace only if old and new have nothing in common

2011-02-23 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://fedorahosted.org/freeipa/ticket/1000 I hope this doesn't break anything..my testing went OK. I've seen some unit test failures (group tests, for instance), but they don't seem to be related. -BEGIN PGP SIGNATURE- Version: GnuPG

Re: [Freeipa-devel] [PATCH] 113 Fixed buttons for DNS records.

2011-02-23 Thread Adam Young
On 02/22/2011 06:18 PM, Endi Sukma Dewata wrote: The order of the Add and Delete buttons has been reversed to be consistent with those in other facets. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 113 Fixed buttons for DNS records.

2011-02-23 Thread Adam Young
On 02/22/2011 06:18 PM, Endi Sukma Dewata wrote: The order of the Add and Delete buttons has been reversed to be consistent with those in other facets. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] one liner to add new image for banner text.

2011-02-23 Thread Adam Young
pushed to master under the one line rule commit 49b2c0bb6203d23ff0c56945b447b7da8f2a3f84 Author: Adam Young ayo...@redhat.com Date: Wed Feb 23 11:23:16 2011 -0500 splitting banner requires new file in Makefile.am diff --git a/install/ui/Makefile.am b/install/ui/Makefile.am index

Re: [Freeipa-devel] [PATCH] 20 Create default disabled sudo bind user

2011-02-23 Thread JR Aquino
On 2/22/11 7:45 PM, JR Aquino jr.aqu...@citrix.com wrote: This patch addressees ticket #998 It adds: * ldif to create a default sudo bind user: dn: uid=sudo,cn=sysaccounts,cn=etc,$SUFFIX * modifications to dsinstance.py to add the ldif * modifications to dsinstance.py to add a call to

Re: [Freeipa-devel] [PATCH] 739 update permission help text

2011-02-23 Thread Rob Crittenden
David O'Brien wrote: Rob Crittenden wrote: Jakub Hrozek wrote: On Tue, Feb 22, 2011 at 03:24:01PM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: On Tue, Feb 22, 2011 at 01:38:11PM -0500, Rob Crittenden wrote: Based on feedback from David here is a hopefully clearer description of

Re: [Freeipa-devel] [PATCH] 738 default.conf man page

2011-02-23 Thread Rob Crittenden
David O'Brien wrote: Rob Crittenden wrote: David O'Brien wrote: Rob Crittenden wrote: Add a man page for the IPA configuration file default.conf. ticket 969 rob NACK A few too many typos and other errors. Spaces between the equals sign are ignored. Do you mean, Spaces surrounding

Re: [Freeipa-devel] [PATCH] 20 Create default disabled sudo bind user

2011-02-23 Thread Simo Sorce
On Wed, 23 Feb 2011 13:50:37 -0500 Rob Crittenden rcrit...@redhat.com wrote: JR Aquino wrote: On 2/22/11 7:45 PM, JR Aquinojr.aqu...@citrix.com wrote: This patch addressees ticket #998 It adds: * ldif to create a default sudo bind user: dn: uid=sudo,cn=sysaccounts,cn=etc,$SUFFIX

Re: [Freeipa-devel] Localization patches.

2011-02-23 Thread Rob Crittenden
Pavel Zůna wrote: Rebased patch 81 and 83 (pygettext). Created a new patch to fix these latest test failures - it was easier than doing a complex rebase. All latest versions of localization patches are attached to this email for review. I tried to apply them on a clean master clone, build

Re: [Freeipa-devel] [PATCH] 20 Create default disabled sudo bind user

2011-02-23 Thread JR Aquino
On 2/23/11 11:23 AM, Simo Sorce sso...@redhat.com wrote: On Wed, 23 Feb 2011 13:50:37 -0500 Rob Crittenden rcrit...@redhat.com wrote: JR Aquino wrote: On 2/22/11 7:45 PM, JR Aquinojr.aqu...@citrix.com wrote: This patch addressees ticket #998 It adds: * ldif to create a default

[Freeipa-devel] [PATCH] one-liner for krbtpolicy

2011-02-23 Thread Rob Crittenden
Pushed out this one-liner to fix a typo and add an example for when user ticket policy takes effect. diff --git a/ipalib/plugins/krbtpolicy.py b/ipalib/plugins/krbtpolicy.py index 22ef161..c9d86ea 100644 --- a/ipalib/plugins/krbtpolicy.py +++ b/ipalib/plugins/krbtpolicy.py @@ -30,8 +30,8 @@ is

[Freeipa-devel] [PATCH] 114 Save changes before modifying association.

2011-02-23 Thread Endi Sukma Dewata
In a details page, usually any changes done to the fields will not be applied until the user clicks the Update button. However, if the page contains an association table, any addition/deletion to the table will be applied immediately. To avoid any confusion, the user is now required to save or

[Freeipa-devel] [PATCH] 741 fix sudocmd membership

2011-02-23 Thread Rob Crittenden
We weren't searching the cn=sudo container so all members of a sudocmdgroup looked indirect. Add a label for sudo command groups. Update the tests to include verifying that membership is done properly. ticket 1003 rob freeipa-rcrit-741-sudocmd.patch Description: application/mbox

[Freeipa-devel] [PATCH] 742 Sudo command groups are not supposed to allow nesting

2011-02-23 Thread Rob Crittenden
It was a design decision to now allow nesting sudo command groups, remove it. ticket 1004 rob freeipa-rcrit-742-sudocmdgroup.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 742 Sudo command groups are not supposed to allow nesting

2011-02-23 Thread Dmitri Pal
On 02/23/2011 05:15 PM, Rob Crittenden wrote: It was a design decision to now allow nesting sudo command groups, remove it. *Not* allow, right? ticket 1004 rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 78 Use ldapi: instead of unsecured ldap: in ipa core tools.

2011-02-23 Thread Pavel Zůna
On 2011-02-15 16:36, JR Aquino wrote: On 2/15/11 6:52 AM, Simo Sorcesso...@redhat.com wrote: On Tue, 15 Feb 2011 15:19:50 +0100 Pavel Zunapz...@redhat.com wrote: I can't reproduce this. :-/ For me it goes fine: [root@ipadev tools]# ./ipa-nis-manage enable Directory Manager password:

Re: [Freeipa-devel] [PATCH] 742 Sudo command groups are not supposed to allow nesting

2011-02-23 Thread Rob Crittenden
Rob Crittenden wrote: It was a design decision to now allow nesting sudo command groups, remove it. ticket 1004 rob Updated patch attached. This is going to require an API change. rob freeipa-rcrit-742-2-sudocmdgroup.patch Description: application/mbox

Re: [Freeipa-devel] Localization patches.

2011-02-23 Thread Pavel Zůna
On 2011-02-23 20:26, Rob Crittenden wrote: Pavel Zůna wrote: Rebased patch 81 and 83 (pygettext). Created a new patch to fix these latest test failures - it was easier than doing a complex rebase. All latest versions of localization patches are attached to this email for review. I tried to

Re: [Freeipa-devel] [PATCH] 78 Use ldapi: instead of unsecured ldap: in ipa core tools.

2011-02-23 Thread Simo Sorce
On Wed, 23 Feb 2011 23:41:33 +0100 Pavel Zůna pz...@redhat.com wrote: On 2011-02-15 16:36, JR Aquino wrote: On 2/15/11 6:52 AM, Simo Sorcesso...@redhat.com wrote: On Tue, 15 Feb 2011 15:19:50 +0100 Pavel Zunapz...@redhat.com wrote: I can't reproduce this. :-/ For me it goes

[Freeipa-devel] [PATCH] 115 Fixed attribute for SUDO command group membership.

2011-02-23 Thread Endi Sukma Dewata
The correct attribute name for SUDO command group membership is memberof_sudocmdgroup and it contains the group name instead of dn. -- Endi S. Dewata From db1bb27fe8fd3f04ae976e2b0ab6444e033299d5 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Wed, 23 Feb 2011 17:15:42

Re: [Freeipa-devel] [PATCH] 742 Sudo command groups are not supposed to allow nesting

2011-02-23 Thread Endi Sukma Dewata
On 2/23/2011 4:50 PM, Rob Crittenden wrote: It was a design decision to now allow nesting sudo command groups, remove it. ticket 1004 Updated patch attached. This is going to require an API change. ACK and pushed to master. -- Endi S. Dewata ___