Re: [Freeipa-devel] [PATCH] 045 Add DNS record modification command

2011-03-31 Thread Martin Kosek
On Wed, 2011-03-30 at 16:52 -0400, Adam Young wrote: On 03/30/2011 11:13 AM, Martin Kosek wrote: Since this is a new-feature type patch it should be pushed only to master. --- The DNS record plugin does not support modification of a record. One can only add A type addresses to a DNS

Re: [Freeipa-devel] [PATCH] admiyo-0217-define-entities-using-builder-and-more-declarative

2011-03-31 Thread Martin Kosek
On Wed, 2011-03-30 at 12:40 -0400, Adam Young wrote: On 03/28/2011 05:17 PM, Adam Young wrote: On 03/28/2011 04:56 PM, Adam Young wrote: To give a little more context: we are llong to split out the logic used to define the views of the entities from the reusable portion of the

Re: [Freeipa-devel] [PATCH] 759 cache get_ipa_config() output in request context

2011-03-31 Thread Martin Kosek
On Wed, 2011-03-30 at 10:23 -0400, Rob Crittenden wrote: Some requests generate multiple calls to get_ipa_config(). This patch caches the return value for this in the request context. ticket 1023 rob ACK. Tested with user mail config attribute ipadefaultemaildomain. Martin

Re: [Freeipa-devel] [PATCH] 760 don't crash when calculating indirect

2011-03-31 Thread Martin Kosek
On Wed, 2011-03-30 at 10:46 -0400, Rob Crittenden wrote: Rob Crittenden wrote: This prevents an internal error when calculating direct vs indirect membership. ticket 1133 I accidentally included a change from another patch. Updated patch attached. rob I think it is OK. But I

Re: [Freeipa-devel] [PATCH] 761 Sort entries on *-find commands

2011-03-31 Thread Martin Kosek
On Wed, 2011-03-30 at 17:14 -0400, Rob Crittenden wrote: Sort output on find commands based on the baseldap LDAPSearch class. A couple tests had to be modified to match the new order. ticket 794 rob The patch works fine except the case when entries are being added in post_callback.

Re: [Freeipa-devel] [PATCH] admiyo-0217-define-entities-using-builder-and-more-declarative

2011-03-31 Thread Endi Sukma Dewata
On 3/31/2011 8:43 AM, Adam Young wrote: rebased both patches I don't see any code change in the rebased patches, only new commit ID's, I hope this is correct. Some comments (some of which had been discussed over IRC): 1. I ran my Selenium test cases against 215, 216, and 217 together,

Re: [Freeipa-devel] [PATCH] 759 cache get_ipa_config() output in request context

2011-03-31 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2011-03-30 at 10:23 -0400, Rob Crittenden wrote: Some requests generate multiple calls to get_ipa_config(). This patch caches the return value for this in the request context. ticket 1023 rob ACK. Tested with user mail config attribute ipadefaultemaildomain.

Re: [Freeipa-devel] [PATCH] admiyo-0217-define-entities-using-builder-and-more-declarative

2011-03-31 Thread Adam Young
On 03/31/2011 12:51 PM, Endi Sukma Dewata wrote: On 3/31/2011 8:43 AM, Adam Young wrote: rebased both patches I don't see any code change in the rebased patches, only new commit ID's, I hope this is correct. Some comments (some of which had been discussed over IRC): 1. I ran my Selenium

Re: [Freeipa-devel] [PATCH] admiyo-0217-define-entities-using-builder-and-more-declarative

2011-03-31 Thread Adam Young
On 03/31/2011 03:12 PM, Adam Young wrote: On 03/31/2011 02:09 PM, Adam Young wrote: On 03/31/2011 12:51 PM, Endi Sukma Dewata wrote: On 3/31/2011 8:43 AM, Adam Young wrote: rebased both patches I don't see any code change in the rebased patches, only new commit ID's, I hope this is

Re: [Freeipa-devel] [PATCH] 5 Add note about ipa-dns-install to ipa-server-install man page

2011-03-31 Thread Rob Crittenden
David O'Brien wrote: Jan Cholasta wrote: On 30.3.2011 01:01, David O'Brien wrote: Jan Cholasta wrote: Added the note so that users know that they can setup DNS at any time after ipa-server-install. https://fedorahosted.org/freeipa/ticket/1082

Re: [Freeipa-devel] [PATCH] 23 Optimize and dynamically verify group membership

2011-03-31 Thread JR Aquino
Better formatting for the statistics: -=- Without patch ipa hostgroup-find ... - Number of entries returned 52 - real0m20.054s user0m0.934s sys 0m0.050s -=- With

Re: [Freeipa-devel] [PATCH] 23 Optimize and dynamically verify group membership

2011-03-31 Thread Rob Crittenden
JR Aquino wrote: The following patch Removes around 20 lines of code and provides a substantial increase in performance for FreeIPA member/memberof verification searches. The current code base blindly searches static containers for the possible presence of members. This patch provides a

Re: [Freeipa-devel] [PATCH] 23 Optimize and dynamically verify group membership

2011-03-31 Thread JR Aquino
On Mar 31, 2011, at 1:48 PM, Rob Crittenden wrote: JR Aquino wrote: The following patch Removes around 20 lines of code and provides a substantial increase in performance for FreeIPA member/memberof verification searches. The current code base blindly searches static containers for the

Re: [Freeipa-devel] [PATCH] admiyo-0217-define-entities-using-builder-and-more-declarative

2011-03-31 Thread Adam Young
On 03/31/2011 04:29 PM, Adam Young wrote: On 03/31/2011 03:27 PM, Adam Young wrote: On 03/31/2011 03:12 PM, Adam Young wrote: On 03/31/2011 02:09 PM, Adam Young wrote: On 03/31/2011 12:51 PM, Endi Sukma Dewata wrote: On 3/31/2011 8:43 AM, Adam Young wrote: rebased both patches I don't see

Re: [Freeipa-devel] [PATCH] admiyo-0218-default-all-false.

2011-03-31 Thread Adam Young
On 03/30/2011 09:11 PM, Adam Young wrote: Requires patch 217 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel rebased, ACKed in IRC and pushed to master

Re: [Freeipa-devel] [PATCH] admiyo-0215-Fixed-labels-for-sudo-and-hbac-rules

2011-03-31 Thread Adam Young
On 03/29/2011 05:10 AM, Martin Kosek wrote: On Mon, 2011-03-28 at 16:49 -0400, Adam Young wrote: Putting these two patches togetehr because the first changes labels from the server, and the second is only for test data. The second is a separate patch becasue there are other changes from older

Re: [Freeipa-devel] [PATCH] 23 Optimize and dynamically verify group membership

2011-03-31 Thread JR Aquino
To clarify, the high delay times in these stats are due to buffered logging being turned off. The ratio of performance increase is ~the same with buffered logging turned on; e.g 1.9 seconds down to 1.5 On Mar 31, 2011, at 1:43 PM, JR Aquino jr.aqu...@citrix.com wrote: Better formatting for

Re: [Freeipa-devel] [PATCH] Initial Selenium test cases.

2011-03-31 Thread Adam Young
On 03/31/2011 02:09 PM, Endi Sukma Dewata wrote: On 3/31/2011 12:06 PM, Endi Sukma Dewata wrote: http://www.freeipa.org/page/Selenium Patch included. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com