Re: [Freeipa-devel] [PATCH] 1 Convert boolean to TRUE/FALSE when writing to LDAP

2011-06-27 Thread Simo Sorce
On Mon, 2011-06-27 at 15:50 +0300, Alexander Bokovoy wrote: Hi, my first patch :) -- attempts to fix https://fedorahosted.org/freeipa/ticket/1259 Minor difference for IPA is that IPA command line tools are now reporting nsAccountLock in upper case (TRUE/FALSE instead of True/False

[Freeipa-devel] [PATCH] 0002 Minor typos in examples

2011-06-27 Thread Alexander Bokovoy
Hi, while reading through the code and examples, few typos were identified and fixed. Really minor patch. -- / Alexander Bokovoy From 178f2da439d1cc1299bb79bf563019ce4877804f Mon Sep 17 00:00:00 2001 From: Alexander Bokovoy aboko...@redhat.com Date: Mon, 27 Jun 2011 14:58:52 +0300 Subject:

[Freeipa-devel] [PATCH] winsync enables disabled users in AD

2011-06-27 Thread Rich Megginson
From ad129b4b2e3fac09b997b52178ceee400c8894ac Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Fri, 24 Jun 2011 19:38:13 -0600 Subject: [PATCH 1/3] winsync enables disabled users in AD https://fedorahosted.org/freeipa/ticket/1379 winsync enables disabled users in AD when

[Freeipa-devel] [PATCH] modify user deleted in AD crashes winsync

2011-06-27 Thread Rich Megginson
From 258323b6f0eb8342aba1cd08d5abadfcb8547aa2 Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Fri, 24 Jun 2011 19:42:47 -0600 Subject: [PATCH 2/3] modify user deleted in AD crashes winsync https://fedorahosted.org/freeipa/ticket/1382 crash in winsync if replaying a MOD

[Freeipa-devel] [PATCH] memory leak in ipa_winsync_get_new_ds_user_dn_cb

2011-06-27 Thread Rich Megginson
From a8e83da54c5db48af93c369597c31673578f294a Mon Sep 17 00:00:00 2001 From: Rich Megginson rmegg...@redhat.com Date: Fri, 24 Jun 2011 19:44:05 -0600 Subject: [PATCH 3/3] memory leak in ipa_winsync_get_new_ds_user_dn_cb The new_dn_string passed into this function is malloc'd. It must be freed

Re: [Freeipa-devel] [PATCH] 33 oneliner correct typo in ipasudorunas_group

2011-06-27 Thread Rob Crittenden
Adam Young wrote: On 06/24/2011 05:27 PM, JR Aquino wrote: https://fedorahosted.org/freeipa/ticket/1326 In case I haven't sent this out before. ~ Jr Aquino, GCIH | Information Security Specialist Citrix Online | 7408 Hollister Avenue | Goleta, CA 93117 T: +1

[Freeipa-devel] One liner to fix permissions-add page

2011-06-27 Thread Adam Young
1. diff --git a/install/ui/aci.js b/install/ui/aci.js 2. index 077cbeb..1a95af0 100644 3. --- a/install/ui/aci.js 4. +++ b/install/ui/aci.js 5. @@ -393,6 +393,7 @@ IPA.target_section = function(spec) { 6. spec = spec || {}; 7. 8. var that =

[Freeipa-devel] [PATCH] 809 entitle_register using uuid unsupported

2011-06-27 Thread Rob Crittenden
Document registering to an entitlement server with a UUID as not implemented. It was my understanding that we would be able to pass in an existing UUID when registering to connect to an existing registration (for the case where IPA is re-installed). This is supported in the REST API but not

Re: [Freeipa-devel] [PATCH] 0249-optional-uid.

2011-06-27 Thread Adam Young
On 06/24/2011 03:09 PM, Endi Sukma Dewata wrote: On 6/24/2011 1:26 PM, Adam Young wrote: The old code on dialog.js:325-331 can be removed. It would be nice to set the focus to the input field automatically once you 'click to show'. But this might require adding focus() to all widgets.

[Freeipa-devel] [PATCH] 0253-validate-required-fields

2011-06-27 Thread Adam Young
From e4d2a842be230516aaebff0ec34ee1707b3fcd03 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 27 Jun 2011 15:57:40 -0400 Subject: [PATCH] validate required fields https://fedorahosted.org/freeipa/ticket/1329 overides required with optional. --- install/ui/add.js|

Re: [Freeipa-devel] [PATCH] 0244-service-host-entity-select

2011-06-27 Thread Adam Young
On 06/18/2011 09:26 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK and pushed to master ___ Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] 0253-validate-required-fields

2011-06-27 Thread Endi Sukma Dewata
On 6/27/2011 3:58 PM, Adam Young wrote: Since the optional attribute is now added into IPA.widget, the following line on dialog.js:347 is no longer needed: field.optional = field_spec.optional || false; Other than that it's ACKed. -- Endi S. Dewata

[Freeipa-devel] [PATCH] 192 Fixed undo all problem.

2011-06-27 Thread Endi Sukma Dewata
The IPA.multivalued_text_widget has been modified such that the 'undo all' will appear only if at least one of the values is dirty. Ticket #1109 -- Endi S. Dewata From 4b53e340d94465a87077c93852731e2f72d6ad95 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Mon, 27 Jun

Re: [Freeipa-devel] 0245-entity-select-undo

2011-06-27 Thread Adam Young
On 06/20/2011 01:34 PM, Endi Sukma Dewata wrote: On 6/18/2011 8:46 PM, Adam Young wrote: ACK and pushed to master. The set_dirty() invocation in reset() is no longer needed. This can be fixed later. Pushed to master ___ Freeipa-devel mailing

Re: [Freeipa-devel] 0241-enforce-proper-capitalization-with-stylesheet.

2011-06-27 Thread Adam Young
Have not pushed this yet. SHould I considere it ACKed and push it, or should we re-think it? On 06/17/2011 07:48 PM, Adam Young wrote: THis is how hyphenation is supposed to work. We should remove the hyphenation in the cases that you have enumerated below. The capitailzationg of Days

Re: [Freeipa-devel] [PATCH] admiyo-0220-update-ipa-init

2011-06-27 Thread Adam Young
On 04/01/2011 11:58 AM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACKed by edewata and Pushed to master ___

Re: [Freeipa-devel] [PATCH] 0253-validate-required-fields

2011-06-27 Thread Adam Young
On 06/27/2011 07:40 PM, Endi Sukma Dewata wrote: On 6/27/2011 3:58 PM, Adam Young wrote: Since the optional attribute is now added into IPA.widget, the following line on dialog.js:347 is no longer needed: field.optional = field_spec.optional || false; Other than that it's ACKed.

Re: [Freeipa-devel] [PATCH] 192 Fixed undo all problem.

2011-06-27 Thread Adam Young
On 06/27/2011 07:42 PM, Endi Sukma Dewata wrote: The IPA.multivalued_text_widget has been modified such that the 'undo all' will appear only if at least one of the values is dirty. Ticket #1109 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 0244-service-host-entity-select

2011-06-27 Thread Simo Sorce
On Mon, 2011-06-27 at 17:43 -0400, Adam Young wrote: On 06/18/2011 09:26 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK and pushed to master