Re: [Freeipa-devel] [PATCH 31/31] Ticket 1485 - DN pairwise grouping

2011-07-21 Thread Martin Kosek
On Wed, 2011-07-20 at 19:59 -0400, John Dennis wrote: The pairwise grouping used to form RDN's and AVA's proved to be confusing in practice, this patch removes that functionality thus requiring programmers to explicitly pair attr,value using a tuple or list. In addition it was discovered

Re: [Freeipa-devel] [PATCH] 067 Silence a compilation warning in ipa_kpasswd

2011-07-21 Thread Jan Cholasta
On 20.7.2011 17:10, Jakub Hrozek wrote: I was playing with ipa_kpasswd (long story short - I needed it running on a non-standard port) and I noticed there was a compilation warning - rtag was set but never checked. Also removes one unused #define. Found just a minor issue: you use spaces for

Re: [Freeipa-devel] [PATCH] 067 Silence a compilation warning in ipa_kpasswd

2011-07-21 Thread Martin Kosek
On Thu, 2011-07-21 at 14:40 +0200, Jan Cholasta wrote: On 20.7.2011 17:10, Jakub Hrozek wrote: I was playing with ipa_kpasswd (long story short - I needed it running on a non-standard port) and I noticed there was a compilation warning - rtag was set but never checked. Also removes one

[Freeipa-devel] [PATCH] 214 Fixed problem loading data in HBAC/sudo details page.

2011-07-21 Thread Endi Sukma Dewata
In a recent change the details page was changed to create and locate field containers with 'details-field' CSS class. The HBAC and sudo custom details pages have been modified to use the same CSS class. Ticket #1508 -- Endi S. Dewata ___

Re: [Freeipa-devel] [PATCH] 34 Create FreeIPA CLI Plugin for the 389 Auto Membership plugin

2011-07-21 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2011-07-21 at 03:37 +, JR Aquino wrote: Rob, I'm afraid I believe that ldap lookup is necessary. The user inputs a standard string to represent the possible host group… If i simply perform a get_dn it will indeed provide a dn, however, it won't verify that the

[Freeipa-devel] [PATCH] 215 Removed HBAC access time code.

2011-07-21 Thread Endi Sukma Dewata
The HBAC access time is currently not supported, so the related UI code has been removed to reduce maintenance issue. When the feature becomes supported in the future the code may be restored/rewritten. Ticket #546 -- Endi S. Dewata From 4ae2161ee45bc1749deccb13f0eedb1fb40a32cd Mon Sep 17

Re: [Freeipa-devel] [PATCH] 213 Removed entitlement registration UUID field.

2011-07-21 Thread Adam Young
On 07/21/2011 12:13 AM, Endi Sukma Dewata wrote: The UUID field has been removed from the entitlement registration dialog box because it's currently not supported. The code has been modified not to send empty UUID value should this become supported in the future. Ticket #1506

Re: [Freeipa-devel] [PATCH] Adding message summary while adding and deleting automount location.

2011-07-21 Thread Martin Kosek
On Thu, 2011-07-21 at 18:52 +0530, Gowrishankar Rajaiyan wrote: Hi All, This patch fixes - https://fedorahosted.org/freeipa/ticket/1510 - https://fedorahosted.org/freeipa/ticket/1509 QEs sending patches for the bugs they found - good job there. I went one step further and

[Freeipa-devel] [PATCH] 33 Fix ipa-compat-manage

2011-07-21 Thread Jan Cholasta
Make ipa-compat-manage work again after the changes to ipa-nis-manage I've done in patch 32. (this also fixes https://fedorahosted.org/freeipa/ticket/1147) Honza -- Jan Cholasta From 007a87ca336a6d8cfcf032724f1ab9dda286964e Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date:

Re: [Freeipa-devel] [PATCH] 213 Removed entitlement registration UUID field.

2011-07-21 Thread Endi Sukma Dewata
On 7/21/2011 9:47 AM, Adam Young wrote: Close to ACK, but: Either remove all of the references to the field, or comment them out. Suggest going the commented out route. Also, leave the commas inside the commented out code, so that you can just remove the comment and the code will be valid, even

Re: [Freeipa-devel] [PATCH] 34 Create FreeIPA CLI Plugin for the 389 Auto Membership plugin

2011-07-21 Thread Martin Kosek
On Thu, 2011-07-21 at 10:31 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2011-07-21 at 03:37 +, JR Aquino wrote: Rob, I'm afraid I believe that ldap lookup is necessary. The user inputs a standard string to represent the possible host group… If i simply perform a get_dn

Re: [Freeipa-devel] [PATCH] 215 Removed HBAC access time code.

2011-07-21 Thread Adam Young
On 07/21/2011 10:34 AM, Endi Sukma Dewata wrote: The HBAC access time is currently not supported, so the related UI code has been removed to reduce maintenance issue. When the feature becomes supported in the future the code may be restored/rewritten. Ticket #546

Re: [Freeipa-devel] [PATCH] 34 Create FreeIPA CLI Plugin for the 389 Auto Membership plugin

2011-07-21 Thread JR Aquino
On Jul 21, 2011, at 7:31 AM, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2011-07-21 at 03:37 +, JR Aquino wrote: Rob, I'm afraid I believe that ldap lookup is necessary. The user inputs a standard string to represent the possible host group… If i simply perform a get_dn it will

Re: [Freeipa-devel] [PATCH 31/31] Ticket 1485 - DN pairwise grouping

2011-07-21 Thread John Dennis
On 07/21/2011 08:27 AM, Martin Kosek wrote: On Wed, 2011-07-20 at 19:59 -0400, John Dennis wrote: The pairwise grouping used to form RDN's and AVA's proved to be confusing in practice, this patch removes that functionality thus requiring programmers to explicitly pair attr,value using a tuple

[Freeipa-devel] Proposal for Auto Membership plugin

2011-07-21 Thread Rob Crittenden
To summarize, I think this is how we will proceed. Create a new plugin, automember, based heavily on the work already done. The container_dn will be cn=automember,cn=etc. If automembership is preferred I can be flexible but using the same name everywhere makes things easy to follow. The DN

Re: [Freeipa-devel] [PATCH] Adding message summary while adding and deleting automount location.

2011-07-21 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2011-07-21 at 18:52 +0530, Gowrishankar Rajaiyan wrote: Hi All, This patch fixes - https://fedorahosted.org/freeipa/ticket/1510 - https://fedorahosted.org/freeipa/ticket/1509 QEs sending patches for the bugs they found - good job there. I went one

Re: [Freeipa-devel] [PATCH] 066 Remove wrong kpasswd sysconfig

2011-07-21 Thread Rob Crittenden
Jan Cholasta wrote: On 20.7.2011 17:09, Jakub Hrozek wrote: I noticed that the file kpasswd init script reads is called /etc/sysconfig/ipa-kpasswd but krbinstance.py saved and wrote into /etc/sysconfig/ipa_kpasswd. I removed the linkes rather than fixing them for two reasons: 1)

Re: [Freeipa-devel] [PATCH] 834 Hide the HBAC access type attribute now that deny is deprecated.

2011-07-21 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-07-19 at 20:49 -0400, Rob Crittenden wrote: Hide the HBAC access type attribute now that deny is deprecated. It won't appear in the UI/CLI but is still available via XML-RPC. allow is the default and deny will be rejected. This is not tested in the UI. I'm not

[Freeipa-devel] [PATCH] 836 Don't check for leading/trailing spaces on cert

2011-07-21 Thread Rob Crittenden
Don't check for leading/trailing spaces when loading an entitlement cert ticket https://fedorahosted.org/freeipa/ticket/1505 From 67e91eda119389a10161838dd446aa20b0c43eae Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Thu, 21 Jul 2011 11:14:10 -0400 Subject: [PATCH]

Re: [Freeipa-devel] [PATCH] 836 Don't check for leading/trailing spaces on cert

2011-07-21 Thread Rob Crittenden
Rob Crittenden wrote: Don't check for leading/trailing spaces when loading an entitlement cert ticket https://fedorahosted.org/freeipa/ticket/1505 With API.txt update, doesn't affect wire protocol. From cc125874a54e4db66136817eb2a92f15be90d344 Mon Sep 17 00:00:00 2001 From: Rob Crittenden

[Freeipa-devel] [PATCH] 837 autofill default revocation reason

2011-07-21 Thread Rob Crittenden
The default revocation reason wasn't autofilling so trying to retrieve it when it wasn't set caused things to blow up. ticket https://fedorahosted.org/freeipa/ticket/1514 From ea00b59d3c3ae61cd60d24120a9b9cbe5baa41c6 Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Thu,

Re: [Freeipa-devel] [PATCH] Adding message summary while adding and deleting automount location.

2011-07-21 Thread Jenny Galipeau
Great Job Shanks!! - Original Message - On Thu, 2011-07-21 at 18:52 +0530, Gowrishankar Rajaiyan wrote: Hi All, This patch fixes - https://fedorahosted.org/freeipa/ticket/1510 - https://fedorahosted.org/freeipa/ticket/1509 QEs sending patches for the bugs they found

[Freeipa-devel] [PATCH] 38 Move Managed Entries into their own container in the replicated space.

2011-07-21 Thread JR Aquino
Create: cn=Managed Entries,cn=etc,$SUFFIX Create: cn=Definitions,cn=Managed Entries,cn=etc,$SUFFIX Create: cn=Templates,cn=Managed Entries,cn=etc,$SUFFIX Create method for migrating any and all custom Managed Entries from the cn=config space into the new container. The Managed Entries plugin

Re: [Freeipa-devel] [PATCH] 25 Create Tool for Enabling Disabling Managed Entry

2011-07-21 Thread JR Aquino
On Apr 25, 2011, at 9:00 AM, Simo Sorce wrote: On Mon, 2011-04-25 at 14:59 +, JR Aquino wrote: On Apr 25, 2011, at 6:43 AM, Simo Sorce wrote: On Thu, 2011-04-21 at 23:28 +, JR Aquino wrote: Hmmm Both Private Groups and the Hostgroup - Netgroup Managed Entries create objects in the

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-21 Thread Adam Young
On 07/20/2011 11:11 PM, Endi Sukma Dewata wrote: On 7/20/2011 9:18 PM, Adam Young wrote: 8. Triggering a stack trace by calling null function probably will only work with Firebug, normal users will not get any notification about the error. This happens in dialog.js:301 and widget.js:1137.

[Freeipa-devel] [PATCH] 0273-fix-navigation

2011-07-21 Thread Adam Young
This is a portion of patch 0270, with just the navigation changes. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0273-fix-navigation

2011-07-21 Thread Adam Young
On 07/21/2011 11:34 PM, Adam Young wrote: This is a portion of patch 0270, with just the navigation changes. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel From