Re: [Freeipa-devel] [PATCH 40/40] ticket 1659 - invalid i18n string in dns.py

2011-08-18 Thread Alexander Bokovoy
On 18.08.2011 01:54, John Dennis wrote: > dns.py at line 976 has an invalid i18n string and cannot be processed > during message extraction causing message catalog generation to fail. > > The format parameters are trapped inside the i18n string. Also it's > not necessary to promote the i18n string

Re: [Freeipa-devel] [PATCH 41/41] ticket 1660 - update LINGUAS file, add missing po files

2011-08-18 Thread Alexander Bokovoy
On 18.08.2011 02:40, John Dennis wrote: > Our LINGUAS file and the set of po files have diverged from what's on > Transifex. We should update the LINGUAS file to match the set of > translations on Transifex and add po files currently on Transifex but > not in our git repo to our git repo. ACK as qu

Re: [Freeipa-devel] [PATCH 42/42] ticket 1661 - Update all po files

2011-08-18 Thread Alexander Bokovoy
On 18.08.2011 03:56, John Dennis wrote: > After updating po's current translation status is: > > ipa.pot has 1329 messages. There are 21 po translation files. > as: 0/1329 0.0% 1329 untranslated, 0 fuzzy > bn_IN: 13/1329 1.0% 1316 untranslated, 0 fuzzy > zh_CN: 133/

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-18 Thread Petr Vobornik
On 08/17/2011 05:38 PM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be only a checking if approach of this patch is good.

Re: [Freeipa-devel] [PATCH 42/42] ticket 1661 - Update all po files

2011-08-18 Thread Martin Kosek
On Thu, 2011-08-18 at 10:47 +0300, Alexander Bokovoy wrote: > On 18.08.2011 03:56, John Dennis wrote: > > After updating po's current translation status is: > > > > ipa.pot has 1329 messages. There are 21 po translation files. > > as: 0/1329 0.0% 1329 untranslated, 0 fuzzy > > bn_I

Re: [Freeipa-devel] [PATCH 41/41] ticket 1660 - update LINGUAS file, add missing po files

2011-08-18 Thread Martin Kosek
On Thu, 2011-08-18 at 10:45 +0300, Alexander Bokovoy wrote: > On 18.08.2011 02:40, John Dennis wrote: > > Our LINGUAS file and the set of po files have diverged from what's on > > Transifex. We should update the LINGUAS file to match the set of > > translations on Transifex and add po files current

Re: [Freeipa-devel] [PATCH 40/40] ticket 1659 - invalid i18n string in dns.py

2011-08-18 Thread Martin Kosek
On Thu, 2011-08-18 at 10:43 +0300, Alexander Bokovoy wrote: > On 18.08.2011 01:54, John Dennis wrote: > > dns.py at line 976 has an invalid i18n string and cannot be processed > > during message extraction causing message catalog generation to fail. > > > > The format parameters are trapped inside

Re: [Freeipa-devel] [PATCH 39/39] ticket 1650 - compute accurate translation statistics

2011-08-18 Thread Alexander Bokovoy
On 18.08.2011 01:35, John Dennis wrote: > ticket 1650 (https://fedorahosted.org/freeipa/ticket/1650) has > an extensive discussion of the issues, please refer to that. > > This patch does the following: > > * does not count fuzzy translations when computing translation > statistics via the "msg

Re: [Freeipa-devel] [PATCH 39/39] ticket 1650 - compute accurate translation statistics

2011-08-18 Thread Martin Kosek
On Thu, 2011-08-18 at 15:00 +0300, Alexander Bokovoy wrote: > On 18.08.2011 01:35, John Dennis wrote: > > ticket 1650 (https://fedorahosted.org/freeipa/ticket/1650) has > > an extensive discussion of the issues, please refer to that. > > > > This patch does the following: > > > > * does not count

Re: [Freeipa-devel] [PATCH] 40 Add option to ipa-server-install to disable the automatic redirect to the Web UI

2011-08-18 Thread Jan Cholasta
On 17.8.2011 16:39, Rob Crittenden wrote: Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1570 The help message might need some tweaking. Honza NACK. Whatever solution we come up with needs to apply to replicas as well. Ideally it would be automatic. Since this is a bit of a corn

[Freeipa-devel] [PATCH] 006 Uncheck checkboxes in association after deletion

2011-08-18 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1639 - added unchecking all checkboxes of table_widget and its derivates to on_load method. line '$('input[name=select]', that.tbody).attr('checked', false);' can be unnecessary because load method is recreating all rows in table. But I sense, it could

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-18 Thread Petr Vobornik
On 08/18/2011 10:28 AM, Petr Vobornik wrote: On 08/17/2011 05:38 PM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be only a

[Freeipa-devel] [PATCH] 249 Removed 'Hide already enrolled' checkbox.

2011-08-18 Thread Endi Sukma Dewata
The 'Hide already enrolled' has been removed from the enrollment dialog because it is checked by default and entries that are already enrolled cannot be enrolled again. Ticket #1638 -- Endi S. Dewata From 7ab8bb1bb641c1b140e7662ecd4bf9aa74f75ef2 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Dat

Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-18 Thread Simo Sorce
On Tue, 2011-08-16 at 16:13 -0500, Endi Sukma Dewata wrote: > On 8/15/2011 10:44 AM, Petr Vobornik wrote: > > On 08/11/2011 07:44 PM, Endi Sukma Dewata wrote: > >> The dialog box for resetting user password has been modified to use > >> the standard layout. > > > patch from code and working perspe

Re: [Freeipa-devel] [PATCH] 41 Verify that the external CA certificate files are correct

2011-08-18 Thread Rob Crittenden
Jan Cholasta wrote: On 17.8.2011 10:27, Jan Cholasta wrote: Verify that --external_cert_file and --external_ca_file are both readable, valid PEM files and that their subject/issuer is correct. Also fixes ipalib.x509.load_certificate_from_file. https://fedorahosted.org/freeipa/ticket/1572 Honz

[Freeipa-devel] [PATCH] 846 update ipactl man page

2011-08-18 Thread Rob Crittenden
Add a blurb about setting api.env.host for use in ipactl to control how it queries for services. rob freeipa-rcrit-846-ipactl.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/l

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-18 Thread Endi Sukma Dewata
On 8/17/2011 10:38 AM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be only a checking if approach of this patch is good. I

Re: [Freeipa-devel] [PATCH] 006 Uncheck checkboxes in association after deletion

2011-08-18 Thread Endi Sukma Dewata
On 8/18/2011 8:18 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1639 - added unchecking all checkboxes of table_widget and its derivates to on_load method. line '$('input[name=select]', that.tbody).attr('checked', false);' can be unnecessary because load method is recreating

Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-18 Thread Endi Sukma Dewata
On 8/18/2011 10:03 AM, Simo Sorce wrote: On Tue, 2011-08-16 at 16:13 -0500, Endi Sukma Dewata wrote: On 8/15/2011 10:44 AM, Petr Vobornik wrote: On 08/11/2011 07:44 PM, Endi Sukma Dewata wrote: The dialog box for resetting user password has been modified to use the standard layout. patch fr

[Freeipa-devel] [PATCH] 847 log batch commands, fix logging

2011-08-18 Thread Rob Crittenden
Log each call and result for commands in a batch call. This also fixes logging in general. I broke it pretty badly when trying to properly report JSON errors. Both should work now. rob freeipa-rcrit-847-logging.patch Description: application/mbox _

[Freeipa-devel] Trying to update nss.conf during install time

2011-08-18 Thread Adam Young
Here's a segment from my patch. All it shoudl be doing is switching NSSRenegotiation from off to on, but it doesn't have any effect. Am I missing something conceptually here? +++ b/ipaserver/install/httpinstance.py @@ -160,6 +160,9 @@ class HTTPInstance(service.Service): def __set_mod_

Re: [Freeipa-devel] [PATCH] 846 update ipactl man page

2011-08-18 Thread Martin Kosek
On Thu, 2011-08-18 at 11:57 -0400, Rob Crittenden wrote: > Add a blurb about setting api.env.host for use in ipactl to control how > it queries for services. > > rob ACK. This improves the situation. Plus, since I fixed the ticket #1558 and a list of FQDNs is printed in case of an LDAP failure,