Re: [Freeipa-devel] [PATCH] 988 fix host test

2012-03-22 Thread Rob Crittenden
Petr Viktorin wrote: On 03/15/2012 10:05 PM, Rob Crittenden wrote: A test to make sure hosts can be renamed using setattr is using an invalid hostname so the host_mod will never get hit. rob ACK pushed to master and ipa-2-2 ___ Freeipa-devel

[Freeipa-devel] [PATCH] 0013 Fix SOA record update

2012-03-22 Thread Petr Spacek
Hello, this patch fixes wrong SOA updates during DNS zone dynamic update (via nsupdate). It fixes LDAP plugin part of BZ: https://bugzilla.redhat.com/show_bug.cgi?id=805871 Incorrect SOA serial number format after IPA installation has to be solved in IPA install scripts. Petr^2 Spacek

Re: [Freeipa-devel] [PATCH] 241 Fix precallback validators in DNS plugin

2012-03-22 Thread Petr Viktorin
On 03/21/2012 01:51 PM, Martin Kosek wrote: DNS plugin contains several RR type record validators run in pre_callback which cannot be used as standard param validator as it needs more data and resources that standard validators provide. However, the precallback validators are not run for DNS

Re: [Freeipa-devel] [PATCH] 71 Propagate SIGINT to child process in ipautil.run

2012-03-22 Thread Martin Kosek
On Tue, 2012-03-20 at 17:48 +0100, Jan Cholasta wrote: Propagate SIGINT to child process in ipautil.run. Wait for the child process to terminate before continuing. Do cleanup on KeyboardInterrupt rather than in custom SIGINT handler in ipa-replica-conncheck.

Re: [Freeipa-devel] [PATCH] 241 Fix precallback validators in DNS plugin

2012-03-22 Thread Martin Kosek
On Thu, 2012-03-22 at 16:30 +0100, Petr Viktorin wrote: On 03/21/2012 01:51 PM, Martin Kosek wrote: DNS plugin contains several RR type record validators run in pre_callback which cannot be used as standard param validator as it needs more data and resources that standard validators

Re: [Freeipa-devel] [PATCH] 19 Search allowed attributes in superior objectclasses

2012-03-22 Thread Martin Kosek
On Wed, 2012-03-21 at 15:38 +0100, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2293 This patch fixes regression caused by patch for ticket #2293. The function get_allowed_attributes was searching only through the specified objectclasses but not through their superior

Re: [Freeipa-devel] [PATCH] 241 Fix precallback validators in DNS plugin

2012-03-22 Thread Petr Viktorin
On 03/22/2012 04:53 PM, Martin Kosek wrote: On Thu, 2012-03-22 at 16:30 +0100, Petr Viktorin wrote: On 03/21/2012 01:51 PM, Martin Kosek wrote: DNS plugin contains several RR type record validators run in pre_callback which cannot be used as standard param validator as it needs more data and

Re: [Freeipa-devel] [PATCH] 241 Fix precallback validators in DNS plugin

2012-03-22 Thread Martin Kosek
On Thu, 2012-03-22 at 17:19 +0100, Petr Viktorin wrote: On 03/22/2012 04:53 PM, Martin Kosek wrote: On Thu, 2012-03-22 at 16:30 +0100, Petr Viktorin wrote: On 03/21/2012 01:51 PM, Martin Kosek wrote: DNS plugin contains several RR type record validators run in pre_callback which cannot be

Re: [Freeipa-devel] [PATCH] 489 Fix coverity issues

2012-03-22 Thread Martin Kosek
On Tue, 2012-03-20 at 12:22 -0400, Simo Sorce wrote: There is one memory leak in case of an unlikely error condition, most others are just changes to silence coverity where we know that the condition cannot really happen. Simo. ACK. Pushed to master, ipa-2-2. Martin

Re: [Freeipa-devel] [PATCH] 242 Harden raw record processing in DNS plugin

2012-03-22 Thread Martin Kosek
On Wed, 2012-03-21 at 16:58 +0100, Martin Kosek wrote: Few test cases are attached to the ticket. This patch depends on my patch 241. --- There were cases where DNS plugin was too tolerant in a raw DNS record option (--rrtype-rec) processing. It let people specify DNS record parts options in

Re: [Freeipa-devel] [PATCH] 15 Confusing default user groups

2012-03-22 Thread Ondrej Hamada
On 03/19/2012 05:25 PM, Martin Kosek wrote: On Tue, 2012-03-06 at 19:07 +0100, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2354 There was added '(fallback)' string in the automember plugin labels referring to automember default groups to point out, that the users are already

Re: [Freeipa-devel] [PATCH] 242 Harden raw record processing in DNS plugin

2012-03-22 Thread Petr Viktorin
On 03/22/2012 05:38 PM, Martin Kosek wrote: On Wed, 2012-03-21 at 16:58 +0100, Martin Kosek wrote: Few test cases are attached to the ticket. This patch depends on my patch 241. --- There were cases where DNS plugin was too tolerant in a raw DNS record option (--rrtype-rec) processing. It let

[Freeipa-devel] [PATCHES] 113-114 Facet expiration flag

2012-03-22 Thread Petr Vobornik
The effort was split to two patches. See patch descriptions. Notes: Case #7 (automatic: an open facet should automatically refresh itself when it expires) I don't want to implement because I think it can cause havoc ie: refresh when user is editing. Also I was thinking about splitting

[Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-22 Thread John Dennis
[resending because I originally sent this to the wrong list] This addresses tickets 2044 and 1958. Ticket 2044 was on my short list but the code had already been written for ticket 1958 (validation of substitution variables). It had been sitting in my home directory waiting for integration so

Re: [Freeipa-devel] [PATCH] 242 Harden raw record processing in DNS plugin

2012-03-22 Thread Martin Kosek
On Thu, 2012-03-22 at 18:01 +0100, Petr Viktorin wrote: On 03/22/2012 05:38 PM, Martin Kosek wrote: On Wed, 2012-03-21 at 16:58 +0100, Martin Kosek wrote: Few test cases are attached to the ticket. This patch depends on my patch 241. --- There were cases where DNS plugin was too

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-22 Thread Petr Viktorin
On 03/22/2012 07:02 PM, John Dennis wrote: [resending because I originally sent this to the wrong list] This addresses tickets 2044 and 1958. Ticket 2044 was on my short list but the code had already been written for ticket 1958 (validation of substitution variables). It had been sitting in my

Re: [Freeipa-devel] [PATCH] 991/992 fix migration issues

2012-03-22 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2012-03-20 at 22:58 -0400, Rob Crittenden wrote: Fix a couple of issues found with migration. I made a second patch just to keep things separate even though its just a one-liner. 991 fixes a problem where we have attributes which point to other entries and these

[Freeipa-devel] [PATCH] 993 disable UPG for migration

2012-03-22 Thread Rob Crittenden
We don't want to create private groups automatically for migrated users, there could be namespace overlap (and race conditions prevent us from trying to check in advance). Check the sanity of groups in general, warn if the group for the gidnumber doesn't exist at least on the remote server.

Re: [Freeipa-devel] [PATCH] 991/992 fix migration issues

2012-03-22 Thread Martin Kosek
On Thu, 2012-03-22 at 15:17 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2012-03-20 at 22:58 -0400, Rob Crittenden wrote: Fix a couple of issues found with migration. I made a second patch just to keep things separate even though its just a one-liner. 991 fixes a problem

Re: [Freeipa-devel] [PATCH 66] Replace broken i18n shell test with Python test

2012-03-22 Thread John Dennis
On 03/22/2012 02:59 PM, Petr Viktorin wrote: On 03/22/2012 06:01 PM, John Dennis wrote: This addresses tickets 2044 and 1958. Ticket 2044 was on my short list but the code had already been written for ticket 1958 (validation of substitution variables). It had been sitting in my home directory

Re: [Freeipa-devel] [PATCH] 240 Fix LDAP effective rights control with python-ldap 2.4.x

2012-03-22 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2012-03-21 at 10:16 +0100, Jan Cholasta wrote: On 21.3.2012 09:57, Martin Kosek wrote: Test instructions are attached to the ticket. --- The new version of python-ldap changed the way it created LDAPv3 extended controls. The API used in 2.4.x can no longer be used